CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 64 Packages Projects Releases Wiki Activity

FINERACT-2459: Refactor SmsReadPlatformServiceImpl to use Prepared Statements

Browse Source
This commit is contained in:
saifulhuq01
2026-02-02 18:59:51 +01:00
committed by Adam Saghy
parent 007187111d
commit b107acb005
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/infrastructure/sms/service/SmsReadPlatformServiceImpl.java
+8 -3
View File
@@ -22,6 +22,7 @@ import jakarta.annotation.PostConstruct;
import java.sql.ResultSet; import java.sql.ResultSet;
import java.sql.SQLException; import java.sql.SQLException;
import java.time.LocalDate; import java.time.LocalDate;
import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.List; import java.util.List;
import lombok.RequiredArgsConstructor; import lombok.RequiredArgsConstructor;
@@ -131,14 +132,18 @@ public class SmsReadPlatformServiceImpl implements SmsReadPlatformService {
@Override @Override
public List<SmsData> retrieveAllPending(final Long campaignId, final Integer limit) { public List<SmsData> retrieveAllPending(final Long campaignId, final Integer limit) {
final String sqlPlusLimit = limit > 0 ? " " + sqlGenerator.limit(limit) : ""; final String sqlPlusLimit = limit > 0 ? " " + sqlGenerator.limit(limit) : "";
String sql = "select " + this.smsRowMapper.schema() + " where smo.status_enum = " + SmsMessageStatusType.PENDING.getValue(); String sql = "select " + this.smsRowMapper.schema() + " where smo.status_enum = ?";
List<Object> params = new ArrayList<>();
params.add(SmsMessageStatusType.PENDING.getValue());
if (campaignId != null) { if (campaignId != null) {
sql += " and smo.campaign_id = " + campaignId; sql += " and smo.campaign_id = ?";
params.add(campaignId);
} }
sql += sqlPlusLimit; sql += sqlPlusLimit;
return this.jdbcTemplate.query(sql, this.smsRowMapper); // NOSONAR return this.jdbcTemplate.query(sql, this.smsRowMapper, params.toArray()); // NOSONAR
} }
@Override @Override