diff --git a/fineract-provider/config/checkstyle/checkstyle.xml b/fineract-provider/config/checkstyle/checkstyle.xml index c2ac5263c..4b60508fd 100644 --- a/fineract-provider/config/checkstyle/checkstyle.xml +++ b/fineract-provider/config/checkstyle/checkstyle.xml @@ -160,6 +160,7 @@ + @@ -185,7 +186,7 @@ < ! - - TODO Checks for Exception Handling Anti-Patterns - - > - + diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/exception/DuplicateClientIdentifierException.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/exception/DuplicateClientIdentifierException.java index 9e95acf9f..69999e1b4 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/exception/DuplicateClientIdentifierException.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/exception/DuplicateClientIdentifierException.java @@ -26,14 +26,16 @@ import org.apache.fineract.infrastructure.core.exception.AbstractPlatformDomainR */ public class DuplicateClientIdentifierException extends AbstractPlatformDomainRuleException { - private Long documentTypeId; - private String identifierKey; + private final Long documentTypeId; + private final String identifierKey; private final String identifierType; public DuplicateClientIdentifierException(final String identifierType) { super("error.msg.clientIdentifier.type.duplicate", "Active Client identifier of type " + identifierType + " is already present for this client", identifierType); this.identifierType = identifierType; + this.identifierKey = null; + this.documentTypeId = null; } public DuplicateClientIdentifierException(final Long documentTypeId, final String identifierType, final String identifierKey) { @@ -51,6 +53,8 @@ public class DuplicateClientIdentifierException extends AbstractPlatformDomainRu + identifierType + " with unique key " + identifierKey, clientName, officeName, identifierType, identifierKey); this.identifierType = identifierType; this.identifierKey = identifierKey; + this.documentTypeId = null; + } public Long getDocumentTypeId() {