Merge branch 'Fineract-521' into develop

This commit is contained in:
Nazeer Hussain Shaik
2017-11-20 15:54:39 +05:30
@@ -1148,9 +1148,7 @@ public class SavingsAccount extends AbstractPersistableCustom<Long> {
final List<ApiParameterError> dataValidationErrors = new ArrayList<>(); final List<ApiParameterError> dataValidationErrors = new ArrayList<>();
final DataValidatorBuilder baseDataValidator = new DataValidatorBuilder(dataValidationErrors) final DataValidatorBuilder baseDataValidator = new DataValidatorBuilder(dataValidationErrors)
.resource(depositAccountType().resourceName() + transactionAction); .resource(depositAccountType().resourceName() + transactionAction);
if (this.allowOverdraft) { if (!this.allowOverdraft) {
baseDataValidator.reset().failWithCodeNoParameterAddedToErrorCode("results.in.balance.exceeding.overdraft.limit");
} else {
baseDataValidator.reset().failWithCodeNoParameterAddedToErrorCode("results.in.balance.going.negative"); baseDataValidator.reset().failWithCodeNoParameterAddedToErrorCode("results.in.balance.going.negative");
} }
if (!dataValidationErrors.isEmpty()) { throw new PlatformApiDataValidationException(dataValidationErrors); } if (!dataValidationErrors.isEmpty()) { throw new PlatformApiDataValidationException(dataValidationErrors); }
@@ -1160,6 +1158,13 @@ public class SavingsAccount extends AbstractPersistableCustom<Long> {
lastSavingsDate = transaction.transactionLocalDate(); lastSavingsDate = transaction.transactionLocalDate();
} }
BigDecimal withdrawalFee = null;
BigDecimal transactionAmount = null;
if(isOverdraft()) {
if (runningBalance.minus(minRequiredBalance).isLessThanZero()) { throw new InsufficientAccountBalanceException(
"transactionAmount", getAccountBalance(), withdrawalFee, transactionAmount); }
}
} }
protected boolean isAccountLocked(final LocalDate transactionDate) { protected boolean isAccountLocked(final LocalDate transactionDate) {