CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #405 from vishwasbabu/develop

Browse Source 
added max length validation for datatables
This commit is contained in:
Vishwas Babu A J
2013-06-27 03:53:06 -07:00
parent d2eac27f5f 1d9d4a5118
commit b764082717
2 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java
+1 -1
View File
@@ -117,7 +117,7 @@ public final class ResultsetColumnHeaderData {
return "datetime".equalsIgnoreCase(this.columnType); return "datetime".equalsIgnoreCase(this.columnType);
} }
private boolean isString() { public boolean isString() {
return isVarchar() || isChar(); return isVarchar() || isChar();
} }
mifosng-provider/src/main/java/org/mifosplatform/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java
+12 -6
View File
@@ -1165,24 +1165,30 @@ public class ReadWriteNonCoreDataServiceImpl implements ReadWriteNonCoreDataServ
} else { } else {
paramValue = tmpDate.toString(); paramValue = tmpDate.toString();
} }
} } else if (columnHeader.isIntegerDisplayType()) {
if (columnHeader.isIntegerDisplayType()) {
Integer tmpInt = helper.convertToInteger(paramValue, columnHeader.getColumnName(), clientApplicationLocale); Integer tmpInt = helper.convertToInteger(paramValue, columnHeader.getColumnName(), clientApplicationLocale);
if (tmpInt == null) { if (tmpInt == null) {
paramValue = null; paramValue = null;
} else { } else {
paramValue = tmpInt.toString(); paramValue = tmpInt.toString();
} }
} } else if (columnHeader.isDecimalDisplayType()) {
if (columnHeader.isDecimalDisplayType()) {
BigDecimal tmpDecimal = helper.convertFrom(paramValue, columnHeader.getColumnName(), clientApplicationLocale); BigDecimal tmpDecimal = helper.convertFrom(paramValue, columnHeader.getColumnName(), clientApplicationLocale);
if (tmpDecimal == null) { if (tmpDecimal == null) {
paramValue = null; paramValue = null;
} else { } else {
paramValue = tmpDecimal.toString(); paramValue = tmpDecimal.toString();
} }
} else if (columnHeader.isString()) {
if (paramValue.length() > columnHeader.getColumnLength()) {
ApiParameterError error = ApiParameterError.parameterError("validation.msg.datatable.entry.column.exceeds.maxlength",
"The column `" + columnHeader.getColumnName() + "` exceeds its defined max-length ",
columnHeader.getColumnName(), paramValue);
List<ApiParameterError> dataValidationErrors = new ArrayList<ApiParameterError>();
dataValidationErrors.add(error);
throw new PlatformApiDataValidationException("validation.msg.validation.errors.exist", "Validation errors exist.",
dataValidationErrors);
}
} }
} }