From c37041e6b7cb6a74882cf452a0bad0b77691c169 Mon Sep 17 00:00:00 2001
From: John Woodlock <john.woodlock@gmail.com>
Date: Thu, 31 May 2012 14:19:12 +1000
Subject: [PATCH] more api doc updates

---
 APIFolder/api.htm               | 24 +++++++++++-------
 APIFolder/docUpdateComments.txt | 43 ++++++++++++++++++++-------------
 2 files changed, 41 insertions(+), 26 deletions(-)

diff --git a/APIFolder/api.htm b/APIFolder/api.htm
index fac770980..9271bc53c 100644
--- a/APIFolder/api.htm
+++ b/APIFolder/api.htm
@@ -1538,7 +1538,12 @@ Request Body:
         <div class="method-section">
             <div class="method-description">
                 <h4>Approve, Undo Approval, Disburse, Undo Disbursal, Reject a Loan or Withdraw a Loan Application</h4>
-                <h5>Arguments</h5>
+                <h5>Arguments</h5>                <br>
+                <button type="button" onclick="showMandatoryFields('https://localhost:8443/mifosng-provider/api/v1/loans/37?command=approve', 'loan_state_transition_mandatory');">Show Mandatory Fields</button>
+                <br>
+                <div id=loan_state_transition_mandatory></div>
+                <br>
+
                 <dl class="argument-list">
                     <dt>command</dt>
                     <dd>String<span> Mandatory, case-insensitive</span></dd>
@@ -1552,15 +1557,16 @@ Request Body:
             </div>
             <div class="method-example">
                 <code class="method-declaration">POST https://thedomainname/api/v1/loans/{loanId}</code>
-                <code class="method-request">https://localhost:8443/mifosng-provider/api/v1/loans/1?command=approve
-                
-                
-                Content-Type: application/json
-                Request Body:
-                new json here
-                </code>
+                <code class="method-request">POST https://localhost:8443/mifosng-provider/api/v1/loans/1?command=approve
+Content-Type: application/json
+Request Body:
+{
+ "dateFormat": "dd MMMM yyyy",
+ "eventDate": "07 May 2012",
+ "note": "and event note is added"
+}                </code>
                 <code class="method-response">{
-"entityId": 1
+"entityId": 37
 }
                 </code>
             </div>
diff --git a/APIFolder/docUpdateComments.txt b/APIFolder/docUpdateComments.txt
index 8e907cdd2..a1d1c9722 100644
--- a/APIFolder/docUpdateComments.txt
+++ b/APIFolder/docUpdateComments.txt
@@ -1,25 +1,21 @@
 \loan\?\transactions\id get exception if loan doesn't match id.... should loan be taken out here?
 template for waiver/repayment... is it same for both? no type needed? (might have got this wrong)
-new loan template ... is it 2 templates... one to pick product... and 2nd to return default properties in selected product or is it meant that if only one product then use that. 
-
-recreate()
+---------------------------
 
 
 Lost permissions again... restore fixed it up... must be some prob with permissions/roles maintenance
 also, maybe I should be using a user that has everything but role admin.
+recreate() problem ME DO
 
+list clients notes - noteType needs a 'text' DOING
+	createdOn & updatedOn values... do they need reformatting? DOING
 
-
-
-list clients notes - noteType needs a 'text'TODO
-	createdOn & updatedOn values... do they need reformatting?TODO
-
-updating client note - ignores clientId anyhow! so is it really a notes resource? TODO
+updating client note - ignores clientId anyhow! so is it really a notes resource? DOING
 
 loan template
-Formatted field still there
+Formatted field still there DOING
 
-loan retrieve
+loan retrieve DOING
 break up data into categories.. e.g. 
 Basic - lifeCycleStatusText thru
 Convenience - open thru waitingForDisbursal then maxSubmittedOnOffsetFromToday, maxApprovedOnOffsetFromToday , maxDisbursedOnOffsetFromToday, actualLoanTermInDays, actualLoanTermInMonths,  loanTermInDays, loanTermInMonths
@@ -30,20 +26,33 @@ repaymentSchedule
 summary
 loanRepayments
 
+---------------------------------------------
+LOAN TRANSITIONS approve etc.
+if  "eventLocalDate" parameter added with string date then instead of parameter not support msg do get jackson conversion exception.
+
+approve loan (already closed) with approval date before submitted date
+The server encountered an internal error () that prevented it from fulfilling this request.</u></p><p><b>exception</b> <pre>org.mifosng.platform.loan.domain.InvalidLoanTimelineDate: The date of when loan is approved cannot be before its submittal date.
+
+approve loan (already closed) with approval date after submitted date
+Column 'loan_status_id' cannot be null; SQL [n/a]; constraint [null]; nested exception is org.hibernate.exception.ConstraintViolationException: Column 'loan_status_id' cannot be null
+
+if I do an approve when already approved also get
+Column 'loan_status_id' cannot be null; SQL [n/a]; constraint [null]; nested exception is org.hibernate.exception.ConstraintViolationException: Column 'loan_status_id' cannot be null
 
 
+
+
+somtimes client returns... always loanId OK?
+
+---------------------------------------------------------
 Additional Fields
 put right message for parameter not recognized etc.(plus tht 9 other jpwwrongmsg items)
 
 should be able to get clients by branch as well (but not for now)
-
-
-
-
-
-
+also get loans of different status's by branch etc (but not for now)
 
 Loans - what does Keith think about a description
+
 Identify Fields that need explaining
 Clients
 displayName, externalId, maxJoinedOnOffsetFromToday