CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 47 Packages Projects Releases Wiki Activity

FINERACT-2346: Minor SonarQube fixes

Browse Source
This commit is contained in:
Aman-Mittal
2025-10-15 10:05:25 +02:00
committed by Adam Saghy
parent 3b62d562a2
commit c50113a868
17 changed files with 171 additions and 148 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-core/src/main/java/org/apache/fineract/accounting/common/AccountingConstants.java
+11 -11
View File
@@ -65,7 +65,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().toString().replaceAll("_", " ");
return name().replace("_", " ");
}
public Integer getValue() {
@@ -126,7 +126,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().toString().replaceAll("_", " ");
return name().replace("_", " ");
}
public Integer getValue() {
@@ -202,7 +202,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public String getValue() {
@@ -249,7 +249,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public String getValue() {
@@ -281,7 +281,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public Integer getValue() {
@@ -330,7 +330,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public Integer getValue() {
@@ -386,7 +386,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public String getValue() {
@@ -424,7 +424,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public String getValue() {
@@ -464,7 +464,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public Integer getValue() {
@@ -529,7 +529,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public Integer getValue() {
@@ -568,7 +568,7 @@ public final class AccountingConstants {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public String getValue() {
fineract-core/src/main/java/org/apache/fineract/accounting/common/AccountingRuleType.java
+1 -1
View File
@@ -57,7 +57,7 @@ public enum AccountingRuleType {
@Override
public String toString() {
return name().replaceAll("_", " ");
return name().replace("_", " ");
}
public EnumOptionData toEnumOptionData() {
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/api/ApiParameterHelper.java
+5 -3
View File
@@ -28,6 +28,8 @@ import org.apache.fineract.infrastructure.core.serialization.JsonParserHelper;
public final class ApiParameterHelper {
private static final String GENERIC_RESULT_SET = "genericResultSet";
private ApiParameterHelper() {
}
@@ -126,14 +128,14 @@ public final class ApiParameterHelper {
public static boolean genericResultSet(final MultivaluedMap<String, String> queryParams) {
boolean genericResultSet = false;
if (queryParams.getFirst("genericResultSet") != null) {
final String genericResultSetValue = queryParams.getFirst("genericResultSet");
if (queryParams.getFirst(GENERIC_RESULT_SET) != null) {
final String genericResultSetValue = queryParams.getFirst(GENERIC_RESULT_SET);
genericResultSet = "true".equalsIgnoreCase(genericResultSetValue);
}
return genericResultSet;
}
public static boolean genericResultSetPassed(final MultivaluedMap<String, String> queryParams) {
return queryParams.getFirst("genericResultSet") != null;
return queryParams.getFirst(GENERIC_RESULT_SET) != null;
}
}
fineract-core/src/main/java/org/apache/fineract/portfolio/PortfolioProductType.java
+1 -1
View File
@@ -36,7 +36,7 @@ public enum PortfolioProductType {
@Override
public String toString() {
return name().toString().replaceAll("_", " ");
return name().replace("_", " ");
}
public Integer getValue() {
fineract-core/src/main/java/org/apache/fineract/portfolio/calendar/service/CalendarUtils.java
+3 -3
View File
@@ -285,17 +285,17 @@ public final class CalendarUtils {
NumberList nthDays = recur.getSetPosList();
Integer nthDay = null;
if (!nthDays.isEmpty()) {
nthDay = nthDays.get(0);
nthDay = nthDays.getFirst();
}
NumberList monthDays = recur.getMonthDayList();
Integer monthDay = null;
if (!monthDays.isEmpty()) {
monthDay = monthDays.get(0);
monthDay = monthDays.getFirst();
}
WeekDayList weekdays = recur.getDayList();
WeekDay weekDay = null;
if (!weekdays.isEmpty()) {
weekDay = weekdays.get(0);
weekDay = weekdays.getFirst();
}
if (nthDay != null && weekDay != null) {
NthDayType nthDayType = NthDayType.fromInt(nthDay);