FINERACT-2311: Add GET API for buy down fees related information

This commit is contained in:
Oleksii Novikov
2025-07-31 10:01:32 +02:00
committed by Adam Saghy
parent 54f055d9c7
commit ca3f63badf
17 changed files with 322 additions and 89 deletions
@@ -19,6 +19,7 @@
package org.apache.fineract.integrationtests;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -31,6 +32,7 @@ import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.atomic.AtomicReference;
import lombok.extern.slf4j.Slf4j;
import org.apache.fineract.client.models.BuyDownFeeAmortizationDetails;
import org.apache.fineract.client.models.GetLoansLoanIdResponse;
import org.apache.fineract.client.models.GetLoansLoanIdTransactions;
import org.apache.fineract.client.models.PostClientsResponse;
@@ -576,6 +578,57 @@ public class LoanBuyDownFeeTest extends BaseLoanIntegrationTest {
});
}
@Test
public void testRetrieveBuyDownFeeAmortizationDetails() {
final PostClientsResponse client = clientHelper.createClient(ClientHelper.defaultClientCreationRequest());
final PostLoanProductsResponse loanProduct = loanProductHelper.createLoanProduct(createProgressiveLoanProductWithBuyDownFee());
final long loanId = applyAndApproveProgressiveLoan(client.getClientId(), loanProduct.getResourceId(), "1 February 2024", 1000.0,
7.0, 6, null);
disburseLoan(loanId, BigDecimal.valueOf(1000), "1 February 2024");
addBuyDownFeeForLoan(loanId, 100.0, "1 February 2024");
final List<BuyDownFeeAmortizationDetails> amortizationDetails = loanTransactionHelper.fetchBuyDownFeeAmortizationDetails(loanId);
assertNotNull(amortizationDetails);
assertFalse(amortizationDetails.isEmpty());
final BuyDownFeeAmortizationDetails amortizationDetail = amortizationDetails.getFirst();
assertNotNull(amortizationDetail);
assertNotNull(amortizationDetail.getId());
assertEquals(loanId, amortizationDetail.getLoanId());
assertNotNull(amortizationDetail.getTransactionId());
assertEquals(LocalDate.of(2024, 2, 1), amortizationDetail.getBuyDownFeeDate());
assertNotNull(amortizationDetail.getBuyDownFeeAmount());
assertEquals(0, BigDecimal.valueOf(100.0).compareTo(amortizationDetail.getBuyDownFeeAmount()));
assertNotNull(amortizationDetail.getAmortizedAmount());
assertEquals(0, amortizationDetail.getAmortizedAmount().signum());
assertNotNull(amortizationDetail.getNotYetAmortizedAmount());
assertEquals(0, BigDecimal.valueOf(100.0).compareTo(amortizationDetail.getNotYetAmortizedAmount()));
}
@Test
public void testRetrieveBuyDownFeeAmortizationDetails_notEnabled() {
final PostClientsResponse client = clientHelper.createClient(ClientHelper.defaultClientCreationRequest());
final PostLoanProductsResponse loanProduct = loanProductHelper
.createLoanProduct(createProgressiveLoanProductWithBuyDownFee().enableBuyDownFee(false));
final long loanId = applyAndApproveProgressiveLoan(client.getClientId(), loanProduct.getResourceId(), "1 February 2024", 1000.0,
7.0, 6, null);
disburseLoan(loanId, BigDecimal.valueOf(1000), "1 February 2024");
final CallFailedRuntimeException exception = assertThrows(CallFailedRuntimeException.class, () -> {
addBuyDownFeeForLoan(loanId, 100.0, "1 February 2024");
});
assertEquals(400, exception.getResponse().code());
assertTrue(exception.getMessage().contains("buy.down.fee.not.enabled"));
assertTrue(exception.getMessage().contains("Buy down fee is not enabled for this loan product"));
}
@Test
public void testReverseBuyDownFeeTransaction() {
final AtomicReference<Long> buyDownFeeTransactionIdIdRef = new AtomicReference<>();
@@ -45,6 +45,7 @@ import java.util.Locale;
import java.util.Map;
import lombok.extern.slf4j.Slf4j;
import org.apache.fineract.client.models.AdvancedPaymentData;
import org.apache.fineract.client.models.BuyDownFeeAmortizationDetails;
import org.apache.fineract.client.models.CommandProcessingResult;
import org.apache.fineract.client.models.DeleteLoansLoanIdChargesChargeIdResponse;
import org.apache.fineract.client.models.DeleteLoansLoanIdResponse;
@@ -3177,4 +3178,8 @@ public class LoanTransactionHelper {
.build(clientID.toString(), loanProductID.toString(), savingsId);
return getLoanId(loanApplicationJSON);
}
public List<BuyDownFeeAmortizationDetails> fetchBuyDownFeeAmortizationDetails(Long loanId) {
return Calls.ok(FineractClientHelper.getFineractClient().loanBuyDownFeesApi.retrieveLoanBuyDownFeeAmortizationDetails(loanId));
}
}