FINERACT-2042 Configurable CreditAllocations for Loan Product
This commit is contained in:
Peter Bagrij
committed by
Peter Bagrij
Peter Bagrij
parent
02cf6749af
commit
cca520125b
+125
@@ -0,0 +1,125 @@
|
||||
/**
|
||||
* Licensed to the Apache Software Foundation (ASF) under one
|
||||
* or more contributor license agreements. See the NOTICE file
|
||||
* distributed with this work for additional information
|
||||
* regarding copyright ownership. The ASF licenses this file
|
||||
* to you under the Apache License, Version 2.0 (the
|
||||
* "License"); you may not use this file except in compliance
|
||||
* with the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing,
|
||||
* software distributed under the License is distributed on an
|
||||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
* KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
package org.apache.fineract.portfolio.loanproduct.domain;
|
||||
|
||||
import static org.apache.fineract.portfolio.loanproduct.domain.CreditAllocationsValidator.ADVANCED_PAYMENT_ALLOCATION_STRATEGY;
|
||||
import static org.mockito.Mockito.times;
|
||||
|
||||
import com.fasterxml.jackson.core.JsonProcessingException;
|
||||
import com.fasterxml.jackson.databind.ObjectMapper;
|
||||
import com.google.gson.JsonParser;
|
||||
import java.util.ArrayList;
|
||||
import java.util.EnumSet;
|
||||
import java.util.HashMap;
|
||||
import java.util.List;
|
||||
import java.util.Map;
|
||||
import java.util.concurrent.atomic.AtomicInteger;
|
||||
import org.apache.commons.lang3.tuple.Pair;
|
||||
import org.apache.fineract.infrastructure.core.api.JsonCommand;
|
||||
import org.apache.fineract.infrastructure.core.serialization.FromJsonHelper;
|
||||
import org.jetbrains.annotations.NotNull;
|
||||
import org.junit.jupiter.api.Assertions;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import org.mockito.InjectMocks;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.Mockito;
|
||||
import org.mockito.junit.jupiter.MockitoExtension;
|
||||
|
||||
@ExtendWith(MockitoExtension.class)
|
||||
public class CreditAllocationsJsonParserTest {
|
||||
|
||||
@InjectMocks
|
||||
private CreditAllocationsJsonParser creditAllocationsJsonParser;
|
||||
|
||||
@Mock
|
||||
private CreditAllocationsValidator creditAllocationsValidator;
|
||||
|
||||
private FromJsonHelper fromJsonHelper = new FromJsonHelper();
|
||||
|
||||
@Test
|
||||
public void testEmptyJson() throws JsonProcessingException {
|
||||
Map<String, Object> map = new HashMap<>();
|
||||
JsonCommand command = createJsonCommand(map);
|
||||
|
||||
// when
|
||||
List<LoanProductCreditAllocationRule> loanProductCreditAllocationRules = creditAllocationsJsonParser
|
||||
.assembleLoanProductCreditAllocationRules(command, "other-strategy");
|
||||
|
||||
// then
|
||||
Assertions.assertNull(loanProductCreditAllocationRules);
|
||||
Mockito.verify(creditAllocationsValidator, times(1)).validate(null, "other-strategy");
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testParseSingleChargebackAllocation() throws JsonProcessingException {
|
||||
// given
|
||||
Map<String, Object> map = new HashMap<>();
|
||||
List<Map<String, Object>> creditAllocations = new ArrayList<>();
|
||||
map.put("creditAllocation", creditAllocations);
|
||||
List<String> allocationRule = EnumSet.allOf(AllocationType.class).stream().map(Enum::name).toList();
|
||||
creditAllocations.add(createCreditAllocationEntry("CHARGEBACK", allocationRule));
|
||||
JsonCommand command = createJsonCommand(map);
|
||||
|
||||
// when
|
||||
List<LoanProductCreditAllocationRule> creditAllocationRules = creditAllocationsJsonParser
|
||||
.assembleLoanProductCreditAllocationRules(command, ADVANCED_PAYMENT_ALLOCATION_STRATEGY);
|
||||
|
||||
// then
|
||||
Assertions.assertEquals(1, creditAllocationRules.size());
|
||||
Assertions.assertEquals(CreditAllocationTransactionType.CHARGEBACK, creditAllocationRules.get(0).getTransactionType());
|
||||
Assertions.assertEquals(4, creditAllocationRules.get(0).getAllocationTypes().size());
|
||||
Assertions.assertEquals(EnumSet.allOf(AllocationType.class).stream().toList(), creditAllocationRules.get(0).getAllocationTypes());
|
||||
|
||||
Mockito.verify(creditAllocationsValidator, times(1)).validate(creditAllocationRules, ADVANCED_PAYMENT_ALLOCATION_STRATEGY);
|
||||
Mockito.verify(creditAllocationsValidator, times(1)).validatePairOfOrderAndCreditAllocationType(createAllocationTypeList());
|
||||
Mockito.verifyNoMoreInteractions(creditAllocationsValidator);
|
||||
}
|
||||
|
||||
private static List<Pair<Integer, AllocationType>> createAllocationTypeList() {
|
||||
AtomicInteger i = new AtomicInteger(1);
|
||||
List<Pair<Integer, AllocationType>> list = EnumSet.allOf(AllocationType.class).stream().map(p -> Pair.of(i.getAndIncrement(), p))
|
||||
.toList();
|
||||
return list;
|
||||
}
|
||||
|
||||
public Map<String, Object> createCreditAllocationEntry(String transactionType, List<String> orderedRules) {
|
||||
Map<String, Object> map = new HashMap<>();
|
||||
map.put("transactionType", transactionType);
|
||||
List<Map<String, Object>> creditAllocationOrder = new ArrayList<>();
|
||||
map.put("creditAllocationOrder", creditAllocationOrder);
|
||||
for (int i = 0; i < orderedRules.size(); i++) {
|
||||
HashMap<String, Object> entry = new HashMap<>();
|
||||
entry.put("creditAllocationRule", orderedRules.get(i));
|
||||
entry.put("order", i + 1);
|
||||
creditAllocationOrder.add(entry);
|
||||
}
|
||||
return map;
|
||||
}
|
||||
|
||||
@NotNull
|
||||
private JsonCommand createJsonCommand(Map<String, Object> jsonMap) throws JsonProcessingException {
|
||||
ObjectMapper objectMapper = new ObjectMapper();
|
||||
String json = objectMapper.writerWithDefaultPrettyPrinter().writeValueAsString(jsonMap);
|
||||
JsonCommand command = JsonCommand.from(json, JsonParser.parseString(json), fromJsonHelper, null, 1L, 2L, 3L, 4L, null, null, null,
|
||||
null, null, null, null, null);
|
||||
return command;
|
||||
}
|
||||
|
||||
}
|
||||
+132
@@ -0,0 +1,132 @@
|
||||
/**
|
||||
* Licensed to the Apache Software Foundation (ASF) under one
|
||||
* or more contributor license agreements. See the NOTICE file
|
||||
* distributed with this work for additional information
|
||||
* regarding copyright ownership. The ASF licenses this file
|
||||
* to you under the Apache License, Version 2.0 (the
|
||||
* "License"); you may not use this file except in compliance
|
||||
* with the License. You may obtain a copy of the License at
|
||||
*
|
||||
* http://www.apache.org/licenses/LICENSE-2.0
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing,
|
||||
* software distributed under the License is distributed on an
|
||||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
||||
* KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
package org.apache.fineract.portfolio.loanproduct.domain;
|
||||
|
||||
import static org.apache.fineract.portfolio.loanproduct.domain.AdvancedPaymentAllocationsValidator.ADVANCED_PAYMENT_ALLOCATION_STRATEGY;
|
||||
import static org.apache.fineract.portfolio.loanproduct.domain.CreditAllocationTransactionType.CHARGEBACK;
|
||||
import static org.junit.jupiter.api.Assertions.assertThrows;
|
||||
|
||||
import java.util.ArrayList;
|
||||
import java.util.EnumSet;
|
||||
import java.util.List;
|
||||
import java.util.concurrent.atomic.AtomicInteger;
|
||||
import org.apache.commons.lang3.tuple.Pair;
|
||||
import org.apache.fineract.infrastructure.core.exception.PlatformApiDataValidationException;
|
||||
import org.jetbrains.annotations.NotNull;
|
||||
import org.junit.jupiter.api.Assertions;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.function.Executable;
|
||||
|
||||
public class CreditAllocationsValidatorTest {
|
||||
|
||||
private CreditAllocationsValidator underTest = new CreditAllocationsValidator();
|
||||
|
||||
@Test
|
||||
public void testCreditAllocationsHasNoError() {
|
||||
underTest.validatePairOfOrderAndCreditAllocationType(createCreditAllocationTypeList());
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testCreditAllocationsValidationThrowsErrorWhenLessElement() {
|
||||
PlatformApiDataValidationException validationException = assertThrows(PlatformApiDataValidationException.class,
|
||||
() -> underTest.validatePairOfOrderAndCreditAllocationType(createCreditAllocationTypeList().subList(0, 3)));
|
||||
assertPlatformException("Each provided credit allocation must contain exactly 4 allocation rules, but 3 were provided",
|
||||
"advanced-payment-strategy.each_credit_allocation_order.must.contain.4.entries", validationException);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testCreditAllocationsValidationThrowsErrorWhenWithDuplicate() {
|
||||
ArrayList<Pair<Integer, AllocationType>> pairs = new ArrayList<>(createCreditAllocationTypeList().subList(0, 3));
|
||||
pairs.add(pairs.get(2));
|
||||
PlatformApiDataValidationException validationException = assertThrows(PlatformApiDataValidationException.class,
|
||||
() -> underTest.validatePairOfOrderAndCreditAllocationType(pairs));
|
||||
assertPlatformException("The list of provided credit allocation rules must not contain any duplicates",
|
||||
"advanced-payment-strategy.must.not.have.duplicate.credit.allocation.rule", validationException);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testCreditAllocationsValidationThrowsErrorWhenOrderIsNotInRange() {
|
||||
List<Pair<Integer, AllocationType>> pairs = createCreditAllocationTypeList().stream()
|
||||
.map(p -> Pair.of(p.getLeft() + 1, p.getRight())).toList();
|
||||
PlatformApiDataValidationException validationException = assertThrows(PlatformApiDataValidationException.class,
|
||||
() -> underTest.validatePairOfOrderAndCreditAllocationType(pairs));
|
||||
assertPlatformException("The provided orders must be between 1 and 4", "advanced-payment-strategy.invalid.order",
|
||||
validationException);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testValidateThrowsErrorWhenPaymentAllocationProvidedWithOtherStrategy() {
|
||||
assertPlatformValidationException("In case 'some-other-strategy' payment strategy, creditAllocation must not be provided",
|
||||
"credit_allocation.must.not.be.provided.when.allocation.strategy.is.not.advanced-payment-strategy",
|
||||
() -> underTest.validate(List.of(createLoanProductCreditAllocationRule1()), "some-other-strategy"));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testValidateThrowsErrorWhenTransactionTypeEmpty() {
|
||||
LoanProductCreditAllocationRule lpcar = createLoanProductCreditAllocationRule1();
|
||||
lpcar.setTransactionType(null);
|
||||
assertPlatformValidationException("Credit allocation was provided with a not valid transaction type",
|
||||
"advanced-payment-strategy.with.not.valid.transaction.type",
|
||||
() -> underTest.validate(List.of(lpcar), ADVANCED_PAYMENT_ALLOCATION_STRATEGY));
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testValidateNoError() {
|
||||
underTest.validate(List.of(createLoanProductCreditAllocationRule1()), ADVANCED_PAYMENT_ALLOCATION_STRATEGY);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testValidateCreditAllocationIsOptional() {
|
||||
underTest.validate(List.of(), ADVANCED_PAYMENT_ALLOCATION_STRATEGY);
|
||||
}
|
||||
|
||||
@Test
|
||||
public void testValidateThrowsErrorWhenDuplicate() {
|
||||
assertPlatformValidationException("The same transaction type must be provided only once",
|
||||
"advanced-payment-strategy-with-duplicate-credit-allocation",
|
||||
() -> underTest.validate(List.of(createLoanProductCreditAllocationRule1(), createLoanProductCreditAllocationRule1()),
|
||||
ADVANCED_PAYMENT_ALLOCATION_STRATEGY));
|
||||
}
|
||||
|
||||
@NotNull
|
||||
private static List<Pair<Integer, AllocationType>> createCreditAllocationTypeList() {
|
||||
AtomicInteger i = new AtomicInteger(1);
|
||||
return EnumSet.allOf(AllocationType.class).stream().map(p -> Pair.of(i.getAndIncrement(), p)).toList();
|
||||
}
|
||||
|
||||
@NotNull
|
||||
private static LoanProductCreditAllocationRule createLoanProductCreditAllocationRule1() {
|
||||
LoanProductCreditAllocationRule lpcr1 = new LoanProductCreditAllocationRule();
|
||||
lpcr1.setTransactionType(CHARGEBACK);
|
||||
lpcr1.setAllocationTypes(EnumSet.allOf(AllocationType.class).stream().toList());
|
||||
return lpcr1;
|
||||
}
|
||||
|
||||
private void assertPlatformValidationException(String message, String code, Executable executable) {
|
||||
PlatformApiDataValidationException validationException = assertThrows(PlatformApiDataValidationException.class, executable);
|
||||
assertPlatformException(message, code, validationException);
|
||||
}
|
||||
|
||||
private void assertPlatformException(String expectedMessage, String expectedCode,
|
||||
PlatformApiDataValidationException platformApiDataValidationException) {
|
||||
Assertions.assertEquals(expectedMessage, platformApiDataValidationException.getErrors().get(0).getDefaultUserMessage());
|
||||
Assertions.assertEquals(expectedCode, platformApiDataValidationException.getErrors().get(0).getUserMessageGlobalisationCode());
|
||||
}
|
||||
|
||||
}
|
||||
Reference in New Issue
Block a user