CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 46 Packages Projects Releases Wiki Activity

FINERACT-822 Enabling ErrorProne error checks (#983)

Browse Source
This commit is contained in:
Percy Ayuk Ashu
2020-06-05 16:42:01 +01:00
committed by GitHub
parent 78857bcf81
commit cd3621cb60
2 changed files with 31 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/build.gradle
+29 -26
View File
@@ -341,41 +341,44 @@ tasks.withType(JavaCompile) {
"MultipleTopLevelClasses", "MultipleTopLevelClasses",
"MultiVariableDeclaration", "MultiVariableDeclaration",
"AssertEqualsArgumentOrderChecker", "AssertEqualsArgumentOrderChecker",
"EmptySetMultibindingContributions",
"MixedArrayDimensions",
"PackageLocation",
"UseBinds",
"IntLongMath",
"FloatCast",
"ReachabilityFenceUsage",
"StreamResourceLeak",
"TruthIncompatibleType",
"ByteBufferBackingArray",
"OrphanedFormatString",
"CatchAndPrintStackTrace",
"ObjectToString",
"AssertThrowsMultipleStatements",
"BoxedPrimitiveConstructor",
"SynchronizeOnNonFinalField",
"WildcardImport",
"FutureReturnValueIgnored",
"PrivateConstructorForNoninstantiableModule",
"ClassNewInstance",
"UnsafeFinalization",
"MutableMethodReturnType",
"SwitchDefault",
"VarTypeName",
"ArgumentSelectionDefectChecker",
"CompareToZero",
"NarrowingCompoundAssignment",
// "ReturnMissingNullable", // "ReturnMissingNullable",
// "InconsistentOverloads", // "InconsistentOverloads",
// "MethodCanBeStatic", // "MethodCanBeStatic",
// "Var", // "Var",
// "ConstantField", // "ConstantField",
// "EmptySetMultibindingContributions",
// "MixedArrayDimensions",
// "PackageLocation",
// "PrivateConstructorForNoninstantiableModule",
// "UnnecessaryStaticImport", // "UnnecessaryStaticImport",
// "UseBinds",
// "WildcardImport",
// "FutureReturnValueIgnored",
// "IntLongMath",
// "FloatCast",
// "ClassNewInstance",
// "ConstructorInvokesOverridable", // "ConstructorInvokesOverridable",
// "UnsafeFinalization",
// "MutableMethodReturnType",
// "SynchronizeOnNonFinalField",
// "SwitchDefault",
// "ReachabilityFenceUsage",
// "BoxedPrimitiveConstructor",
// "InjectOnConstructorOfAbstractClass", // "InjectOnConstructorOfAbstractClass",
//// "StringSplitter", // "StringSplitter",
// "UnnecessaryDefaultInEnumSwitch", // "UnnecessaryDefaultInEnumSwitch",
// "StreamResourceLeak", // "InconsistentCapitalization",
//// "InconsistentCapitalization",
// "TruthIncompatibleType",
// "ByteBufferBackingArray",
// "OrphanedFormatString",
// "CatchAndPrintStackTrace",
// "VarTypeName",
// "ObjectToString",
// "AssertThrowsMultipleStatements",
// "FieldCanBeFinal" // "FieldCanBeFinal"
) )
} }
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java
+1 -1
View File
@@ -163,7 +163,6 @@ public class SavingsEnumerations {
optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.WITHDRAW_TRANSFER.getValue().longValue(), optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.WITHDRAW_TRANSFER.getValue().longValue(),
SavingsAccountTransactionType.WITHDRAW_TRANSFER.getCode(), "Transfer Withdrawn"); SavingsAccountTransactionType.WITHDRAW_TRANSFER.getCode(), "Transfer Withdrawn");
break; break;
default:
case PAY_CHARGE: case PAY_CHARGE:
optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.PAY_CHARGE.getValue().longValue(), optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.PAY_CHARGE.getValue().longValue(),
SavingsAccountTransactionType.PAY_CHARGE.getCode(), "Pay Charge"); SavingsAccountTransactionType.PAY_CHARGE.getCode(), "Pay Charge");
@@ -200,6 +199,7 @@ public class SavingsEnumerations {
optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.AMOUNT_RELEASE.getValue().longValue(), optionData = new SavingsAccountTransactionEnumData(SavingsAccountTransactionType.AMOUNT_RELEASE.getValue().longValue(),
SavingsAccountTransactionType.AMOUNT_RELEASE.getCode(), "Release Amount"); SavingsAccountTransactionType.AMOUNT_RELEASE.getCode(), "Release Amount");
break; break;
default:
} }
return optionData; return optionData;
} }