From db480f4213ddca6ad1058444d76c56e8961134b7 Mon Sep 17 00:00:00 2001 From: Jose Alberto Hernandez Date: Mon, 26 Dec 2022 19:51:20 -0600 Subject: [PATCH] FINERACT-1841 Fix Duplicated journal entries when a chargeback happens --- .../service/LoanWritePlatformServiceJpaRepositoryImpl.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java index 264470d93..67cf466ca 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java @@ -1226,9 +1226,6 @@ public class LoanWritePlatformServiceJpaRepositoryImpl implements LoanWritePlatf transactionId); } - final List existingTransactionIds = new ArrayList<>(); - final List existingReversedTransactionIds = new ArrayList<>(); - checkClientOrGroupActive(loan); if (loanTransaction.isReversed()) { @@ -1244,6 +1241,9 @@ public class LoanWritePlatformServiceJpaRepositoryImpl implements LoanWritePlatf transactionId); } + final List existingTransactionIds = loan.findExistingTransactionIds(); + final List existingReversedTransactionIds = loan.findExistingReversedTransactionIds(); + businessEventNotifierService.notifyPreBusinessEvent(new LoanChargebackTransactionBusinessEvent(loanTransaction)); final LocalDate transactionDate = DateUtils.getBusinessLocalDate();