From dc72c8c5f0c764cc967dad7cba1516243b57d26c Mon Sep 17 00:00:00 2001 From: Vishwas Babu A J Date: Thu, 13 Nov 2014 14:27:55 +0530 Subject: [PATCH] fixing test failures due to minimum days between disbursal and first repayment parameter being introduced in integration tests --- .../common/loans/LoanProductTestBuilder.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/mifosng-provider/src/integrationTest/java/org/mifosplatform/integrationtests/common/loans/LoanProductTestBuilder.java b/mifosng-provider/src/integrationTest/java/org/mifosplatform/integrationtests/common/loans/LoanProductTestBuilder.java index 113a5da30..fc2312747 100644 --- a/mifosng-provider/src/integrationTest/java/org/mifosplatform/integrationtests/common/loans/LoanProductTestBuilder.java +++ b/mifosng-provider/src/integrationTest/java/org/mifosplatform/integrationtests/common/loans/LoanProductTestBuilder.java @@ -42,7 +42,7 @@ public class LoanProductTestBuilder { public static final String RECALCULATION_STRATEGY_REDUCE_NUMBER_OF_INSTALLMENTS = "2"; public static final String RECALCULATION_STRATEGY_REDUCE_EMI_AMOUN = "3"; - public static final String RECALCULATION_COMPOUNDING_METHOD_NONE= "0"; + public static final String RECALCULATION_COMPOUNDING_METHOD_NONE = "0"; public static final String RECALCULATION_COMPOUNDING_METHOD_INTEREST = "1"; public static final String RECALCULATION_COMPOUNDING_METHOD_FEE = "2"; public static final String RECALCULATION_COMPOUNDING_METHOD_INTEREST_AND_FEE = "3"; @@ -56,7 +56,7 @@ public class LoanProductTestBuilder { private String inMultiplesOf = "0"; private String nameOfLoanProduct = Utils.randomNameGenerator("LOAN_PRODUCT_", 6); - private String shortName = Utils.randomNameGenerator("", 4); + private final String shortName = Utils.randomNameGenerator("", 4); private String principal = "10000.00"; private String numberOfRepayments = "5"; private String repaymentFrequency = MONTHS; @@ -76,8 +76,8 @@ public class LoanProductTestBuilder { private Account[] accountList = null; private Boolean multiDisburseLoan = false; - private String outstandingLoanBalance = "35000"; - private String maxTrancheCount = "35000"; + private final String outstandingLoanBalance = "35000"; + private final String maxTrancheCount = "35000"; private Boolean isInterestRecalculationEnabled = false; private String daysInYearType = "1"; @@ -87,7 +87,7 @@ public class LoanProductTestBuilder { private String recalculationRestFrequencyType = "1"; private String recalculationRestFrequencyInterval = "0"; private String recalculationRestFrequencyDate = null; - private String minimumDaysBetweenDisbursalAndFirstRepayment = "0"; + private String minimumDaysBetweenDisbursalAndFirstRepayment = null; public String build(final String chargeId) { final HashMap map = new HashMap<>(); @@ -379,8 +379,8 @@ public class LoanProductTestBuilder { return this; } - public LoanProductTestBuilder withMinimumDaysBetweenDisbursalAndFirstRepayment(final String minimumDaysBetweenDisbursalAndFirstRepayment){ - this.minimumDaysBetweenDisbursalAndFirstRepayment = minimumDaysBetweenDisbursalAndFirstRepayment; - return this; + public LoanProductTestBuilder withMinimumDaysBetweenDisbursalAndFirstRepayment(final String minimumDaysBetweenDisbursalAndFirstRepayment) { + this.minimumDaysBetweenDisbursalAndFirstRepayment = minimumDaysBetweenDisbursalAndFirstRepayment; + return this; } }