diff --git a/fineract-provider/build.gradle b/fineract-provider/build.gradle index 45df9b95c..ef2c5da15 100644 --- a/fineract-provider/build.gradle +++ b/fineract-provider/build.gradle @@ -460,6 +460,7 @@ tasks.withType(JavaCompile) { "EqualsGetClass", "EqualsUnsafeCast", "DoubleBraceInitialization", + "UnnecessaryDefaultInEnumSwitch", "InconsistentCapitalization", "MissingOverride", // "InvalidBlockTag", diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/SavingsProductToGLAccountMappingHelper.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/SavingsProductToGLAccountMappingHelper.java index 4ce519f7e..0fd9f9e28 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/SavingsProductToGLAccountMappingHelper.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/SavingsProductToGLAccountMappingHelper.java @@ -172,8 +172,6 @@ public class SavingsProductToGLAccountMappingHelper extends ProductToGLAccountMa break; case ACCRUAL_UPFRONT: break; - default: - break; } return changes; } @@ -237,8 +235,6 @@ public class SavingsProductToGLAccountMappingHelper extends ProductToGLAccountMa break; case ACCRUAL_UPFRONT: break; - default: - break; } } diff --git a/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ShareProductToGLAccountMappingHelper.java b/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ShareProductToGLAccountMappingHelper.java index b162eee9e..be609103c 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ShareProductToGLAccountMappingHelper.java +++ b/fineract-provider/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ShareProductToGLAccountMappingHelper.java @@ -149,8 +149,6 @@ public class ShareProductToGLAccountMappingHelper extends ProductToGLAccountMapp break; case ACCRUAL_UPFRONT: break; - default: - break; } return changes; } @@ -192,8 +190,6 @@ public class ShareProductToGLAccountMappingHelper extends ProductToGLAccountMapp break; case ACCRUAL_UPFRONT: break; - default: - break; } } diff --git a/fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java index 4f2152f1d..10bfb70ea 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/adhocquery/service/AdHocScheduledJobRunnerServiceImpl.java @@ -55,6 +55,7 @@ public class AdHocScheduledJobRunnerServiceImpl implements AdHocScheduledJobRunn @Transactional @Override @CronTarget(jobName = JobName.GENERATE_ADHOCCLIENT_SCEHDULE) + @SuppressWarnings("UnnecessaryDefaultInEnumSwitch") public void generateClientSchedule() { final Collection adhocs = this.adHocReadPlatformService.retrieveAllActiveAdHocQuery(); if (adhocs.size() > 0) { @@ -89,7 +90,6 @@ public class AdHocScheduledJobRunnerServiceImpl implements AdHocScheduledJobRunn default: throw new IllegalStateException(); } - } } diff --git a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepositoryUtils.java b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepositoryUtils.java index af9ba5daa..449438ad3 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepositoryUtils.java +++ b/fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/contentrepository/ContentRepositoryUtils.java @@ -47,6 +47,7 @@ public class ContentRepositoryUtils { return this.value; } + @SuppressWarnings("UnnecessaryDefaultInEnumSwitch") public static ImageMIMEtype fromFileExtension(ImageFileExtension fileExtension) { switch (fileExtension) { case GIF: diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformServiceImpl.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformServiceImpl.java index ac011679e..2d1cfb389 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformServiceImpl.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/account/service/PortfolioAccountReadPlatformServiceImpl.java @@ -90,8 +90,6 @@ public class PortfolioAccountReadPlatformServiceImpl implements PortfolioAccount accountData = this.jdbcTemplate.queryForObject(sql, this.savingsAccountMapper, sqlParams); break; - default: - break; } } catch (final EmptyResultDataAccessException e) { throw new AccountTransferNotFoundException(accountId); @@ -162,8 +160,6 @@ public class PortfolioAccountReadPlatformServiceImpl implements PortfolioAccount accounts = this.jdbcTemplate.query(sql, this.savingsAccountMapper, sqlParams.toArray()); break; - default: - break; } return accounts; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java index 7b2523d5a..1c4dec636 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/AccountNumberGenerator.java @@ -103,9 +103,6 @@ public class AccountNumberGenerator { prefix = propertyMap.get(SAVINGS_PRODUCT_SHORT_NAME); break; - default: - break; - } // FINERACT-590 diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientEnumerations.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientEnumerations.java index f5ddd9523..96b1786dd 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientEnumerations.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientEnumerations.java @@ -59,8 +59,6 @@ public class ClientEnumerations { optionData = new EnumOptionData(ClientStatus.TRANSFER_ON_HOLD.getValue().longValue(), ClientStatus.TRANSFER_ON_HOLD.getCode(), "Transfer on hold"); break; - default: - break; } return optionData; diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanEnumerations.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanEnumerations.java index 77f96f9b3..95dc33caa 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanEnumerations.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanEnumerations.java @@ -407,8 +407,6 @@ public class LoanEnumerations { optionData = new LoanTransactionEnumData(LoanTransactionType.INCOME_POSTING.getValue().longValue(), LoanTransactionType.INCOME_POSTING.getCode(), "Income Posting"); break; - default: - break; } return optionData; } @@ -473,8 +471,6 @@ public class LoanEnumerations { optionData = new LoanStatusEnumData(LoanStatus.TRANSFER_ON_HOLD.getValue().longValue(), LoanStatus.TRANSFER_ON_HOLD.getCode(), "Transfer on hold"); break; - default: - break; } return optionData; @@ -738,8 +734,6 @@ public class LoanEnumerations { break; case NONE: break; - default: - break; } return optionData; } diff --git a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java index b6e4fc575..0bdb0324b 100644 --- a/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java +++ b/fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsEnumerations.java @@ -288,8 +288,6 @@ public class SavingsEnumerations { SavingsAccountStatusType.MATURED.getCode(), "Matured", submittedAndPendingApproval, isApproved, isRejected, isWithdrawnByApplicant, isActive, isClosed, isPrematureClosed, isTransferInProgress, isTransferOnHold, matured); break; - default: - break; } return optionData; }