Merge pull request #696 from adamsaghy/bugfix/loanproductdata

FINERACT-839: NPE when creating a Loan for a client fix
This commit is contained in:
Awasum Yannick
2020-01-23 16:32:13 +01:00
committed by GitHub
@@ -49,6 +49,7 @@ import java.util.ArrayList;
import java.util.Collection; import java.util.Collection;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import net.sf.ehcache.util.FindBugsSuppressWarnings;
/** /**
* Immutable data object to represent loan products. * Immutable data object to represent loan products.
@@ -1134,17 +1135,15 @@ public class LoanProductData implements Serializable {
if (isInterestRecalculationEnabled()) { return this.interestRecalculationData.getRecalculationCompoundingFrequencyInterval(); } if (isInterestRecalculationEnabled()) { return this.interestRecalculationData.getRecalculationCompoundingFrequencyInterval(); }
return null; return null;
} }
@FindBugsSuppressWarnings("NP_BOOLEAN_RETURN_NULL")
public Boolean isCompoundingToBePostedAsTransaction() { public Boolean isCompoundingToBePostedAsTransaction() {
if (isInterestRecalculationEnabled()) { return isInterestRecalculationEnabled() ? this.interestRecalculationData.isCompoundingToBePostedAsTransaction() : null;
return this.interestRecalculationData.isCompoundingToBePostedAsTransaction();
} else {
return !this.interestRecalculationData.isCompoundingToBePostedAsTransaction();
}
} }
@FindBugsSuppressWarnings("NP_BOOLEAN_RETURN_NULL")
public Boolean allowCompoundingOnEod() { public Boolean allowCompoundingOnEod() {
if (isInterestRecalculationEnabled()) { return isInterestRecalculationEnabled() ? this.interestRecalculationData.allowCompoundingOnEod() : null;
return this.interestRecalculationData.allowCompoundingOnEod();
} return !this.interestRecalculationData.allowCompoundingOnEod();
} }
public boolean canDefineInstallmentAmount() { public boolean canDefineInstallmentAmount() {