Merge branch 'dev-latest' into feature/bugfix

2026-09-29 10:21:21 +05:30
parent af052dcb4f 24d3bf83bb
commit e02ab51ee1
4 changed files with 89 additions and 4 deletions
@@ -55,17 +55,25 @@ public enum PortfolioProductType {
            return null;
        }

+        // Matched against each constant's own declared value above, not its declaration position --
+        // those two orderings diverge (CLIENT is declared 3rd but its value is 5), so a switch written
+        // by position silently mapped every id past SAVING to the wrong type: 3 (really PROVISIONING)
+        // returned CLIENT, 4 (really SHARES) returned PROVISIONING, 5 (really CLIENT) returned SHARES,
+        // and 6 (CURRENT) fell through to null -- a live NPE the moment a Current-product GL entry
+        // (entity_type_enum=6) reached this on the Journal Entries screen.
        switch (v) {
            case 1:
                return LOAN;
            case 2:
                return SAVING;
            case 3:
-                return CLIENT;
-            case 4:
                return PROVISIONING;
-            case 5:
+            case 4:
                return SHARES;
+            case 5:
+                return CLIENT;
+            case 6:
+                return CURRENT;
            default:
                return null;
        }