cash-only registers, day book sections and DD amendments

Cashier reports now reconcile against the drawer:
- Received/Payment exclude what cannot be cash rather than admitting
  only proven cash, so registers that pay out without recording a
  denomination breakdown are no longer silently dropped
- Closing report scoped to the cashier, with opening/closing balance,
  reversed counter transactions excluded, and cash DD receipts counted
- Day book split into Cashier and Clerk sections, filed by whose cash
  moved rather than who raised the request

Fixed one deposit or withdrawal raising two vouchers: the cashier
deposit and clerk withdrawal registers did not suppress the inner
savings command's voucher, doubling the day's cash on both reports.

Sponsor DD:
- Amendment request flow (beneficiary, payable-at branch and city)
  under maker-checker; face value and funding stay unamendable
- Cash DD denominations were collected but never saved, and the amount
  check demanded a figure notes could not add to; both fixed and the
  breakdown is now required

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

fineract-savings/src/main/resources/db/changelog/tenant/module/savings/parts/module-changelog-master.xml

@@ -1,57 +1,58 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-
-    Licensed to the Apache Software Foundation (ASF) under one
-    or more contributor license agreements. See the NOTICE file
-    distributed with this work for additional information
-    regarding copyright ownership. The ASF licenses this file
-    to you under the Apache License, Version 2.0 (the
-    "License"); you may not use this file except in compliance
-    with the License. You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-    Unless required by applicable law or agreed to in writing,
-    software distributed under the License is distributed on an
-    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-    KIND, either express or implied. See the License for the
-    specific language governing permissions and limitations
-    under the License.
-
--->
-<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
-  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-  xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
-  <!-- Sequence is starting from 2000 to make it easier to move existing liquibase changesets here -->
-  <include file="parts/2001_add_savings_accrual_job.xml" relativeToChangelogFile="true" />
-  <include file="parts/2002_add_savings_accrual_permission.xml" relativeToChangelogFile="true" />
-  <include file="parts/2003_add_accrued_till_date_to_savings_account.xml" relativeToChangelogFile="true" />
-  <include file="parts/2004_add_savings_account_cob_infrastructure.xml" relativeToChangelogFile="true" />
-  <include file="parts/2005_add_savings_product_classification_code_values.xml" relativeToChangelogFile="true" />
-  <include file="parts/2006_add_period_frequency_options.xml" relativeToChangelogFile="true" />
-  <include file="parts/2007_add_interest_calculation_type_option.xml" relativeToChangelogFile="true" />
-  <include file="parts/2008_add_other_gl_mappings_to_savings_product.xml" relativeToChangelogFile="true" />
-  <include file="parts/2009_add_gl_account_id_to_savings_product.xml" relativeToChangelogFile="true" />
-  <include file="parts/2010_add_savings_account_cbs_fields.xml" relativeToChangelogFile="true" />
-  <include file="parts/2011_add_facility_charge_mapping.xml" relativeToChangelogFile="true" />
-  <include file="parts/2012_add_current_account_permissions.xml" relativeToChangelogFile="true" />
-  <include file="parts/2013_add_missing_current_account_columns.xml" relativeToChangelogFile="true" />
-  <include file="parts/2014_add_is_mandatory_to_joint_holders.xml" relativeToChangelogFile="true" />
-  <include file="parts/2015_add_senior_citizen_to_savings_account.xml" relativeToChangelogFile="true" />
-  <include file="parts/2016_add_share_linking_enabled_to_savings_account.xml" relativeToChangelogFile="true" />
-  <include file="parts/2017_add_saving_product_temp_table.xml" relativeToChangelogFile="true" />
-  <include file="parts/2018_fix_saving_product_temp_lock_constraint.xml" relativeToChangelogFile="true" />
-  <include file="parts/2019_add_command_source_link_to_saving_product_temp.xml" relativeToChangelogFile="true" />
-  <include file="parts/2020_generalize_product_temp_table.xml" relativeToChangelogFile="true" />
-  <include file="parts/2021_add_fd_rd_approval_permissions.xml" relativeToChangelogFile="true" />
-  <include file="parts/2022_add_product_checker_permissions.xml" relativeToChangelogFile="true" />
-  <include file="parts/2023_fix_product_approval_permissions.xml" relativeToChangelogFile="true" />
-  <include file="parts/2025_recreate_savings_product_temp_table.xml" relativeToChangelogFile="true" />
-  <include file="parts/2026_add_pending_edit_typed_columns.xml" relativeToChangelogFile="true" />
-  <include file="parts/2027_add_pending_edit_satellite_tables.xml" relativeToChangelogFile="true" />
-  <include file="parts/2028_update_saving_product_temp_table.xml" relativeToChangelogFile="true" />
-  <include file="parts/2029_remove_proposed_payload_json.xml" relativeToChangelogFile="true" />
-  <include file="parts/2030_add_savings_account_pending_edit_table.xml" relativeToChangelogFile="true" />
-  <include file="parts/2031_add_savings_account_edit_approval_permissions.xml" relativeToChangelogFile="true" />
-  <include file="parts/2032_add_share_account_id_to_savings_account.xml" relativeToChangelogFile="true" />
-</databaseChangeLog>
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements. See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership. The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License. You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied. See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+  <!-- Sequence is starting from 2000 to make it easier to move existing liquibase changesets here -->
+  <include file="parts/2001_add_savings_accrual_job.xml" relativeToChangelogFile="true" />
+  <include file="parts/2002_add_savings_accrual_permission.xml" relativeToChangelogFile="true" />
+  <include file="parts/2003_add_accrued_till_date_to_savings_account.xml" relativeToChangelogFile="true" />
+  <include file="parts/2004_add_savings_account_cob_infrastructure.xml" relativeToChangelogFile="true" />
+  <include file="parts/2005_add_savings_product_classification_code_values.xml" relativeToChangelogFile="true" />
+  <include file="parts/2006_add_period_frequency_options.xml" relativeToChangelogFile="true" />
+  <include file="parts/2007_add_interest_calculation_type_option.xml" relativeToChangelogFile="true" />
+  <include file="parts/2008_add_other_gl_mappings_to_savings_product.xml" relativeToChangelogFile="true" />
+  <include file="parts/2009_add_gl_account_id_to_savings_product.xml" relativeToChangelogFile="true" />
+  <include file="parts/2010_add_savings_account_cbs_fields.xml" relativeToChangelogFile="true" />
+  <include file="parts/2011_add_facility_charge_mapping.xml" relativeToChangelogFile="true" />
+  <include file="parts/2012_add_current_account_permissions.xml" relativeToChangelogFile="true" />
+  <include file="parts/2013_add_missing_current_account_columns.xml" relativeToChangelogFile="true" />
+  <include file="parts/2014_add_is_mandatory_to_joint_holders.xml" relativeToChangelogFile="true" />
+  <include file="parts/2015_add_senior_citizen_to_savings_account.xml" relativeToChangelogFile="true" />
+  <include file="parts/2016_add_share_linking_enabled_to_savings_account.xml" relativeToChangelogFile="true" />
+  <include file="parts/2017_add_saving_product_temp_table.xml" relativeToChangelogFile="true" />
+  <include file="parts/2018_fix_saving_product_temp_lock_constraint.xml" relativeToChangelogFile="true" />
+  <include file="parts/2019_add_command_source_link_to_saving_product_temp.xml" relativeToChangelogFile="true" />
+  <include file="parts/2020_generalize_product_temp_table.xml" relativeToChangelogFile="true" />
+  <include file="parts/2021_add_fd_rd_approval_permissions.xml" relativeToChangelogFile="true" />
+  <include file="parts/2022_add_product_checker_permissions.xml" relativeToChangelogFile="true" />
+  <include file="parts/2023_fix_product_approval_permissions.xml" relativeToChangelogFile="true" />
+  <include file="parts/2025_recreate_savings_product_temp_table.xml" relativeToChangelogFile="true" />
+  <include file="parts/2026_add_pending_edit_typed_columns.xml" relativeToChangelogFile="true" />
+  <include file="parts/2027_add_pending_edit_satellite_tables.xml" relativeToChangelogFile="true" />
+  <include file="parts/2028_update_saving_product_temp_table.xml" relativeToChangelogFile="true" />
+  <include file="parts/2029_remove_proposed_payload_json.xml" relativeToChangelogFile="true" />
+  <include file="parts/2030_add_savings_account_pending_edit_table.xml" relativeToChangelogFile="true" />
+  <include file="parts/2031_add_savings_account_edit_approval_permissions.xml" relativeToChangelogFile="true" />
+  <include file="parts/2032_add_share_account_id_to_savings_account.xml" relativeToChangelogFile="true" />
+  <include file="parts/2032_remove_withdrawal_facility.xml" relativeToChangelogFile="true" />
+</databaseChangeLog>

fineract-savings/src/main/resources/db/changelog/tenant/module/savings/parts/parts/2005_add_savings_product_classification_code_values.xml

@@ -188,4 +188,21 @@
               );
         </sql>
     </changeSet>
+
+    <changeSet author="fineract" id="2005-8-savings-product-account-type-add-normal-saving-account">
+        <sql>
+            INSERT INTO m_code (code_name, is_system_defined)
+            SELECT 'SavingsProductAccountType', TRUE
+            WHERE NOT EXISTS (SELECT 1 FROM m_code WHERE code_name = 'SavingsProductAccountType');
+
+            INSERT INTO m_code_value (code_id, code_value, order_position, code_description, is_active, is_mandatory)
+            SELECT c.id, 'Normal Saving Account', 4, 'Normal Saving Account', TRUE, FALSE
+            FROM m_code c
+            WHERE c.code_name = 'SavingsProductAccountType'
+              AND NOT EXISTS (
+                SELECT 1 FROM m_code_value cv
+                WHERE cv.code_id = c.id AND cv.code_value = 'Normal Saving Account'
+              );
+        </sql>
+    </changeSet>
 </databaseChangeLog>

fineract-savings/src/main/resources/db/changelog/tenant/module/savings/parts/parts/2032_remove_withdrawal_facility.xml

@@ -0,0 +1,101 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+    Licensed to the Apache Software Foundation (ASF) under one
+    or more contributor license agreements. See the NOTICE file
+    distributed with this work for additional information
+    regarding copyright ownership. The ASF licenses this file
+    to you under the Apache License, Version 2.0 (the
+    "License"); you may not use this file except in compliance
+    with the License. You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing,
+    software distributed under the License is distributed on an
+    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+    KIND, either express or implied. See the License for the
+    specific language governing permissions and limitations
+    under the License.
+
+-->
+<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd">
+
+  <!--
+    Retires the "Withdrawal Facility" account feature and its auto-applied charge.
+
+    The facility flag is gone from the product/account APIs and UI, so the charge can no
+    longer be switched on for anything new. This changeset stops it billing going forward
+    and hides it from charge pickers, while leaving already-posted transactions intact so
+    historical statements and the trial balance still reconcile.
+
+    The withdrawal_facility / fc_withdrawal_facility columns are deliberately NOT dropped:
+    they are simply no longer mapped or read. Dropping them would be irreversible and buys
+    nothing, and the historical changesets that created them stay untouched so Liquibase
+    checksums keep validating.
+  -->
+
+  <!-- Step 1: unmap the facility type so the seeder/auto-apply can never resolve a charge -->
+  <changeSet id="2032-1" author="cbs-keshav">
+    <preConditions onFail="MARK_RAN">
+      <tableExists tableName="m_facility_charge_mapping" />
+    </preConditions>
+    <sql>
+      DELETE FROM m_facility_charge_mapping WHERE facility_type = 'WITHDRAWAL_FACILITY';
+    </sql>
+  </changeSet>
+
+  <!-- Step 2: drop pending (unpaid, unwaived) withdrawal-facility charges from savings accounts.
+       Paid or waived rows are left alone so posted accounting entries stay balanced. -->
+  <changeSet id="2032-2" author="cbs-keshav">
+    <preConditions onFail="MARK_RAN">
+      <tableExists tableName="m_savings_account_charge" />
+    </preConditions>
+    <sql>
+      DELETE FROM m_savings_account_charge
+      WHERE charge_id IN (SELECT id FROM m_charge WHERE name = 'Withdrawal Facility Charge')
+        AND COALESCE(is_paid_derived, false) = false
+        AND COALESCE(waived, false) = false;
+    </sql>
+  </changeSet>
+
+  <!-- Step 3: soft-delete + deactivate the charge definition so it disappears from
+       charge dropdowns without breaking FKs from any historical charge rows. -->
+  <changeSet id="2032-3" author="cbs-keshav">
+    <preConditions onFail="MARK_RAN">
+      <sqlCheck expectedResult="1">SELECT COUNT(*) FROM m_charge WHERE name = 'Withdrawal Facility Charge' AND is_deleted = false</sqlCheck>
+    </preConditions>
+    <sql>
+      UPDATE m_charge SET is_active = false, is_deleted = true
+      WHERE name = 'Withdrawal Facility Charge';
+    </sql>
+  </changeSet>
+
+  <!-- Step 4: stop the flag driving anything if a stale row is still set -->
+  <changeSet id="2032-4" author="cbs-keshav">
+    <preConditions onFail="MARK_RAN">
+      <and>
+        <tableExists tableName="m_savings_account_facility_config" />
+        <columnExists tableName="m_savings_account_facility_config" columnName="withdrawal_facility" />
+      </and>
+    </preConditions>
+    <sql>
+      UPDATE m_savings_account_facility_config SET withdrawal_facility = false WHERE withdrawal_facility = true;
+    </sql>
+  </changeSet>
+
+  <changeSet id="2032-5" author="cbs-keshav">
+    <preConditions onFail="MARK_RAN">
+      <and>
+        <tableExists tableName="m_savings_product_facility_config" />
+        <columnExists tableName="m_savings_product_facility_config" columnName="withdrawal_facility" />
+      </and>
+    </preConditions>
+    <sql>
+      UPDATE m_savings_product_facility_config SET withdrawal_facility = false WHERE withdrawal_facility = true;
+    </sql>
+  </changeSet>
+
+</databaseChangeLog>