add @Disabled to 2 old unit tests (which perhaps should be removed)

This saves a few seconds ;) in the build, and (more importantly)
makes it easier to find all the project's @Disabled (formerly @Ignore) tests.
This commit is contained in:
Michael Vorburger
2020-06-24 10:39:20 +01:00
committed by Awasum Yannick
parent f1a06b42d7
commit eb2b39f160
2 changed files with 4 additions and 4 deletions
@@ -27,6 +27,7 @@ import org.apache.fineract.portfolio.loanaccount.domain.LoanRepaymentScheduleIns
import org.apache.fineract.portfolio.loanaccount.domain.transactionprocessor.impl.RBILoanRepaymentScheduleTransactionProcessor; import org.apache.fineract.portfolio.loanaccount.domain.transactionprocessor.impl.RBILoanRepaymentScheduleTransactionProcessor;
import org.joda.time.LocalDate; import org.joda.time.LocalDate;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension; import org.mockito.junit.jupiter.MockitoExtension;
@@ -38,14 +39,12 @@ public class AdhikarLoanRepaymentScheduleTransactionProcessorTest {
// class under test // class under test
private RBILoanRepaymentScheduleTransactionProcessor processor; private RBILoanRepaymentScheduleTransactionProcessor processor;
//
private final LocalDate july2nd = new LocalDate(2012, 7, 2); private final LocalDate july2nd = new LocalDate(2012, 7, 2);
private final MonetaryCurrency usDollars = new MonetaryCurrencyBuilder().withCode("USD").withDigitsAfterDecimal(2).build(); private final MonetaryCurrency usDollars = new MonetaryCurrencyBuilder().withCode("USD").withDigitsAfterDecimal(2).build();
private List<LoanRepaymentScheduleInstallment> installments; private List<LoanRepaymentScheduleInstallment> installments;
@BeforeEach @BeforeEach
public void setUpForEachTestCase() throws Exception { public void setUpForEachTestCase() throws Exception {
Field field = MoneyHelper.class.getDeclaredField("roundingMode"); Field field = MoneyHelper.class.getDeclaredField("roundingMode");
field.setAccessible(true); field.setAccessible(true);
field.set(null, RoundingMode.HALF_EVEN); field.set(null, RoundingMode.HALF_EVEN);
@@ -58,6 +57,7 @@ public class AdhikarLoanRepaymentScheduleTransactionProcessorTest {
* Scenario 1: Given no overdue installments, current interest due is paid before principal. * Scenario 1: Given no overdue installments, current interest due is paid before principal.
*/ */
@Test @Test
@Disabled
public void givenNoOverdueInstallmentsOnTimeRepaymentPaysOffInterestDueFirst() { public void givenNoOverdueInstallmentsOnTimeRepaymentPaysOffInterestDueFirst() {
// // setup // // setup
@@ -27,6 +27,7 @@ import org.apache.fineract.portfolio.loanaccount.domain.LoanRepaymentScheduleIns
import org.apache.fineract.portfolio.loanaccount.domain.transactionprocessor.impl.HeavensFamilyLoanRepaymentScheduleTransactionProcessor; import org.apache.fineract.portfolio.loanaccount.domain.transactionprocessor.impl.HeavensFamilyLoanRepaymentScheduleTransactionProcessor;
import org.joda.time.LocalDate; import org.joda.time.LocalDate;
import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith; import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.junit.jupiter.MockitoExtension; import org.mockito.junit.jupiter.MockitoExtension;
@@ -38,14 +39,12 @@ public class HeavensFamilyLoanRepaymentScheduleTransactionProcessorTest {
// class under test // class under test
private HeavensFamilyLoanRepaymentScheduleTransactionProcessor processor; private HeavensFamilyLoanRepaymentScheduleTransactionProcessor processor;
//
private final LocalDate july2nd = new LocalDate(2012, 7, 2); private final LocalDate july2nd = new LocalDate(2012, 7, 2);
private final MonetaryCurrency usDollars = new MonetaryCurrencyBuilder().withCode("USD").withDigitsAfterDecimal(2).build(); private final MonetaryCurrency usDollars = new MonetaryCurrencyBuilder().withCode("USD").withDigitsAfterDecimal(2).build();
private List<LoanRepaymentScheduleInstallment> installments; private List<LoanRepaymentScheduleInstallment> installments;
@BeforeEach @BeforeEach
public void setUpForEachTestCase() throws Exception { public void setUpForEachTestCase() throws Exception {
Field field = MoneyHelper.class.getDeclaredField("roundingMode"); Field field = MoneyHelper.class.getDeclaredField("roundingMode");
field.setAccessible(true); field.setAccessible(true);
field.set(null, RoundingMode.HALF_EVEN); field.set(null, RoundingMode.HALF_EVEN);
@@ -62,6 +61,7 @@ public class HeavensFamilyLoanRepaymentScheduleTransactionProcessorTest {
* and zero principal portion * and zero principal portion
*/ */
@Test @Test
@Disabled
public void givenSingleOnTimeLoanTransactionShouldPayoffInterestComponentFirst() { public void givenSingleOnTimeLoanTransactionShouldPayoffInterestComponentFirst() {
// // setup // // setup