From 7888ef1f1ce99e1c174a7b88fdf8fa26999f7092 Mon Sep 17 00:00:00 2001 From: Vishwas Babu A J Date: Thu, 28 Feb 2019 23:49:43 -0800 Subject: [PATCH 1/2] FINERACT-711 --- .github/PULL_REQUEST_TEMPLATE.MD | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.MD diff --git a/.github/PULL_REQUEST_TEMPLATE.MD b/.github/PULL_REQUEST_TEMPLATE.MD new file mode 100644 index 000000000..718f3b1de --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.MD @@ -0,0 +1,17 @@ +## Description +Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket + +## Checklist +Please make sure these boxes are checked before submitting your pull request - thanks! + +- [ ] Commit message starts with the issues number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. + +- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. + +- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes. + +- [ ] Integration tests have been created/updated for verifying the changes made. + +- [ ] All Integrations tests are passing with the new commit. + +- [ ] PR contains a single commit (If you have multiple commits, please squash them into a single commit). From dba938b076347cbcf07d59c82094d66c24419359 Mon Sep 17 00:00:00 2001 From: Vishwas Babu A J Date: Thu, 28 Feb 2019 23:53:40 -0800 Subject: [PATCH 2/2] Fixing typos in PULL_REQUEST_TEMPLATE --- .github/PULL_REQUEST_TEMPLATE.MD | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.MD b/.github/PULL_REQUEST_TEMPLATE.MD index 718f3b1de..f958c58e0 100644 --- a/.github/PULL_REQUEST_TEMPLATE.MD +++ b/.github/PULL_REQUEST_TEMPLATE.MD @@ -4,7 +4,7 @@ Describe the changes made and why they were made. Ignore if these details are pr ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! -- [ ] Commit message starts with the issues number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. +- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.