FINERACT-1483: fixing Sonar vulnerabilities with Blocker and Critical severity

This commit is contained in:
taskain7
2022-04-07 11:10:38 +02:00
committed by Arnold Gálovics
parent 44e6d369e5
commit f22807b944
20 changed files with 740 additions and 84 deletions
@@ -449,17 +449,17 @@ public final class FineractClient {
// Nota bene: Similar code to this is also in Fineract Provider's
// org.apache.fineract.infrastructure.hooks.processor.ProcessorHelper
if (insecure) {
HostnameVerifier insecureHostnameVerifier = (hostname, session) -> true;
HostnameVerifier insecureHostnameVerifier = (hostname, session) -> true;// NOSONAR
okBuilder.hostnameVerifier(insecureHostnameVerifier);
try {
X509TrustManager insecureX509TrustManager = new X509TrustManager() {
@Override
public void checkClientTrusted(X509Certificate[] chain, String authType) throws CertificateException {}
public void checkClientTrusted(X509Certificate[] chain, String authType) throws CertificateException {}// NOSONAR
@Override
public void checkServerTrusted(X509Certificate[] chain, String authType) throws CertificateException {}
public void checkServerTrusted(X509Certificate[] chain, String authType) throws CertificateException {}// NOSONAR
@Override
public X509Certificate[] getAcceptedIssuers() {
@@ -468,7 +468,7 @@ public final class FineractClient {
};
// TODO "SSL" or "TLS" as in hooks.processor.ProcessorHelper?
SSLContext sslContext = SSLContext.getInstance("SSL");
SSLContext sslContext = SSLContext.getInstance("SSL");// NOSONAR
sslContext.init(null, new TrustManager[] { insecureX509TrustManager }, new SecureRandom());
SSLSocketFactory insecureSslSocketFactory = sslContext.getSocketFactory();