CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 47 Packages Projects Releases Wiki Activity

[FINERACT-223] In topup loan if the "Choose loan to close" is selected in modified loan product then internal server error is displaying.

Browse Source
This commit is contained in:
Adi Narayana Raju
2016-08-23 13:25:26 +05:30
parent 8327b112a1
commit f33b583083
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanApplicationWritePlatformServiceJpaRepositoryImpl.java
+5 -2
View File
@@ -674,13 +674,16 @@ public class LoanApplicationWritePlatformServiceJpaRepositoryImpl implements Loa
if(existingLoanApplication.isTopup()){ if(existingLoanApplication.isTopup()){
final Long loanIdToClose = command.longValueOfParameterNamed(LoanApiConstants.loanIdToClose); final Long loanIdToClose = command.longValueOfParameterNamed(LoanApiConstants.loanIdToClose);
LoanTopupDetails existingLoanTopupDetails = existingLoanApplication.getTopupLoanDetails(); LoanTopupDetails existingLoanTopupDetails = existingLoanApplication.getTopupLoanDetails();
final Long existingLoanIdToClose = existingLoanTopupDetails.getLoanIdToClose();
if(existingLoanTopupDetails == null if(existingLoanTopupDetails == null
|| (existingLoanTopupDetails != null && existingLoanIdToClose != loanIdToClose) || (existingLoanTopupDetails != null && existingLoanTopupDetails.getLoanIdToClose() != loanIdToClose)
|| changes.containsKey("submittedOnDate") || changes.containsKey("submittedOnDate")
|| changes.containsKey("expectedDisbursementDate") || changes.containsKey("expectedDisbursementDate")
|| changes.containsKey("principal") || changes.containsKey("principal")
|| changes.containsKey(LoanApiConstants.disbursementDataParameterName)){ || changes.containsKey(LoanApiConstants.disbursementDataParameterName)){
Long existingLoanIdToClose = null;
if(existingLoanTopupDetails != null){
existingLoanIdToClose = existingLoanTopupDetails.getLoanIdToClose();
}
final Loan loanToClose = this.loanRepository.findNonClosedLoanThatBelongsToClient(loanIdToClose, existingLoanApplication.getClientId()); final Loan loanToClose = this.loanRepository.findNonClosedLoanThatBelongsToClient(loanIdToClose, existingLoanApplication.getClientId());
if(loanToClose == null){ if(loanToClose == null){
throw new GeneralPlatformDomainRuleException("error.msg.loan.loanIdToClose.no.active.loan.associated.to.client.found", throw new GeneralPlatformDomainRuleException("error.msg.loan.loanIdToClose.no.active.loan.associated.to.client.found",