FINERACT-696

add spotbug bug-pattern plugin.

Apply suggestions from code review

closes https://issues.apache.org/jira/browse/FINERACT-696

Co-Authored-By: Michael Vorburger ⛑️ <mike@vorburger.ch>

fineract-provider/build.gradle

@@ -39,14 +39,14 @@ buildscript {
                'nl.javadude.gradle.plugins:license-gradle-plugin:0.11.0',
                'org.zeroturnaround:gradle-jrebel-plugin:1.1.2',
                'org.springframework.boot:spring-boot-gradle-plugin:2.2.4.RELEASE'
-      // below
+     // below
      classpath "org.apache.openjpa:openjpa:$openJPAVersion"
      classpath 'com.radcortez.gradle:openjpa-gradle-plugin:3.1.0'
      classpath 'gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.2.2'
-      classpath "com.github.spotbugs:spotbugs-gradle-plugin:2.0.1"
-      // Use Guava version 23+ as a workaround to spotbug intergration.
-      // See: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/128#issuecomment-535864882
-      classpath 'com.google.guava:guava:28.1-jre'
+     classpath "com.github.spotbugs:spotbugs-gradle-plugin:2.0.1"
+     // Use Guava version 23+ as a workaround to spotbug intergration.
+     // See: https://github.com/spotbugs/spotbugs-gradle-plugin/issues/128#issuecomment-535864882
+     classpath 'com.google.guava:guava:28.1-jre'
   }
 }
 
@@ -103,6 +103,7 @@ dependencyManagement {
      //dependency 'junit:junit-dep:4.11'
      dependency 'org.mockito:mockito-core:+'
      dependency 'com.jayway.restassured:rest-assured:2.3.3'
+     dependency 'org.slf4j:slf4j-simple:1.7.30'
      dependency 'com.mockrunner:mockrunner-jms:2.0.1'
      dependency 'com.mockrunner:mockrunner-jdbc:2.0.1'