From f6c50bf1c59ee06b4f12e5db089696cd5058a0fa Mon Sep 17 00:00:00 2001 From: a7med3del1973 Date: Thu, 20 Feb 2025 17:20:29 +0200 Subject: [PATCH] FINERACT-2081: Define a constant instead of duplicating --- .../FinancialActivityAccountNotFoundException.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fineract-accounting/src/main/java/org/apache/fineract/accounting/financialactivityaccount/exception/FinancialActivityAccountNotFoundException.java b/fineract-accounting/src/main/java/org/apache/fineract/accounting/financialactivityaccount/exception/FinancialActivityAccountNotFoundException.java index 6f18f84a9..22f101813 100644 --- a/fineract-accounting/src/main/java/org/apache/fineract/accounting/financialactivityaccount/exception/FinancialActivityAccountNotFoundException.java +++ b/fineract-accounting/src/main/java/org/apache/fineract/accounting/financialactivityaccount/exception/FinancialActivityAccountNotFoundException.java @@ -26,17 +26,19 @@ import org.springframework.dao.EmptyResultDataAccessException; */ public class FinancialActivityAccountNotFoundException extends AbstractPlatformResourceNotFoundException { + private static final String DOES_NOT_EXIST = " does not exist"; + private static final String ERROR_CODE = "error.msg.financialActivityAccount.not.found"; + public FinancialActivityAccountNotFoundException(final Long id) { - super("error.msg.financialActivityAccount.not.found", "Financial Activity account with Id " + id + " does not exist", id); + super(ERROR_CODE, "Financial Activity account with Id " + id + DOES_NOT_EXIST, id); } public FinancialActivityAccountNotFoundException(final Long id, EmptyResultDataAccessException e) { - super("error.msg.financialActivityAccount.not.found", "Financial Activity account with Id " + id + " does not exist", id, e); + super(ERROR_CODE, "Financial Activity account with Id " + id + DOES_NOT_EXIST, id, e); } public FinancialActivityAccountNotFoundException(final Integer financialActivityType) { - super("error.msg.financialActivityAccount.not.found", - "Financial Activity account with for the financial Activity with Id " + financialActivityType + " does not exist", + super(ERROR_CODE, "Financial Activity account with for the financial Activity with Id " + financialActivityType + DOES_NOT_EXIST, financialActivityType); }