CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 46 Packages Projects Releases Wiki Activity

[FINERACT-747] change String.replaceAll() to replace() to improve performance

Browse Source
This commit is contained in:
bd2019us
2019-04-13 19:52:58 -05:00
parent 8af4943427
commit f8c5de3e96
8 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleJsonInputParams.java
+1 -1
View File
@@ -48,7 +48,7 @@ public enum AccountingRuleJsonInputParams {
@Override @Override
public String toString() { public String toString() {
return name().toString().replaceAll("_", " "); return name().toString().replace("_", " ");
} }
public String getValue() { public String getValue() {
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/fixeddeposits/FixedDepositTransactionWorkbookPopulator.java
+1 -1
View File
@@ -158,7 +158,7 @@ public class FixedDepositTransactionWorkbookPopulator extends AbstractWorkbookPo
//Account Number Named after Clients //Account Number Named after Clients
for(int j = 0; j < clientsWithActiveSavings.size(); j++) { for(int j = 0; j < clientsWithActiveSavings.size(); j++) {
Name name = savingsTransactionWorkbook.createName(); Name name = savingsTransactionWorkbook.createName();
name.setNameName("Account_" + clientsWithActiveSavings.get(j).replaceAll(" ", "_") + "_" + clientIdsWithActiveSavings.get(j) + "_"); name.setNameName("Account_" + clientsWithActiveSavings.get(j).replace(" ", "_") + "_" + clientIdsWithActiveSavings.get(j) + "_");
name.setRefersToFormula(TemplatePopulateImportConstants.FIXED_DEPOSIT_TRANSACTION_SHEET_NAME+"!$Q$" + clientNameToBeginEndIndexes.get(clientsWithActiveSavings.get(j))[0] + ":$Q$" + clientNameToBeginEndIndexes.get(clientsWithActiveSavings.get(j))[1]); name.setRefersToFormula(TemplatePopulateImportConstants.FIXED_DEPOSIT_TRANSACTION_SHEET_NAME+"!$Q$" + clientNameToBeginEndIndexes.get(clientsWithActiveSavings.get(j))[0] + ":$Q$" + clientNameToBeginEndIndexes.get(clientsWithActiveSavings.get(j))[1]);
} }
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/loanrepayment/LoanRepaymentWorkbookPopulator.java
+1 -1
View File
@@ -199,7 +199,7 @@ public class LoanRepaymentWorkbookPopulator extends AbstractWorkbookPopulator {
// Account Number Named after Clients // Account Number Named after Clients
for (int j = 0; j < clientsWithActiveLoans.size(); j++) { for (int j = 0; j < clientsWithActiveLoans.size(); j++) {
Name name = loanRepaymentWorkbook.createName(); Name name = loanRepaymentWorkbook.createName();
name.setNameName("Account_" + clientsWithActiveLoans.get(j).replaceAll(" ", "_") + "_" name.setNameName("Account_" + clientsWithActiveLoans.get(j).replace(" ", "_") + "_"
+ clientIdsWithActiveLoans.get(j) + "_"); + clientIdsWithActiveLoans.get(j) + "_");
name.setRefersToFormula( name.setRefersToFormula(
TemplatePopulateImportConstants.LOAN_REPAYMENT_SHEET_NAME+"!$T$" + clientNameToBeginEndIndexes.get(clientsWithActiveLoans.get(j))[0] + ":$T$" TemplatePopulateImportConstants.LOAN_REPAYMENT_SHEET_NAME+"!$T$" + clientNameToBeginEndIndexes.get(clientsWithActiveLoans.get(j))[0] + ":$T$"
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/savings/SavingsTransactionsWorkbookPopulator.java
+1 -1
View File
@@ -163,7 +163,7 @@ public class SavingsTransactionsWorkbookPopulator extends AbstractWorkbookPopula
//Account Number Named after Clients //Account Number Named after Clients
for(int j = 0; j < clientsWithActiveSavings.size(); j++) { for(int j = 0; j < clientsWithActiveSavings.size(); j++) {
Name name = savingsTransactionWorkbook.createName(); Name name = savingsTransactionWorkbook.createName();
name.setNameName("Account_" + clientsWithActiveSavings.get(j).replaceAll(" ", "_") + "_" + clientIdsWithActiveSavings.get(j) + "_"); name.setNameName("Account_" + clientsWithActiveSavings.get(j).replace(" ", "_") + "_" + clientIdsWithActiveSavings.get(j) + "_");
name.setRefersToFormula(TemplatePopulateImportConstants.SAVINGS_TRANSACTION_SHEET_NAME+"!$Q$" + clientNameToBeginEndIndexes.get(clientsWithActiveSavings.get(j))[0] + ":$Q$" + clientNameToBeginEndIndexes.get(clientsWithActiveSavings.get(j))[1]); name.setRefersToFormula(TemplatePopulateImportConstants.SAVINGS_TRANSACTION_SHEET_NAME+"!$Q$" + clientNameToBeginEndIndexes.get(clientsWithActiveSavings.get(j))[0] + ":$Q$" + clientNameToBeginEndIndexes.get(clientsWithActiveSavings.get(j))[1]);
} }
fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java
+1 -1
View File
@@ -53,7 +53,7 @@ public enum ConditionType {
@Override @Override
public String toString() { public String toString() {
return name().toString().replaceAll("_", " "); return name().toString().replace("_", " ");
} }
public Integer getValue() { public Integer getValue() {
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/CenterReadPlatformServiceImpl.java
+2 -2
View File
@@ -131,8 +131,8 @@ public class CenterReadPlatformServiceImpl implements CenterReadPlatformService
String sqlQueryCriteria = searchCriteria.getSqlSearch(); String sqlQueryCriteria = searchCriteria.getSqlSearch();
if (StringUtils.isNotBlank(sqlQueryCriteria)) { if (StringUtils.isNotBlank(sqlQueryCriteria)) {
SQLInjectionValidator.validateSQLInput(sqlQueryCriteria); SQLInjectionValidator.validateSQLInput(sqlQueryCriteria);
sqlQueryCriteria = sqlQueryCriteria.replaceAll(" display_name ", " g.display_name "); sqlQueryCriteria = sqlQueryCriteria.replace(" display_name ", " g.display_name ");
sqlQueryCriteria = sqlQueryCriteria.replaceAll("display_name ", "g.display_name "); sqlQueryCriteria = sqlQueryCriteria.replace("display_name ", "g.display_name ");
extraCriteria.append(" and (").append(sqlQueryCriteria).append(") "); extraCriteria.append(" and (").append(sqlQueryCriteria).append(") ");
this.columnValidator.validateSqlInjection(schemaSl, sqlQueryCriteria); this.columnValidator.validateSqlInjection(schemaSl, sqlQueryCriteria);
} }
fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupReadPlatformServiceImpl.java
+2 -2
View File
@@ -221,8 +221,8 @@ public class GroupReadPlatformServiceImpl implements GroupReadPlatformService {
String sqlSearch = searchCriteria.getSqlSearch(); String sqlSearch = searchCriteria.getSqlSearch();
if (sqlSearch != null) { if (sqlSearch != null) {
SQLInjectionValidator.validateSQLInput(sqlSearch); SQLInjectionValidator.validateSQLInput(sqlSearch);
sqlSearch = sqlSearch.replaceAll(" display_name ", " g.display_name "); sqlSearch = sqlSearch.replace(" display_name ", " g.display_name ");
sqlSearch = sqlSearch.replaceAll("display_name ", "g.display_name "); sqlSearch = sqlSearch.replace("display_name ", "g.display_name ");
extraCriteria.append(" and ( ").append(sqlSearch).append(") "); extraCriteria.append(" and ( ").append(sqlSearch).append(") ");
this.columnValidator.validateSqlInjection(schemaSql, sqlSearch); this.columnValidator.validateSqlInjection(schemaSql, sqlSearch);
} }
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
+1 -1
View File
@@ -306,7 +306,7 @@ public class LoanReadPlatformServiceImpl implements LoanReadPlatformService {
String sqlQueryCriteria = searchParameters.getSqlSearch(); String sqlQueryCriteria = searchParameters.getSqlSearch();
if (StringUtils.isNotBlank(sqlQueryCriteria)) { if (StringUtils.isNotBlank(sqlQueryCriteria)) {
SQLInjectionValidator.validateSQLInput(sqlQueryCriteria); SQLInjectionValidator.validateSQLInput(sqlQueryCriteria);
sqlQueryCriteria = sqlQueryCriteria.replaceAll("accountNo", "l.account_no"); sqlQueryCriteria = sqlQueryCriteria.replace("accountNo", "l.account_no");
this.columnValidator.validateSqlInjection(sqlBuilder.toString(), sqlQueryCriteria); this.columnValidator.validateSqlInjection(sqlBuilder.toString(), sqlQueryCriteria);
sqlBuilder.append(" and (").append(sqlQueryCriteria).append(")"); sqlBuilder.append(" and (").append(sqlQueryCriteria).append(")");
} }