FINERACT-2169: Provision category definition api refactor;

This commit is contained in:
viktorpavlenko
2025-03-05 22:39:49 +00:00
committed by Adam Saghy
parent bd66037910
commit f8e5d6c9fc
7 changed files with 50 additions and 86 deletions
@@ -25,7 +25,6 @@ import static org.mockito.Mockito.verifyNoInteractions;
import static org.springframework.batch.repeat.RepeatStatus.FINISHED;
import java.time.LocalDate;
import java.util.Collection;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
@@ -75,7 +74,7 @@ class GenerateLoanlossProvisioningTaskletTest {
@Test
public void testExecuteShouldCreateProvisioningEntry() throws Exception {
// given
Collection<ProvisioningCriteriaData> provisioningCriterias = List.of(new ProvisioningCriteriaData());
List<ProvisioningCriteriaData> provisioningCriterias = List.of(new ProvisioningCriteriaData());
given(provisioningCriteriaReadPlatformService.retrieveAllProvisioningCriterias()).willReturn(provisioningCriterias);
// when
RepeatStatus result = underTest.execute(stepContribution, chunkContext);
@@ -87,7 +86,7 @@ class GenerateLoanlossProvisioningTaskletTest {
@Test
public void testExecuteShouldNotCreateProvisioningEntryWhenNoProvisioningCriteriasArePresent() throws Exception {
// given
Collection<ProvisioningCriteriaData> provisioningCriterias = List.of();
List<ProvisioningCriteriaData> provisioningCriterias = List.of();
given(provisioningCriteriaReadPlatformService.retrieveAllProvisioningCriterias()).willReturn(provisioningCriterias);
// when
RepeatStatus result = underTest.execute(stepContribution, chunkContext);
@@ -110,7 +109,7 @@ class GenerateLoanlossProvisioningTaskletTest {
@Test
public void testExecuteShouldNotFailWhenProvisioningEntryIsAlreadyCreated() throws Exception {
// given
Collection<ProvisioningCriteriaData> provisioningCriterias = List.of(new ProvisioningCriteriaData());
List<ProvisioningCriteriaData> provisioningCriterias = List.of(new ProvisioningCriteriaData());
given(provisioningCriteriaReadPlatformService.retrieveAllProvisioningCriterias()).willReturn(provisioningCriterias);
given(provisioningEntriesWritePlatformService.createProvisioningEntry(BUSINESS_DATE, true))
.willThrow(new ProvisioningEntryAlreadyCreatedException(1L, BUSINESS_DATE));
@@ -124,7 +123,7 @@ class GenerateLoanlossProvisioningTaskletTest {
@Test
public void testExecuteShouldNotFailWhenExceptionIsThrownInProvisioningEntryCreation() throws Exception {
// given
Collection<ProvisioningCriteriaData> provisioningCriterias = List.of(new ProvisioningCriteriaData());
List<ProvisioningCriteriaData> provisioningCriterias = List.of(new ProvisioningCriteriaData());
given(provisioningCriteriaReadPlatformService.retrieveAllProvisioningCriterias()).willReturn(provisioningCriterias);
given(provisioningEntriesWritePlatformService.createProvisioningEntry(BUSINESS_DATE, true)).willThrow(new RuntimeException("Test"));
// when