CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 29 Packages Projects Releases Wiki Activity

improve ClientSavingsIntegrationTest error reporting (FINERACT-852) (#765)

Browse Source 
Adds a new assertion for a hopefully clearer failure message than the
confusing low-level technical ArrayIndexOutOfBoundsException we
regularly hit on Travis CI.

Similar to https://github.com/apache/fineract/pull/764
This commit is contained in:
Michael Vorburger ⛑️
2020-04-15 09:34:33 +01:00
committed by GitHub
parent 26b619eea7
commit fd7fa63002
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/ClientSavingsIntegrationTest.java
+2 -6
View File
@@ -1909,7 +1909,7 @@ public class ClientSavingsIntegrationTest {
} }
@Test @Test
public void testSavingsAccount_DormancyTracking() { public void testSavingsAccount_DormancyTracking() throws InterruptedException {
this.savingsAccountHelper = new SavingsAccountHelper(this.requestSpec, this.responseSpec); this.savingsAccountHelper = new SavingsAccountHelper(this.requestSpec, this.responseSpec);
final Integer clientID = ClientHelper.createClient(this.requestSpec, this.responseSpec); final Integer clientID = ClientHelper.createClient(this.requestSpec, this.responseSpec);
@@ -1973,11 +1973,7 @@ public class ClientSavingsIntegrationTest {
} }
SchedulerJobHelper jobHelper = new SchedulerJobHelper(this.requestSpec, this.responseSpec); SchedulerJobHelper jobHelper = new SchedulerJobHelper(this.requestSpec, this.responseSpec);
try { jobHelper.executeJob("Update Savings Dormant Accounts");
jobHelper.executeJob("Update Savings Dormant Accounts");
} catch (InterruptedException e) {
e.printStackTrace();
}
//VERIFY WITHIN PROVIDED RANGE DOESN'T INACTIVATE //VERIFY WITHIN PROVIDED RANGE DOESN'T INACTIVATE
savingsStatusHashMap = SavingsStatusChecker.getStatusOfSavings(this.requestSpec, this.responseSpec, savingsList.get(0)); savingsStatusHashMap = SavingsStatusChecker.getStatusOfSavings(this.requestSpec, this.responseSpec, savingsList.get(0));
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/SchedulerJobHelper.java
+6 -3
View File
@@ -24,6 +24,7 @@ import io.restassured.specification.RequestSpecification;
import io.restassured.specification.ResponseSpecification; import io.restassured.specification.ResponseSpecification;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.HashMap; import java.util.HashMap;
import java.util.List;
import org.junit.Assert; import org.junit.Assert;
@SuppressWarnings({ "rawtypes", "unchecked" }) @SuppressWarnings({ "rawtypes", "unchecked" })
@@ -104,12 +105,12 @@ public class SchedulerJobHelper {
return runSchedulerJob; return runSchedulerJob;
} }
public void executeJob(String JobName) throws InterruptedException { public void executeJob(String jobName) throws InterruptedException {
ArrayList<HashMap> allSchedulerJobsData = getAllSchedulerJobs(this.requestSpec, this.responseSpec); ArrayList<HashMap> allSchedulerJobsData = getAllSchedulerJobs(this.requestSpec, this.responseSpec);
Assert.assertNotNull(allSchedulerJobsData); Assert.assertNotNull(allSchedulerJobsData);
for (Integer jobIndex = 0; jobIndex < allSchedulerJobsData.size(); jobIndex++) { for (Integer jobIndex = 0; jobIndex < allSchedulerJobsData.size(); jobIndex++) {
if (allSchedulerJobsData.get(jobIndex).get("displayName").equals(JobName)) { if (allSchedulerJobsData.get(jobIndex).get("displayName").equals(jobName)) {
Integer jobId = (Integer) allSchedulerJobsData.get(jobIndex).get("jobId"); Integer jobId = (Integer) allSchedulerJobsData.get(jobIndex).get("jobId");
// Executing Scheduler Job // Executing Scheduler Job
@@ -127,7 +128,9 @@ public class SchedulerJobHelper {
System.out.println("Job is Still Running"); System.out.println("Job is Still Running");
} }
ArrayList<HashMap> jobHistoryData = getSchedulerJobHistory(this.requestSpec, this.responseSpec, jobId.toString()); List<HashMap> jobHistoryData = getSchedulerJobHistory(this.requestSpec, this.responseSpec, jobId.toString());
Assert.assertFalse("Job History is empty :( Was it too slow? Failures in background job?", jobHistoryData.isEmpty());
// print error associated with recent job failure (if any) // print error associated with recent job failure (if any)
System.out.println("Job run error message (printed only if the job fails: " System.out.println("Job run error message (printed only if the job fails: "