Commit Graph
775 Commits
Author SHA1 Message Date
percyashuandMichael Vorburger ⛑️ e10a78b2bd FINERACT-822 Integrating Error Prone 2020-05-28 20:40:35 +02:00
Manthan SurkarandMichael Vorburger ⛑️ ef538e5c75 FINERACT-821 Added and Enforced ArrayTypeStyle checkstyle 2020-05-27 11:27:32 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 3e95c32e18 FINERACT-821 Added and enforced NeedBraces Checkstyle 2020-05-27 00:13:22 +02:00
Avik GangulyandGitHub 50d5d08378 Merge pull request #769 from fynmanoj/findevfdrollover
FINERACT-893-fixed-deposit-rollover
2020-05-26 21:07:42 +05:30
Manthan SurkarandMichael Vorburger ⛑️ 01e8014ea2 FINERACT-821 Added and Enforced upperEll checkstyle 2020-05-26 09:30:59 +02:00
Petri TuomolaandGitHub 562b2a1d97 FINERACT-874: Removing files related to old release process (#890) 2020-05-25 08:50:24 +01:00
Michael Vorburger ⛑️andGitHub b3da50c960 intro. SchedulerJobsHelper.executeAndAwaitJob() [FINERACT-922] (#817) 2020-05-24 20:54:37 +01:00
Michael Vorburger ⛑️andGitHub 4cb9f9d3e0 improve logging in SchedulerTriggerListener (re. FINERACT-922) (#812) 2020-05-24 20:18:36 +01:00
Saransh SharmaandMichael Vorburger ⛑️ ce570b4b33 Fixed Accounting findProductIdAndProductTypeAndFinancialAccountTypeAndChargeId 2020-05-24 10:43:29 +02:00
xurrorandMichael Vorburger ⛑️ 81fc89c58c Create no-args constructors for PU 2020-05-24 10:12:38 +02:00
Manoj bd99138aad FINERACT-893-fixed-deposit-rollover 2020-05-23 22:52:39 +05:30
Michael VorburgerandYemdjih Kaze Nasser 5b1c46c821 remove logback.xml (see FINERACT-888)
Read e.g. https://12factor.net/logs for why we don't want to log
to a fineract-platform.log file anymore by default.  Of course, anyone
could still customize logging as they see fit for their own deployments.
2020-05-23 12:38:20 +01:00
thesmallstarandMichael Vorburger ⛑️ baa1177854 FINERACT-821 Added and Enforced Typename checkstyle 2020-05-22 15:23:23 +02:00
Michael VorburgerandYemdjih Kaze Nasser 3d0d515b4b ignore StorageTest [FINERACT-828] 2020-05-22 03:56:22 +01:00
nnatarajanandMichael Vorburger ⛑️ 96452f3ff4 Fineract-955 - Upgrade ical4j from ancient version 1.0.7 to current 3.0.18 2020-05-22 00:07:37 +02:00
thesmallstarandMichael Vorburger ⛑️ 16fb971f45 FINERACT-942 Remove use of printStackTrace and added checkstyle 2020-05-21 21:48:11 +02:00
Petri TuomolaandMichael Vorburger ⛑️ acfec8bb94 FINERACT-723: Fixing date comparisons that resulting in a problem when timezone is different on database and application server 2020-05-21 11:50:30 +02:00
xurrorandMichael Vorburger ⛑️ 3bc7914068 Update spotbugs to v4.2.0(FINERACT-986) 2020-05-21 10:52:42 +02:00
Yemdjih Kaze NasserandGitHub 44376ca1fe Merge pull request #911 from vorburger/FINERACT-953_groovy
improve ClasspathHellDuplicatesCheckRuleTest (req. by FINERACT-953)
2020-05-20 01:21:45 +01:00
xurrorandMichael Vorburger ⛑️ dc3af0c867 FINERACT-964
bump json-path from 0.9.1 to 2.4.0
2020-05-20 00:56:20 +02:00
percyashuandMichael Vorburger ⛑️ 610375753c FINERACT-959 make javac fail for Xlint:cast 2020-05-20 00:42:20 +02:00
Michael Vorburger dd0c838439 improve ClasspathHellDuplicatesCheckRuleTest (req. by FINERACT-953)
to ignore all META-INF/groovy** such as
META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule which is
part of both groovy-xml-3.0.3.jar as well as e.g. ical4j-3.0.18.jar
2020-05-19 23:01:28 +02:00
Michael Vorburger 5557b8be4a fix moar flaky StorageTest.testNotificationStorage() [FINERACT-828]
similar fix to earlier Pull Request for the same

also added some more toString()
2020-05-17 21:29:20 +02:00
Michael Vorburger 7a98ad8d07 add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
This would catch problems such as the integration tests running "too
early" (before Flyway has fully initialized the database), which I have
a suspicion could be one of (many) causes of the unstable scheduler
tests, notably because of the IllegalArgumentException at
SchedulerJobsTest.java:90 in https://github.com/apache/fineract/pull/817
2020-05-17 10:56:59 +02:00
Michael Vorburger 904da67bbd Remove un-used "Send messages to Email gateway" Job (FINERACT-952) 2020-05-17 10:56:59 +02:00
Michael Vorburger cbc274f603 remove (useless) SenderTest + mockrunner-jms/nekohtml (FINERACT-938) 2020-05-17 10:53:42 +02:00
Michael Vorburger e0d4a1f376 make SchedulerJobsTest preserve scheduler and job states (FINERACT-922) 2020-05-17 02:25:51 +02:00
Michael Vorburger ⛑️andGitHub ddaffd13c0 Merge pull request #857 from xurror/FINERACT-897
[WIP] MySQL v8(FINERACT-897)
2020-05-17 02:13:49 +02:00
Michael Vorburger c764d32d5e fix Flyway table name problem (FINERACT-979) 2020-05-16 18:34:19 +02:00
thesmallstarandMichael Vorburger ⛑️ 20e8a02294 FINERACT-942 Remove bad logging pattern(Use of system.out) and added checkstyle 2020-05-16 18:13:43 +02:00
xurror 4360260ac6 FINERACT-897
make fineract compatible with both mysql5.5 and  mysql v8
2020-05-16 07:36:28 +01:00
Michael Vorburger 9ce72fe67b fix broken build
Combination of recently separately merged PRs #865 and #859 broke it.
2020-05-15 22:56:13 +02:00
Michael Vorburger ⛑️andGitHub 0eee0ff775 make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859)
This is just a first step - we should aim for -Xlint:all! ;)
2020-05-15 21:31:16 +01:00
Michael Vorburger ⛑️andGitHub 39675c9a23 rewrite MultiException to actually contain all causes (FINERACT-858) (#855) 2020-05-15 21:30:33 +01:00
Michael Vorburger 2aca64056a fix flaky StorageTest.testNotificationStorage() (FINERACT-828) 2020-05-15 20:12:37 +02:00
thesmallstarandMichael Vorburger ⛑️ 9eccd61333 Added Empty Statement Check and enforced checkstyle 2020-05-15 19:43:16 +02:00
Petri TuomolaandMichael Vorburger ⛑️ b58404be41 FINERACT-910: Serving apiDocs as part of the fineract-provider 2020-05-11 19:59:15 +02:00
xurrorandMichael Vorburger ⛑️ 2285797eff bump flyway from 2.1.1 to 6.4.1 2020-05-11 12:21:40 +02:00
Michael Vorburger 47549ae438 add toString() to Notification (to help debug FINERACT-828 next time) 2020-05-10 16:19:09 +02:00
Michael Vorburger 0cc18d7b8c fix obvious bug in Notification setActor()
This method doesn't seem to be used anywhere, so it never mattered.

Eclipse pointed out "The assignment to variable actorId has no effect".

We should not ignore javac/Eclipse compiler warnings! => FINERACT-959
2020-05-10 16:19:09 +02:00
Michael Vorburger 55af726cf9 improve SchedulerJobsTest.testDateFormat() by introducing Awaitility
This recently introduced new test (FINERACT-926) would locally pass, but
then fail on the next run, because another test in the same class would
modify job state to be inactive.  It now sets the first jobs state as it
requires it to be, and properly awaits the expected outcome.
2020-05-09 17:05:32 +02:00
Michael Vorburger e122f1ffd3 fix bug causing NullPointerException in SavingsAccount (FINERACT-957) 2020-05-09 13:31:39 +02:00
Michael Vorburger 27d754529e bulk replace org.apache.commons.lang with lang3 imports (FINERACT-954)
We apparently currently have both on the classpath, but really nowadays
should have, and can, only use lang3 with this minor clean up.
2020-05-09 05:48:31 +02:00
Michael Vorburger ff1c15d263 rm application.properties from Git, and .gitignore it (because we copy it during build) 2020-05-09 00:03:57 +02:00
Michael Vorburger f6c7bf970b ignore yet another :( RecurringDepositTest (FINERACT-855)
testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX
2020-05-09 00:03:50 +02:00
Michael Vorburger 4ade89d57d add integration test for (new) ISO-8601 Date Format (FINERACT-926)
using SchedulerJobsTest, just because that's convenient
2020-05-08 23:29:38 +02:00
Michael Vorburger 3ac7c29e51 clean up CommandHandlerProviderTest 2020-05-08 23:04:08 +02:00
Michael Vorburger ⛑️andGitHub bee3fb7ce5 add java.util.Date ISO-8601 GSON type adapter (FINERACT-926) (#816)
* minor clean-up in existing JsonSerializer implementations (FINERACT-926)

* centralize registration of GSON type adapters (FINERACT-926)

* add java.util.Date ISO-8601 GSON type adapter (FINERACT-926)
2020-05-08 19:56:19 +01:00
Michael Vorburger 6b1878a1d8 ignore one flaky FixedDepositTest (FINERACT-950)
testFixedDepositAccountClosureTypeWithdrawal_WITH_HOLD_TAX()
2020-05-08 20:30:25 +02:00
Michael Vorburger 077065c1b5 fix generic warnings in StaffTest (re. FINERACT-949) 2020-05-08 20:24:31 +02:00