CBSNexora/cbsnexora-backend
4
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
5,232 Commits 19 Branches 0 Tags
8418dd424f11c8e6ecd7d323852abab43053a56f
Commit Graph
706 Commits
Author SHA1 Message Date
Michael Vorburger 1baecf27f6 add @Ignore to another SchedulerJobsTestResults methods (FINERACT-857) 
testUpdateLoanPaidInAdvanceJobOutcome()
 2020-05-02 22:39:58 +02:00
Michael Vorburger 89fdc804f0 add @Ignore to more SchedulerJobsTestResults methods (FINERACT-857) 
testUpdateAccountingRunningBalancesJobOutcome()
testTransferFeeForLoansFromSavingsJobOutcome()
 2020-05-02 20:55:00 +02:00
rrpawar96andMichael Vorburger ⛑️ 9cd459273c add @ignore to SchedulerJobsTestResults.testInterestPostingForSavingsJobOutcome 2020-05-02 14:16:18 +02:00
Michael Vorburger 6e91a091f3 add @Ignore to another SchedulerJobsTestResults methods (FINERACT-857) 
testApplyDueFeeChargesForSavingsJobOutcome()
 2020-05-02 12:22:36 +02:00
Michael Vorburger ede38dc8fa add @Ignore to another ClientLoanIntegrationTest method (FINERACT-885) 
loanWithFlatCahargesAndPeriodicAccrualAccountingEnabled()
 2020-04-26 18:41:27 +02:00
Michael Vorburger 348d5bc855 add @Ignore to more ClientLoanIntegrationTest methods (FINERACT-885) 
loanWithCahargesOfTypeAmountPercentageAndPeriodicAccrualAccountingEnabled()
loanWithCahargesOfTypeAmountPlusInterestPercentageAndPeriodicAccrualAccountingEnabled()
 2020-04-26 16:55:56 +02:00
Michael Vorburger a1815c1b51 add @Ignore in AccountingScenarioIntegrationTest (FINERACT-899) 
checkPeriodicAccrualAccountingFlow()
 2020-04-26 16:55:56 +02:00
xurrorandMichael Vorburger ⛑️ 394a7fb1d1 IntegrationTests for git build info 2020-04-26 16:47:27 +02:00
xurrorandMichael Vorburger ⛑️ c317db110f FINERACT-883 
Display fineracts git build info actuator/info endpoint
 2020-04-26 16:47:27 +02:00
Michael Vorburger 4b724c2917 add @Ignore to flaky method in ClientLoanIntegrationTest (FINERACT-885) 
testLoanScheduleWithInterestRecalculation_WITH_REST_DAILY_INTEREST_COMPOUND_INTEREST_FEE_STRATEGY_WITH_OVERDUE_CHARGE()
 2020-04-26 12:51:27 +02:00
thesmallstarandMichael Vorburger ⛑️ c62328756b FINERACT-111 Do not update charges amount paid if loan transaction is accruals 2020-04-26 12:32:32 +02:00
Michael Vorburger ⛑️andGitHub fd9a1ba1be add @Ignore to flaky method in RecurringDepositTest (FINERACT-855) (#783) 
testRecurringDepositAccountWithPrematureClosureTypeReinvest()
 2020-04-26 11:12:13 +01:00
Josue AraujoandMichael Vorburger ⛑️ 78ca45ef27 * Added missing grouping keywords from https://github.com/apache/fineract/pull/757 2020-04-22 17:17:27 +02:00
Michael Vorburger 212cd679e9 Ignore :( flaky :( AccountingScenarioIntegrationTest (FINERACT-899) 
both checkPeriodicAccrualAccountingFlow_OVER_PAYMENT()
as well as checkPeriodicAccrualAccountingTillCurrentDateFlow()
but not the others
 2020-04-18 23:07:24 +02:00
percyashuandMichael Vorburger ⛑️ 83899c2fb0 FINERACT-826 Remove unused getTimeZone 2020-04-18 17:37:46 +02:00
thesmallstarandMichael Vorburger ⛑️ dd2e934cb1 Added One Statement per line and Enforced checkstyle 2020-04-18 03:23:54 +02:00
Michael Vorburger 64e02bc123 comment out broken MySQL JDBC driver logger (awaiting FINERACT-890) 2020-04-18 01:46:56 +02:00
Michael Vorburger ⛑️andGitHub c7b58b9869 escape all grouping in SQL files for MySQL 8 compatibility (#757) 
Indirectly related to FINERACT-762 - not sure if strictly required,
but seems like a good idea anyway at this opportunity, so why not.

As originally on https://github.com/apache/fineract/pull/638/files
 2020-04-17 22:40:42 +01:00
Michael Vorburger 059d1bebe7 comment out flaky testSavingsAccount_DormancyTracking (FINERACT-852) 2020-04-17 19:37:28 +02:00
Michael Vorburger a5b35b8d31 clean-up to remove apparently unused PORT ENV (related to FINERACT-762) 
This environment variable is actually never used.  The port of a Tenant
DB instead appears to be read from schemaServerPort of the
tenant_server_connections table.
 2020-04-17 19:09:24 +02:00
Michael Vorburger ⛑️andGitHub 9517051340 comment out flaky SchedulerJobsTest (FINERACT-852) (#764) 
Also adds a new assertion for a clearer failure message than the
confusing low-level technical ArrayIndexOutOfBoundsException for
whenever this test will be re-activated later.
 2020-04-15 10:36:46 +01:00
Michael Vorburger ⛑️andGitHub fd7fa63002 improve ClientSavingsIntegrationTest error reporting (FINERACT-852) (#765) 
Adds a new assertion for a hopefully clearer failure message than the
confusing low-level technical ArrayIndexOutOfBoundsException we
regularly hit on Travis CI.

Similar to https://github.com/apache/fineract/pull/764
 2020-04-15 09:34:33 +01:00
Yemdjih Kaze NasserGitHubpercyashu
 		26b619eea7 FINERACT-809 (#719) : Upgrade RestAssured version 
Upgrade RestAssured version

closes https://issues.apache.org/jira/browse/FINERACT-809

Co-authored-by: percyashu <percyayukashu@gmail.com>

Co-authored-by: percyashu <percyayukashu@gmail.com>
 2020-04-12 20:36:15 +01:00
thesmallstarandMichael Vorburger ⛑️ beee2e5330 Fixed: Checkstyle Violations 2020-04-07 23:46:20 +02:00
Michael Vorburger 09d0cfaa52 Remove AbstractPersistableCustom's PK parameterization 
Because both are pointless, as the PK @Id is hard-coded to Long anyway,
and the U is (rightfully) fixed to always be an AppUser here.
 2020-04-07 23:46:20 +02:00
Michael Vorburger dccea1d65e add @Transient to AbstractPersistableCustom isNew() 
see https://jira.spring.io/browse/DATAJPA-622

Even though we don't use Hibernate, copying this annotation from the
original class in Spring Data seems prudent - just in case.  It should
not cause any harm or side effects on OpenJPA.
 2020-04-07 23:46:20 +02:00
Michael Vorburger ae4117052b add missing doc to AbstractPersistableCustom & AbstractAuditableCustom 2020-04-07 23:46:20 +02:00
NatashaandMichael Vorburger ⛑️ d0c8c6a012 FINERACT-538 populated updated and created address 2020-04-07 23:15:25 +02:00
NatashaandMichael Vorburger ⛑️ eb8a3572ae FINERACT-122 added clientId, officeId, and groupId. 2020-04-07 23:11:48 +02:00
Michael Vorburger 53e8658d74 apply Hikari's recommended MySQL Configuration (FINERACT-796) 
from https://github.com/brettwooldridge/HikariCP/wiki/MySQL-Configuration
and https://github.com/brettwooldridge/HikariCP/wiki/JDBC-Logging#mysql-connectorj
 2020-03-28 17:58:39 +01:00
Michael Vorburger 5f2ba51f5a Minor clean ups in DataSource Connection Pool related code 2020-03-28 17:58:39 +01:00
Michael Vorburger 99794914a5 Fix wrong @OneToOne to @ManyToOne in AbstractAuditableCustom 2020-03-28 15:07:28 +01:00
xurrorandMichael Vorburger ⛑️ 3475c0cfb7 FINERACT-796 
Use Hikari instead of Tomcat Connection Pool
 - Created hikari connection pool bean
 - Configured connection parameters to match hikari
 - Removed tomcat-jdbc and dbcp
 - Remove unused classes
 - Add Hikari to logback
 - update hikaridatasource bean

closes https://issues.apache.org/jira/browse/FINERACT-796

remove hikaricp import from gradle files

more specific bean config

- Set up datasource properties
- Cleanup unused classes
- Add hikari to logback
 2020-03-28 15:06:34 +01:00
percyashuandMichael Vorburger ⛑️ 2e620b4de8 FINERACT-823 Gradle modernizer fixing violations 2020-03-23 00:54:00 +01:00
thesmallstarandMichael Vorburger ⛑️ 3f11dc51a9 Fix: Duplicate migration version 2020-03-15 11:05:30 +01:00
Michael Vorburger b1eb62f221 fix broken build due to small logging error detected by SpotBugs 
significant reformatting due to Eclipse auto-save action (someone really
needs to finish the Checkstyle uniform formatting)

see https://github.com/apache/fineract/pull/592
 2020-03-15 11:05:30 +01:00
Angel CajasandMichael Vorburger ⛑️ b9b265b915 Fineract-614 
Changes to comply with Checkstyle rules
 2020-03-13 17:15:25 +01:00
Angel CajasandMichael Vorburger ⛑️ 8df44af628 Fineract-614: 
Updating Global Configurations
Fixing some rebase conflicts
Change to imports on IntegrationTest for CheckStyle
 2020-03-13 17:15:25 +01:00
Angel CajasandMichael Vorburger ⛑️ 15a4a7695a Fineract-614: 
Updating Global Configurations
Fixing some rebase conflicts
 2020-03-13 17:15:25 +01:00
Angel CajasandMichael Vorburger ⛑️ 3a1a90d15e Fineract-614: Renaming SQL file for a higher version number 2020-03-13 17:15:25 +01:00
Angel CajasandMichael Vorburger ⛑️ e2f5c95034 Fixing some code to be compatible with Spring update 2020-03-13 17:15:25 +01:00
Angel CajasandMichael Vorburger ⛑️ c342f5b43d FINERACT-737: Updated Api Docs to include loan charges paid by 
FINERACT-736: Api Docs were updated to include rates documentation
FINERACT-735: Integration test were created for rates creation, retrieval and update

Missing permission READ_RATE
 2020-03-13 17:15:25 +01:00
Angel CajasandMichael Vorburger ⛑️ a7d4c83e92 A new rates module was added to define new rates that can be used to set min and max nominal interest rate, when a new loan account is created they can be used to determine which rates may be applicable for the loan account. 2020-03-13 17:15:25 +01:00
xurrorandMichael Vorburger ⛑️ f484f884a0 FINERACT-696 
add spotbug bug-pattern plugin.

Apply suggestions from code review

closes https://issues.apache.org/jira/browse/FINERACT-696

Co-Authored-By: Michael Vorburger ⛑️ <mike@vorburger.ch>
 2020-03-13 09:27:34 +01:00
thesmallstarandMichael Vorburger ⛑️ de329e2489 FINERACT-83 Made interestIncome variable null-safe 2020-03-12 12:57:18 +01:00
thesmallstarandMichael Vorburger ⛑️ 93d1716630 Added: SQL builder toString function 2020-03-12 12:54:46 +01:00
Michael Vorburger 1b1e80b6b1 Log errors from cron jobs individually and with cause (FINERACT-858) 
instead of current huge JobExecutionException message (without cause)
 2020-03-10 17:10:01 +01:00
Michael Vorburger ⛑️andGitHub 0c9273a11b throw exception with details in InteropServiceImpl (FINERACT-860) (#728) 
instead of the NoSuchElementException from Optional.get(), we're now
throwing an UnsupportedOperationException which includes the details of
the missing object.  (This kind of detailed exception was already thrown
in two existing places in the same code after a null check, but it never
reached there, because the Optional.get() failed earlier.  Another
option would have been to return null for an absent Optional, but this
is better.)

The other unrelated changes are automatic clean up actions (in Eclipse).
 2020-03-10 12:29:07 +01:00
thesmallstarandMichael Vorburger ⛑️ a34742b59a Made SQL builder ColumnName regex more general 2020-03-10 11:36:49 +01:00
Michael Vorburger 753554e281 Fix audit trails filter (FINERACT-808) 
As per the great analysis by Manthan Surkar (@thesmallstar) in the
original PR https://github.com/apache/fineract/pull/723, the cause of
the FINERACT-808 bug was that "the backend would treat "UPDATE" and
similar strings as SQL injection".

The root cause of that was that (IMHO..) how Fineract does SQL injection
is more of a workaround (blacklisting some keywords and some heuristic
checks) then how this really should be done (by using JDBC Prepared
statements with arguments for all external data, instead inlined SQL).

This also lays the foundation for more like this in FINERACT-854.
 2020-03-10 11:36:49 +01:00