Commit Graph
34 Commits
Author SHA1 Message Date
thesmallstarandMichael Vorburger ⛑️ dedd3be1dc FINERACT-821 Added and Enforced LeftCurly Checkstyle 2020-06-15 10:53:47 +02:00
thesmallstarandMichael Vorburger ⛑️ 7c689a81b9 FINERACT-821 Added SeparatorWrap(2) Checkstyle 2020-06-15 10:06:06 +02:00
thesmallstarandMichael Vorburger ⛑️ c97f0f9935 FINERACT-821 Added and Enforced OperatorWrap Checkstyle 2020-06-15 10:03:13 +02:00
thesmallstarandMichael Vorburger ⛑️ 31c69cff39 FINERACT-821 Added and Enforced GenericWhitespace Checkstyle 2020-06-15 09:53:07 +02:00
thesmallstarandYemdjih Kaze Nasser 8aab991194 FINERACT-821 Added and Enforced EmptyLineSeparator Checkstyle 2020-06-15 04:07:42 +01:00
thesmallstarandMichael Vorburger ⛑️ f6f1af9e95 FINERACT-821 Added and Enforced WhitespaceAround Checkstyle 2020-06-14 23:01:10 +02:00
Michael Vorburger 9da5932307 bulk auto reformat ca. 2900 files using ./gradlew :spotlessApply [FINERACT-1006] 2020-06-14 18:31:47 +02:00
Manthan SurkarandMichael Vorburger ⛑️ bc7d75d7b2 FINERACT-942 Added and Enforced EmptyCatchBlock checkstyle 2020-06-14 13:37:08 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 885a501c64 INERACT-821 Added and Enforced EmptyBlock Checkstyle 2020-06-11 23:50:04 +02:00
thesmallstarandMichael Vorburger ⛑️ 99c667ab1a FINERACT-821 Added and Enforced AnnotationLocation(1) Checkstyle 2020-06-11 23:38:15 +02:00
thesmallstarandMichael Vorburger ⛑️ 960ae3f855 Removed already added MethodName checkstyle from comments 2020-06-11 21:52:33 +02:00
thesmallstarandMichael Vorburger ⛑️ f88c244053 FINERACT-821 Added and Enforced AnnotationLocation(2) Checkstyle 2020-06-11 21:50:49 +02:00
thesmallstarandMichael Vorburger ⛑️ a582ec63ee FINERACT-942 Added and Enforced IllegalThrows checkstyle 2020-06-11 21:36:42 +02:00
thesmallstarandMichael Vorburger ⛑️ 708dddd5f7 FINERACT-821 Added ForbidCertainImportsCheck
checkstyle
2020-06-11 21:35:45 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 417c9e297e FINERACT-821 Added FallThrough Checkstyle 2020-06-08 22:40:56 +02:00
Manthan SurkarandMichael Vorburger ⛑️ b0ff8dbb60 FINERACT-821 Added and Enforced MethodName Checkstyle 2020-06-07 02:05:40 +02:00
thesmallstarandYemdjih Kaze Nasser cc6bf4b4b0 FINERACT-821 Added MethodTypeParameterName checkstyle 2020-06-04 02:08:09 +01:00
thesmallstarandMichael Vorburger ⛑️ 140435bca4 FINERACT-821 Added OneTopLevelClass checkstyle 2020-06-02 22:49:02 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 3545cbef4c Remove already added checkstyle from comments 2020-05-31 18:53:33 +02:00
thesmallstarandMichael Vorburger ⛑️ 7b09c1a4b0 FINERACT-821 Added IllegalTokenText Checkstyle 2020-05-29 08:37:43 +02:00
Manthan SurkarandYemdjih Kaze Nasser 896571d479 FINERACT-821 Added NoLineWrap Checkstyle 2020-05-28 16:50:13 +01:00
Manthan SurkarandMichael Vorburger ⛑️ ef538e5c75 FINERACT-821 Added and Enforced ArrayTypeStyle checkstyle 2020-05-27 11:27:32 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 3e95c32e18 FINERACT-821 Added and enforced NeedBraces Checkstyle 2020-05-27 00:13:22 +02:00
Manthan SurkarandMichael Vorburger ⛑️ 01e8014ea2 FINERACT-821 Added and Enforced upperEll checkstyle 2020-05-26 09:30:59 +02:00
thesmallstarandMichael Vorburger ⛑️ 718ff205e5 FINERACT-821 Added AvoidEscapedUnicodeCharacters checkstyle 2020-05-25 09:27:16 +02:00
thesmallstarandMichael Vorburger ⛑️ baa1177854 FINERACT-821 Added and Enforced Typename checkstyle 2020-05-22 15:23:23 +02:00
thesmallstarandMichael Vorburger ⛑️ 014c6bba40 FINERACT-821 Added PackageName checkstyle 2020-05-22 09:31:14 +02:00
thesmallstarandMichael Vorburger ⛑️ 16fb971f45 FINERACT-942 Remove use of printStackTrace and added checkstyle 2020-05-21 21:48:11 +02:00
thesmallstarandMichael Vorburger ⛑️ 20e8a02294 FINERACT-942 Remove bad logging pattern(Use of system.out) and added checkstyle 2020-05-16 18:13:43 +02:00
thesmallstarandMichael Vorburger ⛑️ 9eccd61333 Added Empty Statement Check and enforced checkstyle 2020-05-15 19:43:16 +02:00
thesmallstarandMichael Vorburger ⛑️ dd2e934cb1 Added One Statement per line and Enforced checkstyle 2020-04-18 03:23:54 +02:00
Michael Vorburger ⛑️andAwasum Yannick 28db242884 Activate and Enforce new Checkstyle check related to import statement order (FINERACT-821) (#704)
* Minor manually done fix up of fineractdev-eclipse-preferences.epf file

This in theory should not change anything about the conventions,
it's just a first manual clean up of this very old file here.

The few extra new lines are what I found when exporting Preferences.

Related to https://issues.apache.org/jira/browse/FINERACT-821

* fineractdev-eclipse-preferences.epf imported and re-exported in Eclipse.

This in theory should not change anything about the conventions, as
presumably Eclipse during an Import and re-Export of an EPF just adds
new settings, and perhaps removes old settings.  I've not actually made
any manual changes in Preferences in this step.

Related to https://issues.apache.org/jira/browse/FINERACT-821

* fineractdev-eclipse-preferences.epf "import" in line with Checkstyle

The non-import related Code Formatter settings may need further tuning;
this will be done in future changes; the focus in this round is on
import.

Related to https://issues.apache.org/jira/browse/FINERACT-821

* Use Eclipse's Source > Organize Import to re-order all import statements

This uses the fineractdev-eclipse-preferences.epf from the previous
commit, which just so happens ;) to exactly match the expected import
rules which the next commit is going to enforce using Checkstyle.

This is of course not specific to only Eclipse per se; other IDEs can
be similarly configured to match these coding conventions; I just happen
to have used Eclipse.

Related to https://issues.apache.org/jira/browse/FINERACT-821

* Activate and Enforce all Checkstyle import related new checks

and update the README to explain Checkstyle, and the availability of the
Eclipse Preferences configuration file which matches the import
code format conventions which are now enforced.

Contributions for a similar preferences file for other IDEs welcome! ;)

Related to https://issues.apache.org/jira/browse/FINERACT-821
2020-01-28 00:28:11 +01:00
Michael Vorburger ⛑️andAwasum Yannick 3a17da44df Activate and Enforce Checkstyle EqualsHashCode check. (#703)
Thanks to prior work for SpotBugs, this passes without requiring any
code adjustments.  (Fineract had a nubmer of problems in this space
before the SpotBugs work.)

Enabling this helps to ensure non-regression so that no new equals() and
hashCode() related bugs creep in.  (This does overlap a little bit with
SpotBugs, but the build time overhead to run the extra check is
completely negligible, so it seems worth having this.  If only just in
case SpotBugs for whatever reason in the future would get deactivated
again.)
2020-01-27 22:02:41 +01:00
Michael Vorburger fbccc57fb9 enforce initial set of Checkstyle rules (FINERACT-821)
This is, intentionally, for whitespace related rules, only.

The idea is to now gradually extend it.
2020-01-19 19:59:38 +01:00