Commit Graph
759 Commits
Author SHA1 Message Date
Petri TuomolaandMichael Vorburger ⛑️ acfec8bb94 FINERACT-723: Fixing date comparisons that resulting in a problem when timezone is different on database and application server 2020-05-21 11:50:30 +02:00
xurrorandMichael Vorburger ⛑️ 3bc7914068 Update spotbugs to v4.2.0(FINERACT-986) 2020-05-21 10:52:42 +02:00
Yemdjih Kaze NasserandGitHub 44376ca1fe Merge pull request #911 from vorburger/FINERACT-953_groovy
improve ClasspathHellDuplicatesCheckRuleTest (req. by FINERACT-953)
2020-05-20 01:21:45 +01:00
xurrorandMichael Vorburger ⛑️ dc3af0c867 FINERACT-964
bump json-path from 0.9.1 to 2.4.0
2020-05-20 00:56:20 +02:00
percyashuandMichael Vorburger ⛑️ 610375753c FINERACT-959 make javac fail for Xlint:cast 2020-05-20 00:42:20 +02:00
Michael Vorburger dd0c838439 improve ClasspathHellDuplicatesCheckRuleTest (req. by FINERACT-953)
to ignore all META-INF/groovy** such as
META-INF/groovy/org.codehaus.groovy.runtime.ExtensionModule which is
part of both groovy-xml-3.0.3.jar as well as e.g. ical4j-3.0.18.jar
2020-05-19 23:01:28 +02:00
Michael Vorburger 5557b8be4a fix moar flaky StorageTest.testNotificationStorage() [FINERACT-828]
similar fix to earlier Pull Request for the same

also added some more toString()
2020-05-17 21:29:20 +02:00
Michael Vorburger 7a98ad8d07 add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
This would catch problems such as the integration tests running "too
early" (before Flyway has fully initialized the database), which I have
a suspicion could be one of (many) causes of the unstable scheduler
tests, notably because of the IllegalArgumentException at
SchedulerJobsTest.java:90 in https://github.com/apache/fineract/pull/817
2020-05-17 10:56:59 +02:00
Michael Vorburger 904da67bbd Remove un-used "Send messages to Email gateway" Job (FINERACT-952) 2020-05-17 10:56:59 +02:00
Michael Vorburger cbc274f603 remove (useless) SenderTest + mockrunner-jms/nekohtml (FINERACT-938) 2020-05-17 10:53:42 +02:00
Michael Vorburger e0d4a1f376 make SchedulerJobsTest preserve scheduler and job states (FINERACT-922) 2020-05-17 02:25:51 +02:00
Michael Vorburger ⛑️andGitHub ddaffd13c0 Merge pull request #857 from xurror/FINERACT-897
[WIP] MySQL v8(FINERACT-897)
2020-05-17 02:13:49 +02:00
Michael Vorburger c764d32d5e fix Flyway table name problem (FINERACT-979) 2020-05-16 18:34:19 +02:00
thesmallstarandMichael Vorburger ⛑️ 20e8a02294 FINERACT-942 Remove bad logging pattern(Use of system.out) and added checkstyle 2020-05-16 18:13:43 +02:00
xurror 4360260ac6 FINERACT-897
make fineract compatible with both mysql5.5 and  mysql v8
2020-05-16 07:36:28 +01:00
Michael Vorburger 9ce72fe67b fix broken build
Combination of recently separately merged PRs #865 and #859 broke it.
2020-05-15 22:56:13 +02:00
Michael Vorburger ⛑️andGitHub 0eee0ff775 make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859)
This is just a first step - we should aim for -Xlint:all! ;)
2020-05-15 21:31:16 +01:00
Michael Vorburger ⛑️andGitHub 39675c9a23 rewrite MultiException to actually contain all causes (FINERACT-858) (#855) 2020-05-15 21:30:33 +01:00
Michael Vorburger 2aca64056a fix flaky StorageTest.testNotificationStorage() (FINERACT-828) 2020-05-15 20:12:37 +02:00
thesmallstarandMichael Vorburger ⛑️ 9eccd61333 Added Empty Statement Check and enforced checkstyle 2020-05-15 19:43:16 +02:00
Petri TuomolaandMichael Vorburger ⛑️ b58404be41 FINERACT-910: Serving apiDocs as part of the fineract-provider 2020-05-11 19:59:15 +02:00
xurrorandMichael Vorburger ⛑️ 2285797eff bump flyway from 2.1.1 to 6.4.1 2020-05-11 12:21:40 +02:00
Michael Vorburger 47549ae438 add toString() to Notification (to help debug FINERACT-828 next time) 2020-05-10 16:19:09 +02:00
Michael Vorburger 0cc18d7b8c fix obvious bug in Notification setActor()
This method doesn't seem to be used anywhere, so it never mattered.

Eclipse pointed out "The assignment to variable actorId has no effect".

We should not ignore javac/Eclipse compiler warnings! => FINERACT-959
2020-05-10 16:19:09 +02:00
Michael Vorburger 55af726cf9 improve SchedulerJobsTest.testDateFormat() by introducing Awaitility
This recently introduced new test (FINERACT-926) would locally pass, but
then fail on the next run, because another test in the same class would
modify job state to be inactive.  It now sets the first jobs state as it
requires it to be, and properly awaits the expected outcome.
2020-05-09 17:05:32 +02:00
Michael Vorburger e122f1ffd3 fix bug causing NullPointerException in SavingsAccount (FINERACT-957) 2020-05-09 13:31:39 +02:00
Michael Vorburger 27d754529e bulk replace org.apache.commons.lang with lang3 imports (FINERACT-954)
We apparently currently have both on the classpath, but really nowadays
should have, and can, only use lang3 with this minor clean up.
2020-05-09 05:48:31 +02:00
Michael Vorburger ff1c15d263 rm application.properties from Git, and .gitignore it (because we copy it during build) 2020-05-09 00:03:57 +02:00
Michael Vorburger f6c7bf970b ignore yet another :( RecurringDepositTest (FINERACT-855)
testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX
2020-05-09 00:03:50 +02:00
Michael Vorburger 4ade89d57d add integration test for (new) ISO-8601 Date Format (FINERACT-926)
using SchedulerJobsTest, just because that's convenient
2020-05-08 23:29:38 +02:00
Michael Vorburger 3ac7c29e51 clean up CommandHandlerProviderTest 2020-05-08 23:04:08 +02:00
Michael Vorburger ⛑️andGitHub bee3fb7ce5 add java.util.Date ISO-8601 GSON type adapter (FINERACT-926) (#816)
* minor clean-up in existing JsonSerializer implementations (FINERACT-926)

* centralize registration of GSON type adapters (FINERACT-926)

* add java.util.Date ISO-8601 GSON type adapter (FINERACT-926)
2020-05-08 19:56:19 +01:00
Michael Vorburger 6b1878a1d8 ignore one flaky FixedDepositTest (FINERACT-950)
testFixedDepositAccountClosureTypeWithdrawal_WITH_HOLD_TAX()
2020-05-08 20:30:25 +02:00
Michael Vorburger 077065c1b5 fix generic warnings in StaffTest (re. FINERACT-949) 2020-05-08 20:24:31 +02:00
Michael Vorburger ⛑️andGitHub d2a0493be4 add server.forward-headers-strategy=framework (FINERACT-914) (#798) 2020-05-08 18:47:53 +01:00
Michael Vorburger ⛑️andGitHub e2d076f15e ignore another flaky test in SchedulerJobsTestResults (FINERACT-857) (#839)
testUpdateLoanArrearsAgingJobOutcome()
2020-05-08 18:18:26 +01:00
Michael Vorburger ea85f9c739 clean up XBRLBuilderTest (re. FINERACT-940) 2020-05-08 17:04:43 +02:00
Petri TuomolaandMichael Vorburger ⛑️ 0e4aeef1af FINERACT-846: Migrating to Java 11, upgrading dependencies, fixing compiler warnings 2020-05-07 22:28:19 +02:00
Sidney WasibaniandGitHub a855d3a9cc re-use styles so that Excel's 4k row limit isn't exceeded (FINERACT-930) 2020-05-05 22:30:25 +02:00
Petri TuomolaandMichael Vorburger ⛑️ b05162f60b FINERACT-730: Fixed dependencies, SSL config and main class etc to get bootRun to work. Migrated from Gradle Tomcat plugin to Cargo plugin to fix integration test 2020-05-05 22:04:04 +02:00
Michael Vorburger cb690f6d5b ignore three more flaky tests in SchedulerJobsTestResults (FINERACT-857)
testInterestTransferForSavings()
testExecuteStandingInstructionsJobOutcome()
testAvoidUnncessaryPenaltyWhenAmountZeroForOverdueLoansJobOutcome()
2020-05-05 20:13:11 +02:00
rrpawar96andMichael Vorburger ⛑️ 489faf96b0 GLIM_GSIM enhancement (FINERACT-603) 2020-05-05 12:43:40 +02:00
Michael Vorburger ⛑️andGitHub d33e0ba72a add new /echo debug API endpoint (FINERACT-915) (#797) 2020-05-03 22:34:37 +01:00
Michael Vorburger c4797ab96b more clean up in SchedulerJobsTest (re. FINERACT-922)
This does NOT, yet, fix FINERACT-922, but it splits the old test into
new smaller test methods, which (hopefully) should always pass, except
for the last one.
2020-05-03 20:22:54 +02:00
Michael Vorburger 83cdb17d8f exclude dependencies causing classpath duplicates (FINERACT-919) 2020-05-03 19:52:12 +02:00
Michael Vorburger.ch b0367099bc add classpath duplicates detection test (FINERACT-919) 2020-05-03 19:52:12 +02:00
Michael Vorburger 2212675af4 second step to clean up in SchedulerJobsTest (re. FINERACT-922)
do more un-static-ify SchedulerJobHelper

This does NOT, yet, fix FINERACT-922.
2020-05-03 19:49:27 +02:00
Michael Vorburger 85bf8dc3e9 first step to clean up in SchedulerJobsTest (preparing for FINERACT-922)
make two methods in SchedulerJobHelper private

and start to un-static-ify SchedulerJobHelper

This does NOT, yet, fix FINERACT-922.
2020-05-03 19:49:27 +02:00
Saransh SharmaandMichael Vorburger ⛑️ 90dec19201 FINERACT-925 2020-05-03 18:41:10 +02:00
Saransh SharmaandMichael Vorburger ⛑️ cb0624c073 FINERACT-924 2020-05-03 18:41:10 +02:00