Commit Graph
80 Commits
Author SHA1 Message Date
Michael Vorburger edfcb931e9 Gradle testLogging exceptionFormat "full" (FINERACT-927)
as well as integrationTest --fail-fast
2020-05-05 10:52:02 +02:00
Michael Vorburger b6c6d50501 fix moar 3rd-party versions in build.gradle (see FINERACT-805) 2020-05-04 03:00:31 +02:00
Michael Vorburger 404f055b65 remove old spring-jms:4.0.7 & fix JMS dependencies (FINERACT-805) 2020-05-03 19:52:12 +02:00
Michael Vorburger 83cdb17d8f exclude dependencies causing classpath duplicates (FINERACT-919) 2020-05-03 19:52:12 +02:00
Michael Vorburger c9f2591766 Upgrade Jersey library from 1.17 to 1.19.4 (FINERACT-920) 2020-05-03 03:12:15 +02:00
Michael Vorburger 8418dd424f upgrade OpenJPA from 3.1.0 to 3.1.1 (FINERACT-908) 2020-05-02 22:42:10 +02:00
xurrorandMichael Vorburger ⛑️ 394a7fb1d1 IntegrationTests for git build info 2020-04-26 16:47:27 +02:00
xurrorandMichael Vorburger ⛑️ 0a80195ac2 Fix rat reports 2020-04-26 16:47:27 +02:00
xurrorandMichael Vorburger ⛑️ c317db110f FINERACT-883
Display fineracts git build info actuator/info endpoint
2020-04-26 16:47:27 +02:00
26b619eea7 FINERACT-809 (#719) : Upgrade RestAssured version
Upgrade RestAssured version

closes https://issues.apache.org/jira/browse/FINERACT-809

Co-authored-by: percyashu <percyayukashu@gmail.com>

Co-authored-by: percyashu <percyayukashu@gmail.com>
2020-04-12 20:36:15 +01:00
Manthan SurkarandGitHub 402c41dd95 Add Jacoco to measure code coverage (FINERACT-725 / PR #742)
* Added Code Coverage Section in Readme
2020-04-01 23:29:15 +02:00
xurrorandMichael Vorburger ⛑️ 3475c0cfb7 FINERACT-796
Use Hikari instead of Tomcat Connection Pool
 - Created hikari connection pool bean
 - Configured connection parameters to match hikari
 - Removed tomcat-jdbc and dbcp
 - Remove unused classes
 - Add Hikari to logback
 - update hikaridatasource bean

closes https://issues.apache.org/jira/browse/FINERACT-796

remove hikaricp import from gradle files

more specific bean config

- Set up datasource properties
- Cleanup unused classes
- Add hikari to logback
2020-03-28 15:06:34 +01:00
percyashuandMichael Vorburger ⛑️ 2e620b4de8 FINERACT-823 Gradle modernizer fixing violations 2020-03-23 00:54:00 +01:00
xurrorandMichael Vorburger ⛑️ f484f884a0 FINERACT-696
add spotbug bug-pattern plugin.

Apply suggestions from code review

closes https://issues.apache.org/jira/browse/FINERACT-696

Co-Authored-By: Michael Vorburger ⛑️ <mike@vorburger.ch>
2020-03-13 09:27:34 +01:00
xurrorandMichael Vorburger ⛑️ a7ebef4781 FINERACT-807
change mifosplatform-tenants and mifostenant-default to fineract_tenants
 and fineract_default respectively

closes https://issues.apache.org/jira/projects/FINERACT/issues/FINERACT-807?filter=allopenissues
2020-03-08 14:16:05 +01:00
Michael Vorburger ⛑️andAwasum Yannick 14175a1854 Minor: Remove comment in build.gradle re. springDataJpaVersion (#702)
This has been removed in a20f76d686,
and it's confusing to look for what that means, e.g. while code
reviewing proposed "bump" changes to the used versions of
spring.gradle:dependency-management-plugin and
springframework.boot:spring-boot-gradle-plugin.
2020-01-27 22:00:28 +01:00
Awasum YannickandMichael Vorburger ⛑️ 66ae79bbe7 Upgrade Spring Boot from 2.1.7 to 2.2.4 2020-01-27 21:05:29 +01:00
Michael Vorburger fbccc57fb9 enforce initial set of Checkstyle rules (FINERACT-821)
This is, intentionally, for whitespace related rules, only.

The idea is to now gradually extend it.
2020-01-19 19:59:38 +01:00
Michael Vorburger 125924303b Temporarily remove the build realted Swagger changes (FINERACT-733)
as well as implement all review feedback provided on the original PR

see https://github.com/apache/fineract/pull/629 for background

also https://jira.apache.org/jira/browse/FINERACT-733
2020-01-19 15:24:11 +01:00
Kang BrederandMichael Vorburger ⛑️ e424471162 Initial Swagger related changes from GSOC 2019 contrib (FINERACT-733)
This commit does not yet provide the full Swagger requirement, as was
outlined in FINERACT-733, but it's a first step forming the basis of
more to come (hopefully).  Here's the original PR description (but
note that some of this is about to be reverted in the next commit):


Reflected all API descriptions on swagger UI.

Formatted API descriptions.

Added swagger docs for new APIs.

Added swagger-gradle-plugin for automatic save of json during build.

Leveraged swagger codegen for generation of language-specific libraries
using gradle-swagger-generator plugin.
2020-01-19 15:24:11 +01:00
Awasum YannickandGitHub fc786fa3f6 Merge pull request #684 from vorburger/spotbugs-extra
more SpotBugs related / inspired code clean up (see FINERACT-702)
2020-01-14 08:37:20 +01:00
Michael Vorburger 0379ba7628 fix build.gradle for RAT to ignore .github/workflows/ 2020-01-13 09:53:24 +01:00
Michael Vorburger 6ca1a678cb more SpotBugs related / inspired code clean up (see FINERACT-702)
based upon code review of changes made by @awasum in previous commit:

 - fix clear contains() GC_UNRELATED_TYPES bug in Loan

 - fix clear equals() EC_UNRELATED_TYPES bug in Loan

 - fix more equals() & hashCode() in...
    * Charge
    * TrialBalance
    * LoanProductBorrowerCycleVariations
    * LoanProductProvisioningEntry

 - fix AccountingConstants to avoid using @FindBugsSuppressWarnings

 - fix SelfLoansDataValidator instead of @FindBugsSuppressWarnings

 - minor clean up in build.gradle (spotbugs has replaced findbugs)

PS: This change originally included also fixing the missing hashCode()
    and equals() in ShareAccountCharge, but that turned out to be non
    trivial, see FINERACT-827, and is thus not yet fixed by this.
2020-01-13 08:41:16 +01:00
Awasum YannickandMichael Vorburger ⛑️ af0dd7e5f3 use SpotBugs & fix over 300 high priority rule violations (FINERACT-702)
This PR also serves as a base solution for upcoming FINERACT-712 and
FINERACT-696.  It includes using Objects.equals() to prevent NPEs, and
adding gradle check to run SpotBugs on Travis CI.

PS: SpotBugs is the successor to (and same code as) FindBugs.
2020-01-12 13:16:42 +01:00
Percy Ayuk AshuandMichael Vorburger ⛑️ 26b4e0000c use dependency's versions from Spring BOM (PR #668 for FINERACT-805) 2019-12-10 06:38:41 +01:00
Yemdjih Kaze NasserandMichael Vorburger ⛑️ a20f76d686 Use Spring Boot BOM to avoid maintaining version numbers in dependencies.gradle (#662 for FINERACT-797) 2019-12-02 07:44:35 -08:00
Percy Ayuk AshuandMichael Vorburger ⛑️ 451f4a6338 FINERACT-777 Use api / implementation scoped Gradle dependencies (#661)
see https://issues.apache.org/jira/browse/FINERACT-777
2019-12-01 17:08:31 -08:00
Michael Vorburger ⛑️ f255a597f8 add .theia/settings.json to avoid confusing prompt on http://gitpod.io
and exclude JSON files from RAT (because they cannot contain license header comments)
2019-11-25 07:44:37 +01:00
ibondarenko 43fd8618ad implementation of FINERACT-724 (Upgrade Spring Boot, Spring and Spring Security to their latest stable version) 2019-11-12 10:36:27 +02:00
Michael Vorburger.ch bcef09d7be upgrade OpenJPA 2.4.1 to 2.4.3
because 2.4.1 was not yet Java 11 compatible (due to an old ASM)

I'd like to upgrade to Java 11 soon-ish, and am starting to experiment with it.
2019-07-11 08:41:36 +02:00
Michael Vorburger.ch 2fc98df21c fix ClassCircularityError: java/util/logging/LogRecord (see FINERACT-700 for details) 2019-07-10 23:47:51 +02:00
Michael Vorburger ⛑️andGitHub 9f0147d7d0 Merge branch 'develop' into bump-gradle-wrapper 2019-07-10 18:45:21 +02:00
Michael Vorburger.ch e2b2e66610 fix integrationTest (=> runWar) which broke in Gradle upgrade
inspired by (but not exactly like) the respective section on
https://github.com/bmuschko/gradle-tomcat-plugin#faq
2019-07-09 22:09:11 +02:00
Michael Vorburger.ch 9a4cb83bd5 upgrade gradle-tomcat-plugin from 1.0 to 2.5 (NOK) 2019-07-09 18:18:13 +02:00
Michael Vorburger.ch b54a11da9b fix gradle createDB/dropDB/setBlankPassword
which broke during the Gradle upgrade in FINERACT-700

do not fix Flyway related migrateTenantDB & Co, as those
are proposed to be removed in FINERACT-765 anyway.  (If really
needed, some of my other WIP branches have the required changes
to make the Flyway related tasks work.)
2019-07-09 10:04:03 +02:00
Michael Vorburger fd74931390 upgrade (switch) OpenJPA Gradle plugin (FINERACT-700)
from at.schmutterer.oss.gradle:gradle-openjpa
to com.radcortez.gradle:openjpa-gradle-plugin

due to https://github.com/schmutterer/gradle-openjpa/issues/8
2019-07-09 10:04:03 +02:00
Michael Vorburger 1ee141bb87 upgrade spring-boot-gradle-plugin, and deal with impacts (FINERACT-700)
because the old one previously used caused an UnsupportedOperationException
with the new Gradle, see https://issues.apache.org/jira/browse/FINERACT-700

The spring-jms and activemq-broker versions are set to what they were on before.
2019-07-09 10:02:13 +02:00
Michael Vorburger 84d57dbe5b upgrade Gradle version, and deal with impacts (FINERACT-700)
https://discuss.gradle.org/t/could-not-get-unknown-property-classesdir-for-main-classes-of-type-org-gradle-api-internal-tasks-defaultsourcesetoutput/30570

https://discuss.gradle.org/t/gradle-4-replacing-deprecated-test-testclassesdir/22822/2

https://discuss.gradle.org/t/could-not-find-method-leftshift-for-arguments-on-task-of-type-org-gradle-api-defaulttask/30614
2019-07-09 09:52:37 +02:00
Michael Vorburger.ch a87b3a0a4d use openjpa (with real dependencies) instead of shaded openjpa-all 2019-07-09 09:48:18 +02:00
Vishwas Babu A JandGitHub 624015acaa Merge pull request #613 from vorburger/FINERACT-765_rm-flyway-from-gradle
remove Flyway completely from Gradle build (fixes FINERACT-765)
2019-07-08 09:27:30 +05:30
Awasum YannickandGitHub 41f683cfb1 Merge pull request #612 from vorburger/deactivate-FindBugs-PMD
comment out PMD & FindBugs
2019-07-07 22:43:15 +01:00
Awasum YannickandGitHub 998d8b7fbc Merge pull request #602 from vorburger/re-activate-tests
re-activate unit tests (see FINERACT-776)
2019-07-07 22:41:06 +01:00
Awasum YannickandGitHub 18517f53d7 Merge pull request #616 from vorburger/upgrade-drizzle
upgrade Drizzle JDBC from 1.3 to 1.4
2019-07-05 16:57:40 +01:00
Michael Vorburger.ch dd4923888b upgrade Drizzle JDBC from 1.3 to 1.4 2019-07-04 10:43:05 +02:00
Michael Vorburger.ch 0c2b1dc6dc remove Flyway completely from Gradle build (fixes FINERACT-765)
we (of course), still, but only, run it in-App at runtime boot

This is a clean-up which removes something we don't actually need.

Most importantly, it unblocks the Gradle upgrade in FINERACT-700,
where this doesn't work anymore anyway (and while there's a fix
making it work on one of my branches, it seems simpler to just
remove it).
2019-07-04 10:39:55 +02:00
Michael Vorburger.ch e960d40906 comment out PMD & FindBugs
Too slow, and nobody looked at it in years anyway.
The idea is to later re-activate, with enforcement.

see also https://issues.apache.org/jira/browse/FINERACT-712
2019-07-04 09:32:48 +02:00
Michael Vorburger.ch e97b12a3f9 make OpenJPA version, used twice, a variable, instead of repeating it 2019-07-03 23:40:17 +02:00
Michael Vorburger.ch c296c314b3 move versions in build.gradle
so that the buildscript block can already use them
2019-07-03 23:40:17 +02:00
Michael Vorburger.ch 7030f1fa4c re-activate unit tests (see FINERACT-776) 2019-07-03 23:23:12 +02:00
Steve ConradandGitHub ea29fac9f5 Merge pull request #565 from marta-jankovics/mojaloop-fineract_1.0.1
FINERACT-706: Interoperation Mojaloop integration 1.0.1
2019-06-30 14:28:37 -05:00