Commit Graph
106 Commits
Author SHA1 Message Date
Michael Vorburger ⛑️andGitHub e8276f0aea Remove direct explicit Guava dependency (FINERACT-963) (#913)
We *ARE* using Guava, but, unless we have a real need for a more recent
specific version, it seems "safer" (and less hassle to maintain bumping)
just using whatever version we transitively inherit from other libraries
we use that themselves depend on Guava (currently Swagger, Mustache and
activemq-broker).

Currently that "whatever version" is a 28.2 (we used 28.1 before).

This removes two fairly different kinds of Guava dependencies we have:
One for run-time (above), and one for build time which seems to have
been added due to some SpotBugs related issue (but it now works without
that, so that must have been some issue in SpotBugs that meanwhile go
fixed in the recent versions).
2020-05-20 10:00:29 +01:00
xurrorandMichael Vorburger ⛑️ dc3af0c867 FINERACT-964
bump json-path from 0.9.1 to 2.4.0
2020-05-20 00:56:20 +02:00
percyashuandMichael Vorburger ⛑️ 610375753c FINERACT-959 make javac fail for Xlint:cast 2020-05-20 00:42:20 +02:00
Michael Vorburger cbc274f603 remove (useless) SenderTest + mockrunner-jms/nekohtml (FINERACT-938) 2020-05-17 10:53:42 +02:00
Michael Vorburger ⛑️andGitHub 0eee0ff775 make javac fail, not just warn, for (Xlint) unchecked (FINERACT-959) (#859)
This is just a first step - we should aim for -Xlint:all! ;)
2020-05-15 21:31:16 +01:00
Petri TuomolaandMichael Vorburger ⛑️ 439ba93ebd FINERACT-972: Ensure Tomcat is started after the integration tests have been compiled 2020-05-15 19:54:21 +02:00
Petri TuomolaandMichael Vorburger ⛑️ b58404be41 FINERACT-910: Serving apiDocs as part of the fineract-provider 2020-05-11 19:59:15 +02:00
xurrorandMichael Vorburger ⛑️ 2285797eff bump flyway from 2.1.1 to 6.4.1 2020-05-11 12:21:40 +02:00
Michael Vorburger 3226b63383 remove broken dev-dependencies.gradle (until FINERACT-939) 2020-05-10 21:48:05 +02:00
dependabot-preview[bot]andMichael Vorburger ⛑️ 00b3687f95 Bump checkstyle from 8.28 to 8.32 in /fineract-provider
Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 8.28 to 8.32.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](https://github.com/checkstyle/checkstyle/compare/checkstyle-8.28...checkstyle-8.32)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 14:55:17 +02:00
Michael Vorburger b525925b57 bump org.apache.bval.bundle from 2.0.2 to 2.0.3
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 14:54:19 +02:00
dependabot-preview[bot]andMichael Vorburger ⛑️ e3d3b5551b Bump gradle-jrebel-plugin from 1.1.2 to 1.1.10 in /fineract-provider
Bumps [gradle-jrebel-plugin](https://github.com/zeroturnaround/gradle-jrebel-plugin) from 1.1.2 to 1.1.10.
- [Release notes](https://github.com/zeroturnaround/gradle-jrebel-plugin/releases)
- [Changelog](https://github.com/zeroturnaround/gradle-jrebel-plugin/blob/master/changelog.txt)
- [Commits](https://github.com/zeroturnaround/gradle-jrebel-plugin/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 14:52:15 +02:00
dependabot-preview[bot]andMichael Vorburger ⛑️ e63007c363 Bump classgraph from 4.8.43 to 4.8.78 in /fineract-provider
Bumps [classgraph](https://github.com/classgraph/classgraph) from 4.8.43 to 4.8.78.
- [Release notes](https://github.com/classgraph/classgraph/releases)
- [Commits](https://github.com/classgraph/classgraph/compare/classgraph-4.8.43...classgraph-4.8.78)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 14:50:25 +02:00
dependabot-preview[bot]andMichael Vorburger ⛑️ bb7df3c9e8 Bump retrofit from 1.6.1 to 1.9.0 in /fineract-provider
Bumps [retrofit](https://github.com/square/retrofit) from 1.6.1 to 1.9.0.
- [Release notes](https://github.com/square/retrofit/releases)
- [Changelog](https://github.com/square/retrofit/blob/master/CHANGELOG.md)
- [Commits](https://github.com/square/retrofit/compare/parent-1.6.1...parent-1.9.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 14:48:37 +02:00
dependabot-preview[bot]andMichael Vorburger ⛑️ 2d0d76fc01 Bump tika-core from 1.9 to 1.24.1 in /fineract-provider
Bumps [tika-core](https://github.com/apache/tika) from 1.9 to 1.24.1.
- [Release notes](https://github.com/apache/tika/releases)
- [Changelog](https://github.com/apache/tika/blob/1.24.1/CHANGES.txt)
- [Commits](https://github.com/apache/tika/commits/1.24.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 14:46:55 +02:00
dependabot-preview[bot]andMichael Vorburger ⛑️ ea61519b63 Bump creadur-rat-gradle from 0.2.2 to 0.3.1 in /fineract-provider
Bumps creadur-rat-gradle from 0.2.2 to 0.3.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 14:44:47 +02:00
dependabot-preview[bot]andMichael Vorburger ⛑️ 6464518179 Bump swagger-jersey-jaxrs from 1.5.15 to 1.6.1 in /fineract-provider
Bumps swagger-jersey-jaxrs from 1.5.15 to 1.6.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 14:35:08 +02:00
dependabot-preview[bot]andMichael Vorburger ⛑️ a45c2072a0 Bump aws-java-sdk-s3 from 1.11.80 to 1.11.779 in /fineract-provider
Bumps [aws-java-sdk-s3](https://github.com/aws/aws-sdk-java) from 1.11.80 to 1.11.779.
- [Release notes](https://github.com/aws/aws-sdk-java/releases)
- [Changelog](https://github.com/aws/aws-sdk-java/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-java/compare/1.11.80...1.11.779)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-05-10 13:43:49 +02:00
Michael Vorburger 55af726cf9 improve SchedulerJobsTest.testDateFormat() by introducing Awaitility
This recently introduced new test (FINERACT-926) would locally pass, but
then fail on the next run, because another test in the same class would
modify job state to be inactive.  It now sets the first jobs state as it
requires it to be, and properly awaits the expected outcome.
2020-05-09 17:05:32 +02:00
Michael Vorburger 6a8f48c06c remove fixed Slfj4j versions to fix broken logging (FINERACT-956) 2020-05-09 05:48:15 +02:00
Michael Vorburger fa74e77e7e clean up dependencies.gradle and clarify scopes (FINERACT-777)
This also solves this Gradle messages:  Deprecated Gradle features were
used in this build, making it incompatible with Gradle 7.0. Use
'--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.4/userguide/command_line_interface.html#sec:command_line_warnings
2020-05-09 05:47:13 +02:00
Michael Vorburger ⛑️andGitHub 22224709b6 upgrade Spotbugs plugin from 2.0.1 to latest 4.0.8 (FINERACT-947) (#841) 2020-05-08 19:15:19 +01:00
Michael Vorburger 9254a74bb5 upgrade Spring Boot from 2.2.4 to 2.2.7 (FINERACT-941) 2020-05-08 16:16:56 +02:00
Petri TuomolaandMichael Vorburger ⛑️ ec9ef92ff6 FINERACT-938: Upgrading nekohtml and removing direct reference to Xerces 2020-05-08 12:33:25 +02:00
Petri TuomolaandMichael Vorburger ⛑️ 0e4aeef1af FINERACT-846: Migrating to Java 11, upgrading dependencies, fixing compiler warnings 2020-05-07 22:28:19 +02:00
Petri TuomolaandMichael Vorburger ⛑️ b05162f60b FINERACT-730: Fixed dependencies, SSL config and main class etc to get bootRun to work. Migrated from Gradle Tomcat plugin to Cargo plugin to fix integration test 2020-05-05 22:04:04 +02:00
Michael Vorburger edfcb931e9 Gradle testLogging exceptionFormat "full" (FINERACT-927)
as well as integrationTest --fail-fast
2020-05-05 10:52:02 +02:00
Michael Vorburger b6c6d50501 fix moar 3rd-party versions in build.gradle (see FINERACT-805) 2020-05-04 03:00:31 +02:00
Michael Vorburger 404f055b65 remove old spring-jms:4.0.7 & fix JMS dependencies (FINERACT-805) 2020-05-03 19:52:12 +02:00
Michael Vorburger 83cdb17d8f exclude dependencies causing classpath duplicates (FINERACT-919) 2020-05-03 19:52:12 +02:00
Michael Vorburger c9f2591766 Upgrade Jersey library from 1.17 to 1.19.4 (FINERACT-920) 2020-05-03 03:12:15 +02:00
Michael Vorburger 8418dd424f upgrade OpenJPA from 3.1.0 to 3.1.1 (FINERACT-908) 2020-05-02 22:42:10 +02:00
xurrorandMichael Vorburger ⛑️ 394a7fb1d1 IntegrationTests for git build info 2020-04-26 16:47:27 +02:00
xurrorandMichael Vorburger ⛑️ 0a80195ac2 Fix rat reports 2020-04-26 16:47:27 +02:00
xurrorandMichael Vorburger ⛑️ c317db110f FINERACT-883
Display fineracts git build info actuator/info endpoint
2020-04-26 16:47:27 +02:00
26b619eea7 FINERACT-809 (#719) : Upgrade RestAssured version
Upgrade RestAssured version

closes https://issues.apache.org/jira/browse/FINERACT-809

Co-authored-by: percyashu <percyayukashu@gmail.com>

Co-authored-by: percyashu <percyayukashu@gmail.com>
2020-04-12 20:36:15 +01:00
Manthan SurkarandGitHub 402c41dd95 Add Jacoco to measure code coverage (FINERACT-725 / PR #742)
* Added Code Coverage Section in Readme
2020-04-01 23:29:15 +02:00
xurrorandMichael Vorburger ⛑️ 3475c0cfb7 FINERACT-796
Use Hikari instead of Tomcat Connection Pool
 - Created hikari connection pool bean
 - Configured connection parameters to match hikari
 - Removed tomcat-jdbc and dbcp
 - Remove unused classes
 - Add Hikari to logback
 - update hikaridatasource bean

closes https://issues.apache.org/jira/browse/FINERACT-796

remove hikaricp import from gradle files

more specific bean config

- Set up datasource properties
- Cleanup unused classes
- Add hikari to logback
2020-03-28 15:06:34 +01:00
percyashuandMichael Vorburger ⛑️ 2e620b4de8 FINERACT-823 Gradle modernizer fixing violations 2020-03-23 00:54:00 +01:00
xurrorandMichael Vorburger ⛑️ f484f884a0 FINERACT-696
add spotbug bug-pattern plugin.

Apply suggestions from code review

closes https://issues.apache.org/jira/browse/FINERACT-696

Co-Authored-By: Michael Vorburger ⛑️ <mike@vorburger.ch>
2020-03-13 09:27:34 +01:00
xurrorandMichael Vorburger ⛑️ a7ebef4781 FINERACT-807
change mifosplatform-tenants and mifostenant-default to fineract_tenants
 and fineract_default respectively

closes https://issues.apache.org/jira/projects/FINERACT/issues/FINERACT-807?filter=allopenissues
2020-03-08 14:16:05 +01:00
Michael Vorburger ⛑️andAwasum Yannick 14175a1854 Minor: Remove comment in build.gradle re. springDataJpaVersion (#702)
This has been removed in a20f76d686,
and it's confusing to look for what that means, e.g. while code
reviewing proposed "bump" changes to the used versions of
spring.gradle:dependency-management-plugin and
springframework.boot:spring-boot-gradle-plugin.
2020-01-27 22:00:28 +01:00
Awasum YannickandMichael Vorburger ⛑️ 66ae79bbe7 Upgrade Spring Boot from 2.1.7 to 2.2.4 2020-01-27 21:05:29 +01:00
Michael Vorburger fbccc57fb9 enforce initial set of Checkstyle rules (FINERACT-821)
This is, intentionally, for whitespace related rules, only.

The idea is to now gradually extend it.
2020-01-19 19:59:38 +01:00
Michael Vorburger 125924303b Temporarily remove the build realted Swagger changes (FINERACT-733)
as well as implement all review feedback provided on the original PR

see https://github.com/apache/fineract/pull/629 for background

also https://jira.apache.org/jira/browse/FINERACT-733
2020-01-19 15:24:11 +01:00
Kang BrederandMichael Vorburger ⛑️ e424471162 Initial Swagger related changes from GSOC 2019 contrib (FINERACT-733)
This commit does not yet provide the full Swagger requirement, as was
outlined in FINERACT-733, but it's a first step forming the basis of
more to come (hopefully).  Here's the original PR description (but
note that some of this is about to be reverted in the next commit):


Reflected all API descriptions on swagger UI.

Formatted API descriptions.

Added swagger docs for new APIs.

Added swagger-gradle-plugin for automatic save of json during build.

Leveraged swagger codegen for generation of language-specific libraries
using gradle-swagger-generator plugin.
2020-01-19 15:24:11 +01:00
Awasum YannickandGitHub fc786fa3f6 Merge pull request #684 from vorburger/spotbugs-extra
more SpotBugs related / inspired code clean up (see FINERACT-702)
2020-01-14 08:37:20 +01:00
Michael Vorburger 0379ba7628 fix build.gradle for RAT to ignore .github/workflows/ 2020-01-13 09:53:24 +01:00
Michael Vorburger 6ca1a678cb more SpotBugs related / inspired code clean up (see FINERACT-702)
based upon code review of changes made by @awasum in previous commit:

 - fix clear contains() GC_UNRELATED_TYPES bug in Loan

 - fix clear equals() EC_UNRELATED_TYPES bug in Loan

 - fix more equals() & hashCode() in...
    * Charge
    * TrialBalance
    * LoanProductBorrowerCycleVariations
    * LoanProductProvisioningEntry

 - fix AccountingConstants to avoid using @FindBugsSuppressWarnings

 - fix SelfLoansDataValidator instead of @FindBugsSuppressWarnings

 - minor clean up in build.gradle (spotbugs has replaced findbugs)

PS: This change originally included also fixing the missing hashCode()
    and equals() in ShareAccountCharge, but that turned out to be non
    trivial, see FINERACT-827, and is thus not yet fixed by this.
2020-01-13 08:41:16 +01:00
Awasum YannickandMichael Vorburger ⛑️ af0dd7e5f3 use SpotBugs & fix over 300 high priority rule violations (FINERACT-702)
This PR also serves as a base solution for upcoming FINERACT-712 and
FINERACT-696.  It includes using Objects.equals() to prevent NPEs, and
adding gradle check to run SpotBugs on Travis CI.

PS: SpotBugs is the successor to (and same code as) FindBugs.
2020-01-12 13:16:42 +01:00