niteshandClaude Sonnet 5
ce8bb7e5ca
Root cause: ProductPendingEditFieldMapper.populateCoreFields() captured
otherGlMappings with stringValueOfParameterNamed(), which only handles a
JSON string primitive. The maker's edit actually submits otherGlMappings
as a nested {assets,liabilities,expenses,income} object -- the same shape
SavingsProduct#update() already reads correctly via jsonFragment() -- so
the pending-edit row was staged with this field blank every time,
regardless of what the maker changed.
Two consequences, both now fixed:
- The checker's diff dialog showed "No changes to review" even when a GL
account mapping (e.g. Savings/Current/FD/RD Interest Payable or Paid)
was genuinely changed, since the submitted value never made it into
proposedChanges.
- Approving the edit replayed a payload with no otherGlMappings at all,
so the GL account change was silently dropped rather than applied --
the edit showed as approved, but the product's accounting mapping
never actually moved.
Fixed the write side (jsonFragment instead of stringValueOfParameterNamed)
and the read-side replay (writeCoreFieldsToJson now re-adds the stored
value as a parsed JSON element via the new putJsonFragment, not a quoted
string, which would have double-encoded it on replay). Shared by Savings,
Current, FD and RD products, since they all go through this one mapper.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>