feat(shares): close share account directly on withdrawal approval; drop separate closure-request flow

Replaces the auto-submit-closure-request behavior with an immediate
account close, in the same approval action, when a withdrawal brings
shares to zero — matching the backend's new single-step close-on-
approval flow. Removes the now-unneeded Share Closure Request feature
entirely: dedicated create/list components (Clerk Dashboard + Approval
Center), routes, nav links, and the "eligible for closure" banner on
the Share Account view.

Also adds a clear "this will close the account" notice wherever a
withdrawal would zero out the account's shares — the standalone Share
Withdrawal Request page (submit + review) and Transaction Entry's
Share Redemption Transfer confirm dialog — styled as an amber warning
callout rather than a plain info line. Trims that confirm dialog to
just the required details (dropped the redundant ECS A/C No. line and
the validation-checklist block) and compacts its overall size.

src/app/cashier/transaction-entry/transaction-entry.component.ts

@@ -807,6 +807,9 @@ export class TransactionEntryComponent implements OnInit, OnDestroy {
   // Per-row linked savings account number, keyed by the Share account's own acNo — used to make
   // sure a Share-to-linked-account Bank Transfer actually credits the right account.
   rowLinkedSavingsAcNo: Record<string, string> = {};
+  // Per-row shares currently held, keyed by acNo — lets submitShareRedemptionTransfer() warn the
+  // clerk when a withdrawal will bring the account's holding to zero (closing it on approval).
+  rowShareHoldings: Record<string, number> = {};
 
   // Full account + client data
   accountDetails: any = null;
@@ -1645,26 +1648,31 @@ export class TransactionEntryComponent implements OnInit, OnDestroy {
     };
 
     const sharePrice = this.rowSharePrices[shareRow.acNo] ?? 0;
+    const currentHolding = this.rowShareHoldings[shareRow.acNo] ?? 0;
+    const remainingShares = currentHolding - shares;
+    const willCloseAccount = remainingShares <= 0;
     const confirmLines = [
       `Share Account: ${shareRow.acNo}  ·  Client: ${this.rowAccountNames[shareRow.acNo] ?? '—'}`,
       `Shares to Withdraw: ${shares} @ ₹${sharePrice.toLocaleString('en-IN', { minimumFractionDigits: 2 })} = ₹${(shares * sharePrice).toLocaleString('en-IN', { minimumFractionDigits: 2 })}`,
+      `Remaining Shares After Withdrawal: ${Math.max(remainingShares, 0)}`,
+      ...(willCloseAccount
+        ? ['⚠ All shares withdrawn — this account will be CLOSED automatically when the Manager approves.']
+        : []),
       `Board Resolution No.: ${payload.resolutionNumber}`,
       `Date of Meeting: ${payload.meetingDate}`,
       `Settlement Credit To: ${linkedAcNo}`,
       `Settlement Payment Type: ${settlementPaymentType?.name ?? '—'}`,
-      ...(settlementRowSnapshot.ecsAccountNo ? [`ECS A/C No.: ${settlementRowSnapshot.ecsAccountNo}`] : []),
+      ...(settlementRowSnapshot.ecsAccountNo && settlementRowSnapshot.ecsAccountNo !== linkedAcNo
+        ? [`ECS A/C No.: ${settlementRowSnapshot.ecsAccountNo}`]
+        : []),
       ...(settlementRowSnapshot.chequeNo ? [`Cheque No.: ${settlementRowSnapshot.chequeNo}`] : []),
       ...(settlementRowSnapshot.chequeDate ? [`Cheque Date: ${settlementRowSnapshot.chequeDate}`] : []),
       ...(settlementRowSnapshot.tokenNo ? [`Token No.: ${settlementRowSnapshot.tokenNo}`] : []),
       ...(settlementRowSnapshot.description ? [`CR Row Remarks: ${settlementRowSnapshot.description}`] : []),
       '',
-      'Validation checks:',
-      `  ✓ Share account and linked savings account both loaded`,
-      `  ✓ CR account matches this Share account's linked savings account`,
-      `  ✓ Settlement Payment Type is non-cash`,
-      `  ✓ Board Resolution Number and Date of Meeting provided`,
-      '',
-      'Pending Manager approval — redemption and settlement both post together on approval.'
+      willCloseAccount
+        ? 'Pending Manager approval — redemption, settlement and account closure all post together on approval.'
+        : 'Pending Manager approval — redemption and settlement both post together on approval.'
     ];
     this.showConfirmAlert('info', 'Confirm Share Withdrawal Request', confirmLines, 'Submit for Approval', () =>
       this.doSubmitShareRedemptionTransfer(payload, shareRow, shares, linkedAcNo)
@@ -1695,9 +1703,12 @@ export class TransactionEntryComponent implements OnInit, OnDestroy {
       .subscribe((res: any) => {
         this.saving = false;
         if (res) {
+          const willCloseAccount = (this.rowShareHoldings[shareRow.acNo] ?? 0) - shares <= 0;
           this.showAlert('success', 'Share Withdrawal Submitted', [
             `${shares} share(s) from ${shareRow.acNo} → settlement to ${linkedAcNo} on approval.`,
-            'Pending Manager approval. Track status in "My Share Requests".'
+            willCloseAccount
+              ? 'Pending Manager approval — this will close the share account, since all shares will be withdrawn. Track status in "My Share Requests".'
+              : 'Pending Manager approval. Track status in "My Share Requests".'
           ]);
           this.rows = [];
           this.rowAccountIds = {};
@@ -1705,6 +1716,7 @@ export class TransactionEntryComponent implements OnInit, OnDestroy {
           this.rowSharePrices = {};
           this.rowClientIds = {};
           this.rowLinkedSavingsAcNo = {};
+          this.rowShareHoldings = {};
           this.addRow();
           this.selectedRow = this.rows[0];
           this.accountDetails = null;
@@ -2108,6 +2120,9 @@ export class TransactionEntryComponent implements OnInit, OnDestroy {
         // rowSharePrices[row.acNo]) reads via row.acNo, so this must match or every lookup misses.
         this.rowSharePrices[this.selectedRow.acNo] = Number(acc.currentMarketPrice) || 0;
         this.rowLinkedSavingsAcNo[this.selectedRow.acNo] = acc.savingsAccountNumber ?? '';
+        this.rowShareHoldings[this.selectedRow.acNo] = Number(
+          acc.summary?.totalApprovedShares ?? acc.totalApprovedShares ?? 0
+        );
         this.syncShareLinkedAmounts();
       }
       return true;