fix: multiple usage of app header (#48)

Remove multiple usage of app header component and use the shell component
to route with shell, loading the header only once initially.

Fixes #47
This commit is contained in:
Abhay Chawla
2018-06-15 00:21:22 +05:30
committed by GitHub
parent 6be70d6cb4
commit 052568bba6
9 changed files with 74 additions and 74 deletions
@@ -1,10 +1,13 @@
import { NgModule } from '@angular/core'; import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router'; import { Routes, RouterModule } from '@angular/router';
import { Route, extract } from '@app/core';
import { AccountingComponent } from './accounting.component'; import { AccountingComponent } from './accounting.component';
const routes: Routes = [ const routes: Routes = [
{ path: 'accounting', component: AccountingComponent}, Route.withShell([
{ path: 'accounting', component: AccountingComponent}
])
]; ];
@NgModule({ @NgModule({
@@ -1,4 +1,3 @@
<app-header> </app-header>
<div class="fluid-container"> <div class="fluid-container">
<div class="container"> <div class="container">
<div class="card-body"> <div class="card-body">
+7 -5
View File
@@ -1,17 +1,19 @@
import { NgModule } from '@angular/core'; import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router'; import { Routes, RouterModule } from '@angular/router';
import { extract } from '@app/core';
import { Route, extract } from '@app/core';
import { ClientsComponent } from './clients.component'; import { ClientsComponent } from './clients.component';
import { CreateClientComponent} from './create-client/create-client.component'; import { CreateClientComponent} from './create-client/create-client.component';
import { ViewClientComponent } from './view-client/view-client.component'; import { ViewClientComponent } from './view-client/view-client.component';
import { ViewLoanComponent } from './view-loan/view-loan.component'; import { ViewLoanComponent } from './view-loan/view-loan.component';
const routes: Routes = [ const routes: Routes = [
{ path: 'clients', component: ClientsComponent}, Route.withShell([
{ path: 'clients/create', component: CreateClientComponent}, { path: 'clients', component: ClientsComponent},
{ path: 'clients/view', component: ViewClientComponent}, { path: 'clients/create', component: CreateClientComponent},
{ path: 'clients/viewloan', component: ViewLoanComponent} { path: 'clients/view', component: ViewClientComponent},
{ path: 'clients/viewloan', component: ViewLoanComponent}
])
]; ];
@NgModule({ @NgModule({
-1
View File
@@ -1,4 +1,3 @@
<app-header> </app-header>
<div class="fluid-container"> <div class="fluid-container">
<div class="container"> <div class="container">
<div class="card mt-5"> <div class="card mt-5">
@@ -1,4 +1,3 @@
<app-header> </app-header>
<div class="container"> <div class="container">
<aw-wizard class="mt-5" #wizard [navBarLayout]="'large-empty-symbols'"> <aw-wizard class="mt-5" #wizard [navBarLayout]="'large-empty-symbols'">
@@ -1,4 +1,3 @@
<app-header> </app-header>
<div class="fluid-container"> <div class="fluid-container">
<div class="container"> <div class="container">
<div class="row"> <div class="row">
@@ -1,5 +1,3 @@
<app-header></app-header>
<div class="fluid-container"> <div class="fluid-container">
<div class="container"> <div class="container">
<div class="col text-center"> <div class="col text-center">
@@ -1,10 +1,13 @@
import { NgModule } from '@angular/core'; import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router'; import { Routes, RouterModule } from '@angular/router';
import { Route, extract } from '@app/core';
import { NavigationComponent } from './navigation.component'; import { NavigationComponent } from './navigation.component';
const routes: Routes = [ const routes: Routes = [
{ path: 'navigation', component: NavigationComponent}, Route.withShell([
{ path: 'navigation', component: NavigationComponent}
])
]; ];
@NgModule({ @NgModule({
@@ -1,4 +1,3 @@
<app-header></app-header>
<div class="fluid-container"> <div class="fluid-container">
<div class="container"> <div class="container">
@@ -163,4 +162,3 @@
</ngb-tabset> </ngb-tabset>
</div> </div>
</div> </div>