Revert "WEB-(394)-fix: replace all direct JSON.parse usages with safe parsing utilities"

src/app/settings/settings.service.ts

@@ -2,7 +2,6 @@
 import { Injectable } from '@angular/core';
 import { AlertService } from 'app/core/alert/alert.service';
 import { Dates } from 'app/core/utils/dates';
-import { safeParse, safeParseArray, safeParseObject } from 'app/core/utils/json';
 
 /** Environment Imports */
 import { environment } from '../../environments/environment';
@@ -109,9 +108,8 @@ export class SettingsService {
   /**
    * Returns date format setting.
    */
-  get dateFormat(): string {
-    const parsed = safeParse<string | null>(localStorage.getItem('mifosXDateFormat'), null);
-    return typeof parsed === 'string' && parsed.length > 0 ? parsed : 'dd MMMM yyyy';
+  get dateFormat() {
+    return JSON.parse(localStorage.getItem('mifosXDateFormat'));
   }
 
   /**
@@ -121,10 +119,7 @@ export class SettingsService {
     if (!localStorage.getItem('mifosXLanguage')) {
       this.setDefaultLanguage();
     }
-    return safeParseObject<{ name: string; code: string } | undefined>(
-      localStorage.getItem('mifosXLanguage'),
-      undefined
-    );
+    return JSON.parse(localStorage.getItem('mifosXLanguage'));
   }
 
   get languageCode() {
@@ -152,7 +147,7 @@ export class SettingsService {
    * Returns list of default server
    */
   get servers() {
-    return safeParseArray<string>(localStorage.getItem('mifosXServers'), []);
+    return JSON.parse(localStorage.getItem('mifosXServers'));
   }
 
   /**
@@ -165,7 +160,7 @@ export class SettingsService {
     if (environment.baseApiUrl && environment.baseApiUrl !== '') {
       return environment.baseApiUrl;
     } else {
-      return this.servers[0];
+      return this.servers()[0];
     }
   }
 
@@ -222,7 +217,7 @@ export class SettingsService {
    * Returns list of Tenant Identifiers
    */
   get tenantIdentifiers(): any {
-    return safeParseArray<string>(localStorage.getItem('mifosXTenantIdentifiers'), []);
+    return JSON.parse(localStorage.getItem('mifosXTenantIdentifiers'));
   }
 
   /**
@@ -265,6 +260,6 @@ export class SettingsService {
   }
 
   get themeDarkEnabled(): boolean {
-    return safeParse<boolean>(localStorage.getItem('mifosXThemeDarkEnabled'), false);
+    return JSON.parse(localStorage.getItem('mifosXThemeDarkEnabled'));
   }
 }