merge angular-17 into dev to upgrade from Angular v16 to v17

src/app/savings/saving-account-actions/manage-savings-account/manage-savings-account.component.ts

@@ -7,6 +7,15 @@ import { SettingsService } from 'app/settings/settings.service';
 import { Currency } from 'app/shared/models/general.model';
 import { SystemService } from 'app/system/system.service';
 
+type TransactionCommandType = 'holdamount' | 'blockaccount' | 'blockdeposit' | 'blockwithdrawal';
+
+interface TransactionType {
+  holdamount: boolean;
+  blockaccount: boolean;
+  blockdeposit: boolean;
+  blockwithdrawal: boolean;
+}
+
 @Component({
   selector: 'mifosx-manage-savings-account',
   templateUrl: './manage-savings-account.component.html',
@@ -22,16 +31,11 @@ export class ManageSavingsAccountComponent implements OnInit {
   manageSavingsAccountForm: UntypedFormGroup;
   /** Savings Account Id */
   savingAccountId: string;
-  transactionCommand: string;
+  transactionCommand: TransactionCommandType;
 
   reasonOptions: any = [];
 
-  transactionType: {
-    holdamount: boolean;
-    blockaccount: boolean;
-    blockdeposit: boolean;
-    blockwithdrawal: boolean;
-  } = {
+  transactionType: TransactionType = {
     holdamount: false,
     blockaccount: false,
     blockdeposit: false,
@@ -130,7 +134,7 @@ export class ManageSavingsAccountComponent implements OnInit {
 
   submit() {
     let command = '';
-    let payload = {};
+    let payload: { transactionAmount?: number; [key: string]: any } = {};
 
     if (this.transactionType.holdamount) {
       const manageSavingsAccountFormData = this.manageSavingsAccountForm.value;

src/app/savings/saving-account-actions/saving-account-actions.component.ts

@@ -68,7 +68,9 @@ export class SavingAccountActionsComponent {
         this.currency = data.savingsAccountActionData.currency;
       }
     });
-    const name = this.route.snapshot.params['name'];
-    this.actions[name] = true;
+    const name = this.route.snapshot.params['name'] as string;
+    if (name in this.actions) {
+      this.actions[name as keyof typeof this.actions] = true;
+    }
   }
 }

src/app/savings/saving-account-actions/savings-account-transactions/savings-account-transactions.component.ts

@@ -66,7 +66,7 @@ export class SavingsAccountTransactionsComponent implements OnInit {
       }
     });
     this.transactionCommand = this.route.snapshot.params['name'].toLowerCase();
-    this.transactionType[this.transactionCommand] = true;
+    this.transactionType[this.transactionCommand as 'deposit' | 'withdrawal'] = true;
     this.savingAccountId = this.route.snapshot.params['savingAccountId'];
   }
 

src/app/savings/savings-account-view/savings-account-view.component.ts

@@ -85,7 +85,7 @@ export class SavingsAccountViewComponent implements OnInit {
         taskPermissionName: 'CREATE_ACCOUNTTRANSFER'
       });
     }
-    if (this.savingsAccountData.externalId && environment.interbankTransfers === 'true') {
+    if (this.savingsAccountData.externalId && environment.interbankTransfers) {
       this.buttonConfig.addOption({
         name: 'Interbank Transfer',
         taskPermissionName: 'CREATE_ACCOUNTTRANSFER'

src/app/savings/savings-account-view/transactions/edit-transaction/edit-transaction.component.html

@@ -38,8 +38,7 @@
         </mat-form-field>
 
         <div class="flex-fill">
-          <span class="expandcollapsebutton m-l-10 m-t-40 flex-75">
-            (click)="addPaymentDetails()">
+          <span class="expandcollapsebutton m-l-10 m-t-40 flex-75" (click)="addPaymentDetails()">
             <mat-slide-toggle>
               <div [className]="showPaymentDetails ? 'enabled' : 'disabled'">
                 <span class="m-l-10">{{ 'labels.inputs.Show Payment Details' | translate }}</span>