fix: Charges min and max gap validations and labels

src/app/products/charges/create-charge/create-charge.component.html

@@ -203,7 +203,7 @@
               <input matInput autofocus formControlName="minCap" mifosxValidateOnFocus />
               <mat-error *ngIf="chargeForm.controls.minCap.hasError('maxValue')">
                 {{ 'errors.validation.msg.loanproduct.maximumGap.not.greater.than.specified.number' | translate }} ({{
-                  chargeForm.controls.maxCap.value
+                  chargeForm.controls.minCap.value
                 }})
               </mat-error>
             </mat-form-field>

src/app/products/charges/edit-charge/edit-charge.component.html

@@ -115,7 +115,7 @@
             <input matInput autofocus formControlName="minCap" mifosxValidateOnFocus />
             <mat-error *ngIf="chargeForm.controls.minCap.hasError('maxValue')">
               {{ 'errors.validation.msg.loanproduct.maximumGap.not.greater.than.specified.number' | translate }} ({{
-                chargeForm.controls.maxCap.value
+                chargeForm.controls.minCap.value
               }})
             </mat-error>
           </mat-form-field>

src/app/shared/validators/max-number-value.validator.ts

@@ -8,6 +8,9 @@ export function maxNumberValueValidator(maxControlName: string): ValidatorFn {
     }
 
     let maxValue = maxControl.value;
+    if (maxValue == null) {
+      return null;
+    }
     if (typeof maxValue === 'undefined') {
       return null;
     }