From 30e895c35230f100bd7be10894410b7f22601368 Mon Sep 17 00:00:00 2001 From: Felix van Hove Date: Fri, 21 Feb 2025 04:55:11 +0100 Subject: [PATCH] fix: make all the configuration wizards work (#2267) Correct labels in the context of the wizards, make no wizard terminates prematurely, make modal windows appear well positioned. Fixes: WEB-11 --- .../breadcrumb/breadcrumb.component.html | 2 +- .../manage-currencies.component.html | 8 +++---- .../manage-funds/manage-funds.component.html | 2 +- .../create-office.component.html | 4 ++-- .../offices/offices.component.html | 6 ++--- .../working-days/working-days.component.html | 2 +- .../loan-products.component.html | 2 +- .../saving-products.component.html | 2 +- .../share-products.component.html | 2 +- .../roles-and-permissions.component.ts | 2 +- src/app/system/system.component.html | 24 ++++++++++--------- .../create-user/create-user.component.ts | 2 +- src/app/users/users.component.ts | 2 +- src/assets/translations/en-US.json | 18 +++++++------- 14 files changed, 40 insertions(+), 38 deletions(-) diff --git a/src/app/core/shell/breadcrumb/breadcrumb.component.html b/src/app/core/shell/breadcrumb/breadcrumb.component.html index d8c8c098f..2ee09f2ac 100644 --- a/src/app/core/shell/breadcrumb/breadcrumb.component.html +++ b/src/app/core/shell/breadcrumb/breadcrumb.component.html @@ -14,7 +14,7 @@ -

{{ 'labels.popovers.Breadcrumbs' | translate }}

+

{{ 'labels.menus.Breadcrumbs' | translate }}

{{ "labels.text.User's current location" | translate }}

 diff --git a/src/app/organization/manage-funds/manage-funds.component.html b/src/app/organization/manage-funds/manage-funds.component.html index 05b500df0..6309b34f8 100644 --- a/src/app/organization/manage-funds/manage-funds.component.html +++ b/src/app/organization/manage-funds/manage-funds.component.html @@ -1,5 +1,5 @@
-
+
diff --git a/src/app/organization/offices/offices.component.html b/src/app/organization/offices/offices.component.html index b7ae05cd2..2c56d7231 100644 --- a/src/app/organization/offices/offices.component.html +++ b/src/app/organization/offices/offices.component.html @@ -1,5 +1,5 @@
- + @@ -29,7 +29,7 @@
-
+
{{ 'Filter' | translate }} @@ -37,7 +37,7 @@
-
+
diff --git a/src/app/organization/working-days/working-days.component.html b/src/app/organization/working-days/working-days.component.html index 4a1b6c809..616c02134 100644 --- a/src/app/organization/working-days/working-days.component.html +++ b/src/app/organization/working-days/working-days.component.html @@ -66,7 +66,7 @@ {{ 'labels.buttons.Back' | translate }} diff --git a/src/app/products/loan-products/loan-products.component.html b/src/app/products/loan-products/loan-products.component.html index 6118ccb50..5f3c4209c 100644 --- a/src/app/products/loan-products/loan-products.component.html +++ b/src/app/products/loan-products/loan-products.component.html @@ -59,7 +59,7 @@ -

{{ 'labels.heading.Create Loan Product' | translate }}t

+

{{ 'labels.heading.Create loan product' | translate }}

{{ 'labels.text.This option allows you to create new loan product.' | translate }}

 diff --git a/src/app/products/share-products/share-products.component.html b/src/app/products/share-products/share-products.component.html index d4f85be8f..b265b1e63 100644 --- a/src/app/products/share-products/share-products.component.html +++ b/src/app/products/share-products/share-products.component.html @@ -87,7 +87,7 @@

{{ 'labels.heading.List of share products in the organization' | translate }}: {{ - 'labels.buttons.Share Products' | translate + 'labels.text.Share Products' | translate }}

diff --git a/src/app/system/roles-and-permissions/roles-and-permissions.component.ts b/src/app/system/roles-and-permissions/roles-and-permissions.component.ts index 1e697ceb3..e8825a33c 100644 --- a/src/app/system/roles-and-permissions/roles-and-permissions.component.ts +++ b/src/app/system/roles-and-permissions/roles-and-permissions.component.ts @@ -140,7 +140,7 @@ export class RolesAndPermissionsComponent implements OnInit, AfterViewInit { this.configurationWizardService.showRolesandPermissionPage = false; this.configurationWizardService.showRolesandPermissionList = false; this.configurationWizardService.showUsers = true; - this.router.navigate(['/users']); + this.router.navigate(['/appusers']); } /** diff --git a/src/app/system/system.component.html b/src/app/system/system.component.html index 88786359c..99f2e69bb 100644 --- a/src/app/system/system.component.html +++ b/src/app/system/system.component.html @@ -131,17 +131,19 @@

- - - - -

{{ 'labels.heading.Manage Reports' | translate }}

- - -

- {{ 'labels.text.Add new report and classify reports' | translate }} -

- +
+ + + + +

{{ 'labels.heading.Manage Reports' | translate }}

+ + +

+ {{ 'labels.text.Add new report and classify reports' | translate }} +

+ +
diff --git a/src/app/users/create-user/create-user.component.ts b/src/app/users/create-user/create-user.component.ts index 3785872f7..b86148d25 100644 --- a/src/app/users/create-user/create-user.component.ts +++ b/src/app/users/create-user/create-user.component.ts @@ -221,7 +221,7 @@ export class CreateUserComponent implements OnInit, AfterViewInit { previousStep() { this.configurationWizardService.showUsersForm = false; this.configurationWizardService.showUsersList = true; - this.router.navigate(['/users']); + this.router.navigate(['/appusers']); } /** diff --git a/src/app/users/users.component.ts b/src/app/users/users.component.ts index 5b3177794..a2ff89759 100644 --- a/src/app/users/users.component.ts +++ b/src/app/users/users.component.ts @@ -129,7 +129,7 @@ export class UsersComponent implements OnInit, AfterViewInit { this.configurationWizardService.showUsers = false; this.configurationWizardService.showUsersList = false; this.configurationWizardService.showUsersForm = true; - this.router.navigate(['/users/create']); + this.router.navigate(['/appusers/create']); } /** diff --git a/src/assets/translations/en-US.json b/src/assets/translations/en-US.json index 41d700b00..0f203b399 100644 --- a/src/assets/translations/en-US.json +++ b/src/assets/translations/en-US.json @@ -2656,7 +2656,7 @@ "All Recurring Deposits": "All Recurring Deposits", "All Savings": "All Savings", "Allocate Cash": "Allocate Cash", - "Allows you to create new fixed deposit product": "This option allows you to create new fixed deposit product.", + "Allows you to create new fixed deposit product": "This option allows you to create a new fixed deposit product.", "This option allows you to create new users in your organization": "This option allows you to create new users in your organization", "Alternative way-Tree view": "There is an alternative way to view your accounts - using the Tree View.", "Amazon S3": "Amazon S3", @@ -2775,7 +2775,7 @@ "Create new closure": "This option allows you to create new closure.", "Create new employees in your organization": "This option allows you to create new employees in your organization.", "Create new offices": "This option allows you to create new offices in your organization.", - "Create new report": "This option allows you to create new report.", + "Create new report": "This option allows you to create a new report.", "Create provisioning entries": "Create provisioning entries", "Create standing instructions at disbursement": "Create standing instructions at disbursement", "Currencies available across organization": "Currencies available across organization for different products", @@ -2907,7 +2907,7 @@ "Fixed Deposit Account Transactions": "Fixed Deposit Account Transactions", "Fixed Deposit Account View": "Fixed Deposit Account View", "Fixed Deposit Products": "Fixed Deposit Products", - "Fixed Deposit Products defines the rules, default settings": "Fixed Deposit Products defines the rules, default settings, and constraints for a financial institution's
fixed deposit offerings (also referred to as term deposits). A fixed deposit product provides a template for multiple fixed deposit accounts for the financial institution's clients.", + "Fixed Deposit Products defines the rules, default settings": "Fixed Deposit Products defines the rules, default settings, and constraints for a financial institution's fixed deposit offerings (also referred to as term deposits). A fixed deposit product provides a template for multiple fixed deposit accounts for the financial institution's clients.", "Fixed Deposits Account Actions": "Fixed Deposits Account Actions", "Fixed Deposits Account Transactions": "Fixed Deposits Account Transactions", "FixedDepositAccountCreateBusinessEvent": "FixedDepositAccountCreateBusinessEvent", @@ -3141,10 +3141,10 @@ "These are predefined postings": "These are predefined postings", "this": "this", "This allows you to manage funds associated with loans.": "This allows you to manage funds associated with loans.", - "This option allows you to create new loan product.": "This option allows you to create new loan product.", - "This option allows you to create new recurring product.": "This option allows you to create new recurring product.", - "This option allows you to create new savings product.": "This option allows you to create new savings product.", - "This option allows you to create new share product.": "This option allows you to create new share product.", + "This option allows you to create new loan product.": "This option allows you to create a new loan product.", + "This option allows you to create new recurring product.": "This option allows you to create a new recurring product.", + "This option allows you to create new savings product.": "This option allows you to create a new savings product.", + "This option allows you to create new share product.": "This option allows you to create a new share product.", "This shows all the notifications.": "This shows all the notifications.", "This will navigate the user to the dashboard component.": "This will navigate the user to the dashboard component.", "This will navigate the user to the searched activity.": "This will navigate the user to the searched activity.", @@ -3164,8 +3164,8 @@ "Unassigned": "Unassigned", "Undo approval of shares account with ID": "Are you sure you want to undo approval of shares account with ID", "Used Add Fund": "This form will be used to add fund. If you would like to add fund click on add funds button and fill the fund name then click on + button else click Next or Back. For more details click", - "Used to add currency": "This form will be used to add currency. To add currency click on add currency and fill the form and then click add else click back or next. For more details click", - "User Dashboard Component": "This will navigate the user to dashboard component.", + "Used to add currency": "This form will be used to add a currency. To add a currency, click on \"add currency\" and fill the form. For more details click", + "User Dashboard Component": "This will navigate the user to the dashboard component.", "User Entity navigation screen": "This will navigate the user to entity navigation screen.", "User settings and sign out button": "This will have logged in user settings and sign out button.", "User's current location": "This will show the user's current location in the app.",
{{ ' Office Name ' | translate }}