WEB-605 Change the vNEXT to MIFOS_INTERBANK_TRANSFERS variable and set it true as default (#3016)

README.md

@@ -322,6 +322,10 @@ M**\*** T\*\*\*
 
 This applies to client name display, e.g. in Institution/Clients list.
 
+## Interbank Transfer Menu
+
+By default, the “Interbank Transfer” menu will be displayed in the hamburger menu of the Savings account.
+
 ## Releases
 
 ### 1.0.0 (Tag: 1.0.0-fineract1.11)

src/app/account-transfers/account-transfers.service.ts

@@ -132,7 +132,7 @@ export class AccountTransfersService {
     const headers = new HttpHeaders({ 'Content-Type': 'application/json' });
     return this.http
       .post(
-        `${environment.vNextApiUrl}${environment.vNextApiVersion}${environment.vNextApiProvider}/participant`,
+        `${environment.mifosInterbankTransfersApiUrl}${environment.mifosInterbankTransfersApiVersion}${environment.mifosInterbankTransfersApiProvider}/participant`,
         JSON.stringify(payload),
         { headers }
       )
@@ -140,7 +140,7 @@ export class AccountTransfersService {
         switchMap((participant: any) => {
           const body = JSON.stringify({ ...payload, ownerFspId: participant.fspId });
           return this.http.post(
-            `${environment.vNextApiUrl}${environment.vNextApiVersion}${environment.vNextApiProvider}/partyinfo`,
+            `${environment.mifosInterbankTransfersApiUrl}${environment.mifosInterbankTransfersApiVersion}${environment.mifosInterbankTransfersApiProvider}/partyinfo`,
             body,
             { headers }
           );
@@ -151,7 +151,7 @@ export class AccountTransfersService {
   sendInterbankTransfer(body: any): Observable<any> {
     const headers = new HttpHeaders({ 'Content-Type': 'application/json' });
     return this.http.post(
-      `${environment.vNextApiUrl}${environment.vNextApiVersion}${environment.vNextApiProvider}/executetransfer`,
+      `${environment.mifosInterbankTransfersApiUrl}${environment.mifosInterbankTransfersApiVersion}${environment.mifosInterbankTransfersApiProvider}/executetransfer`,
       body,
       { headers }
     );

src/app/savings/savings-account-view/savings-account-view.component.ts

@@ -136,7 +136,7 @@ export class SavingsAccountViewComponent implements OnInit {
         taskPermissionName: 'CREATE_ACCOUNTTRANSFER'
       });
     }
-    if (this.savingsAccountData.externalId && environment.interbankTransfers) {
+    if (this.savingsAccountData.externalId && environment.mifosInterbankTransfersEnabled) {
       this.buttonConfig.addOption({
         name: 'Interbank Transfer',
         taskPermissionName: 'CREATE_ACCOUNTTRANSFER'

src/assets/env.js

@@ -62,6 +62,12 @@
   // Hide client data (mask names)
   window['env']['complianceHideClientData'] = '';
 
+   // Interbank Transfers Environment variables
+  window['env']['mifosInterbankTransfersApiUrl'] = '';
+  window['env']['mifosInterbankTransfersApiProvider'] = '';
+  window['env']['mifosInterbankTransfersApiVersion'] = '';
+  window['env']['mifosInterbankTransfersEnabled'] = 'true';
+  
   // OIDC Plugin Environment variables
   window['env']['oidcServerEnabled'] = false;
   window['env']['oidcBaseUrl']       = '';

src/assets/env.template.js

@@ -75,10 +75,10 @@
   // Hide client data (mask names)
   window['env']['complianceHideClientData'] = '$MIFOS_COMPLIANCE_HIDE_CLIENT_DATA';
 
-  window['env']['vNextApiUrl'] = '$VNEXT_API_URL';
+  window['env']['mifosInterbankTransfersApiUrl'] = '$MIFOS_INTERBANK_TRANSFERS_API_URL';
-  window['env']['vNextApiProvider'] = '$VNEXT_API_PROVIDER';
+  window['env']['mifosInterbankTransfersApiProvider'] = '$MIFOS_INTERBANK_TRANSFERS_API_PROVIDER';
-  window['env']['vNextApiVersion'] = '$VNEXT_API_VERSION';
+  window['env']['mifosInterbankTransfersApiVersion'] = '$MIFOS_INTERBANK_TRANSFERS_API_VERSION';
-  window['env']['interbankTransfers'] = '$VNEXT_INTERBANK_TRANSFERS';
+  window['env']['mifosInterbankTransfersEnabled'] = '$MIFOS_INTERBANK_TRANSFERS_ENABLED';
 
   // OIDC Plugin Environment variables
   window['env']['oidcServerEnabled'] = '$FINERACT_PLUGIN_OIDC_ENABLED';

src/environments/environment.prod.ts

@@ -73,10 +73,10 @@ export const environment = {
   },
   httpCacheEnabled: loadedEnv.httpCacheEnabled || false,
 
-  vNextApiUrl: window['env']['vNextApiUrl'] || 'https://apis.mifos.community',
+  mifosInterbankTransfersApiUrl: loadedEnv['mifosInterbankTransfersApiUrl'] || 'https://apis.mifos.community',
-  vNextApiProvider: window['env']['vNextApiProvider'] || '/vnext1',
+  mifosInterbankTransfersApiProvider: loadedEnv['mifosInterbankTransfersApiProvider'] || '/vnext1',
-  vNextApiVersion: window['env']['vNextApiVersion'] || '/v1.0',
+  mifosInterbankTransfersApiVersion: loadedEnv['mifosInterbankTransfersApiVersion'] || '/v1.0',
-  interbankTransfers: window['env']['interbankTransfers'] || false,
+  mifosInterbankTransfersEnabled: loadedEnv['mifosInterbankTransfersEnabled'] ?? true,
 
   minPasswordLength: loadedEnv['minPasswordLength'] || 12,
 

src/environments/environment.ts

@@ -77,10 +77,10 @@ export const environment = {
   },
   httpCacheEnabled: loadedEnv.httpCacheEnabled || false,
 
-  vNextApiUrl: window.env?.vNextApiUrl || 'https://apis.flexcore.mx',
+  mifosInterbankTransfersApiUrl: window.env?.mifosInterbankTransfersApiUrl || 'https://apis.flexcore.mx',
-  vNextApiProvider: window.env?.vNextApiProvider || '/vnext1',
+  mifosInterbankTransfersApiProvider: window.env?.mifosInterbankTransfersApiProvider || '/vnext1',
-  vNextApiVersion: window.env?.vNextApiVersion || '/v1.0',
+  mifosInterbankTransfersApiVersion: window.env?.mifosInterbankTransfersApiVersion || '/v1.0',
-  interbankTransfers: window.env?.interbankTransfers || false,
+  mifosInterbankTransfersEnabled: window.env?.mifosInterbankTransfersEnabled ?? true,
 
   minPasswordLength: loadedEnv.minPasswordLength || 12,
 

src/types/global.d.ts

@@ -20,10 +20,10 @@ interface Window {
     waitTimeForNotifications?: number;
     waitTimeForCOBCatchUp?: number;
     sessionIdleTimeout?: number;
-    vNextApiUrl?: string;
+    mifosInterbankTransfersApiUrl?: string;
-    vNextApiProvider?: string;
+    mifosInterbankTransfersApiProvider?: string;
-    vNextApiVersion?: string;
+    mifosInterbankTransfersApiVersion?: string;
-    interbankTransfers?: boolean;
+    mifosInterbankTransfersEnabled?: boolean;
     minPasswordLength?: number;
   };
 }

src/typings.d.ts

@@ -34,10 +34,10 @@ interface Window {
     waitTimeForNotifications?: number;
     waitTimeForCOBCatchUp?: number;
     sessionIdleTimeout?: number;
-    vNextApiUrl?: string;
+    mifosInterbankTransfersApiUrl?: string;
-    vNextApiProvider?: string;
+    mifosInterbankTransfersApiProvider?: string;
-    vNextApiVersion?: string;
+    mifosInterbankTransfersApiVersion?: string;
-    interbankTransfers?: boolean;
+    mifosInterbankTransfersEnabled?: boolean;
     minPasswordLength?: number;
   };
 }