From 3c68f98b842a5fe1ed056710e96ede585ac74e34 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Norbert=20T=C3=A1skai?= <taskain@gmail.com>
Date: Wed, 31 Jan 2024 10:09:35 +0100
Subject: [PATCH] Remove `disableScheduleExtensionForDownPayment`

---
 .../loan-product-summary.component.html                    | 5 -----
 .../loan-product-settings-step.component.html              | 7 -------
 .../loan-product-settings-step.component.ts                | 5 -----
 .../products/loan-products/models/loan-product.model.ts    | 1 -
 4 files changed, 18 deletions(-)

diff --git a/src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.html b/src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.html
index 478f22767..5d1d44b65 100644
--- a/src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.html
+++ b/src/app/products/loan-products/common/loan-product-summary/loan-product-summary.component.html
@@ -375,11 +375,6 @@
     <span  fxFlex="53%">{{ loanProduct.enableAutoRepaymentForDownPayment | yesNo }}</span>
   </div>
 
-  <div fxFlexFill *ngIf="loanProduct.enableDownPayment" fxLayout="row wrap" fxLayout.lt-md="column">
-    <span fxFlex="47%">Do not extend loan schedule for multi disbursal:</span>
-    <span  fxFlex="53%">{{ loanProduct.disableScheduleExtensionForDownPayment | yesNo }}</span>
-  </div>
-
   <h3 class="mat-h3" fxFlexFill>Moratorium</h3>
 
   <div fxFlexFill *ngIf="loanProduct.delinquencyBucket">
diff --git a/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html b/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html
index 494cc408b..5baada16f 100644
--- a/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html
+++ b/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.html
@@ -136,13 +136,6 @@
       </mat-checkbox>
     </div>
 
-    <div *ngIf="loanProductSettingsForm.value.multiDisburseLoan && loanProductSettingsForm.value.enableDownPayment" fxFlexFill fxLayout="row wrap" fxLayoutGap="2%" fxLayout.lt-md="column">
-      <mat-checkbox fxFlex="48%" labelPosition="before" formControlName="disableScheduleExtensionForDownPayment" matTooltip="Enable or disable If Fineract extends the
-      repayment schedule to the exact number of repayments configured for that loan account" class="margin-b">
-        Do not extend loan schedule for multi disbursal
-      </mat-checkbox>
-    </div>
-
     <mat-divider fxFlex="98%"></mat-divider>
 
     <span fxFlex="48%" fxHide.lt-md></span>
diff --git a/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.ts b/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.ts
index 4b67ede30..d784d4a0d 100644
--- a/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.ts
+++ b/src/app/products/loan-products/loan-product-stepper/loan-product-settings-step/loan-product-settings-step.component.ts
@@ -392,11 +392,9 @@ export class LoanProductSettingsStepComponent implements OnInit {
         if (enableDownPayment) {
           this.loanProductSettingsForm.addControl('disbursedAmountPercentageForDownPayment', new UntypedFormControl(0, [Validators.required, rangeValidator(0, 100) ]));
           this.loanProductSettingsForm.addControl('enableAutoRepaymentForDownPayment', new UntypedFormControl(false, []));
-          this.loanProductSettingsForm.addControl('disableScheduleExtensionForDownPayment', new UntypedFormControl(false, []));
         } else {
           this.loanProductSettingsForm.removeControl('disbursedAmountPercentageForDownPayment');
           this.loanProductSettingsForm.removeControl('enableAutoRepaymentForDownPayment');
-          this.loanProductSettingsForm.removeControl('disableScheduleExtensionForDownPayment');
         }
       });
 
@@ -508,9 +506,6 @@ export class LoanProductSettingsStepComponent implements OnInit {
 
   get loanProductSettings() {
     const productSettings = this.loanProductSettingsForm.value;
-    if (!this.loanProductSettingsForm.value.multiDisburseLoan) {
-      delete productSettings['disableScheduleExtensionForDownPayment'];
-    }
     if (this.loanProductSettingsForm.value.useDueForRepaymentsConfigurations) {
       productSettings['dueDaysForRepaymentEvent'] = null;
       productSettings['overDueDaysForRepaymentEvent'] = null;
diff --git a/src/app/products/loan-products/models/loan-product.model.ts b/src/app/products/loan-products/models/loan-product.model.ts
index 0e3af4889..7c3397cbc 100644
--- a/src/app/products/loan-products/models/loan-product.model.ts
+++ b/src/app/products/loan-products/models/loan-product.model.ts
@@ -91,7 +91,6 @@ export interface LoanProduct {
   overDueDaysForRepaymentEvent:                              number;
   enableDownPayment:                                         boolean;
   enableAutoRepaymentForDownPayment:                         boolean;
-  disableScheduleExtensionForDownPayment:                    boolean;
   enableInstallmentLevelDelinquency:                         boolean;
   loanScheduleType:                                          OptionData;
   loanScheduleProcessingType:                                OptionData;