WEB-638 fix: improve core utility logic and migrate from deprecated substr (#3062)

improve

src/app/system/external-services/amazon-s3/amazon-s3.component.ts

@@ -95,7 +95,7 @@ export class AmazonS3Component implements OnInit {
     const value = configuration.value;
     if (configuration.name === 's3_access_key' || configuration.name === 's3_secret_key') {
       return value
-        ? value.replace(value.substr(1, value.length - 3), value.substr(1, value.length - 3).replace(/./g, '*'))
+        ? value.replace(value.substring(1, value.length - 2), value.substring(1, value.length - 2).replace(/./g, '*'))
         : '';
     }
     return value;

src/app/system/external-services/notification/notification.component.ts

@@ -94,7 +94,10 @@ export class NotificationComponent implements OnInit {
   getConfigurationValue(configuration: any): string {
     const value = configuration.value;
     if (configuration.name === 'server_key') {
-      return value.replace(value.substr(1, value.length - 3), value.substr(1, value.length - 3).replace(/./g, '*'));
+      return value.replace(
+        value.substring(1, value.length - 2),
+        value.substring(1, value.length - 2).replace(/./g, '*')
+      );
     }
     return value;
   }

src/app/system/manage-data-tables/column-dialog/column-dialog.component.ts

@@ -110,7 +110,7 @@ export class ColumnDialogComponent implements OnInit {
         return 'Dropdown';
       }
       default: {
-        return columnDisplayType[0] + columnDisplayType.substr(1).toLowerCase();
+        return columnDisplayType[0] + columnDisplayType.substring(1).toLowerCase();
       }
     }
   }

src/app/system/manage-data-tables/edit-data-table/edit-data-table.component.ts

@@ -449,7 +449,7 @@ export class EditDataTableComponent implements OnInit {
         return 'Dropdown';
       }
       default: {
-        return columnDisplayType[0] + columnDisplayType.substr(1).toLowerCase();
+        return columnDisplayType[0] + columnDisplayType.substring(1).toLowerCase();
       }
     }
   }