WEB-569 Negative Values Allowed for Repayment Event Days in Loan Product Creation Form (#2984)

This commit is contained in:
Soni Jay
2026-01-11 13:28:51 -06:00
committed by GitHub
parent bb26080c07
commit 559335909b
2 changed files with 10 additions and 3 deletions
@@ -760,6 +760,7 @@
<mat-label>{{ 'labels.inputs.Due days for repayment event' | translate }}</mat-label> <mat-label>{{ 'labels.inputs.Due days for repayment event' | translate }}</mat-label>
<input <input
type="number" type="number"
min="0"
matInput matInput
matTooltip="{{ 'tooltips.Maximum outstanding loan account balance' | translate }}" matTooltip="{{ 'tooltips.Maximum outstanding loan account balance' | translate }}"
formControlName="dueDaysForRepaymentEvent" formControlName="dueDaysForRepaymentEvent"
@@ -769,6 +770,7 @@
<mat-label>{{ 'labels.inputs.OverDue days for repayment event' | translate }}</mat-label> <mat-label>{{ 'labels.inputs.OverDue days for repayment event' | translate }}</mat-label>
<input <input
type="number" type="number"
min="0"
matInput matInput
matTooltip="{{ 'tooltips.Maximum outstanding loan account balance' | translate }}" matTooltip="{{ 'tooltips.Maximum outstanding loan account balance' | translate }}"
formControlName="overDueDaysForRepaymentEvent" formControlName="overDueDaysForRepaymentEvent"
@@ -361,8 +361,14 @@ export class LoanProductSettingsStepComponent implements OnInit {
enableDownPayment: [false], enableDownPayment: [false],
enableInstallmentLevelDelinquency: [false], enableInstallmentLevelDelinquency: [false],
useDueForRepaymentsConfigurations: [false], useDueForRepaymentsConfigurations: [false],
dueDaysForRepaymentEvent: [''], dueDaysForRepaymentEvent: [
overDueDaysForRepaymentEvent: [''], '',
[Validators.min(0)]
],
overDueDaysForRepaymentEvent: [
'',
[Validators.min(0)]
],
loanScheduleType: [ loanScheduleType: [
LoanProducts.LOAN_SCHEDULE_TYPE_CUMULATIVE, LoanProducts.LOAN_SCHEDULE_TYPE_CUMULATIVE,
Validators.required Validators.required
@@ -410,7 +416,6 @@ export class LoanProductSettingsStepComponent implements OnInit {
this.loanProductSettingsForm.removeControl('maximumGap'); this.loanProductSettingsForm.removeControl('maximumGap');
} }
}); });
this.loanProductSettingsForm this.loanProductSettingsForm
.get('isInterestRecalculationEnabled') .get('isInterestRecalculationEnabled')
.valueChanges.subscribe((isInterestRecalculationEnabled: any) => { .valueChanges.subscribe((isInterestRecalculationEnabled: any) => {