Fix to display the Advance Payment Allocation data in Loan Product general tab (#1875)

Co-authored-by: Jose Alberto Hernandez <alberto@blue-daemon.local>

src/app/products/loan-products/view-loan-product/general-tab/general-tab.component.html

@@ -336,7 +336,8 @@
     <span fxFlex="60%">
       <mat-accordion>
         <mifosx-view-advance-paymeny-allocation *ngFor="let paymentAllocation of loanProduct.paymentAllocation"
-          [paymentAllocation]="paymentAllocation">
+          [paymentAllocation]="paymentAllocation"
+          [advancePaymentAllocationData]="advancePaymentAllocationData">
         </mifosx-view-advance-paymeny-allocation>
       </mat-accordion>
     </span>

src/app/products/loan-products/view-loan-product/general-tab/general-tab.component.ts

@@ -1,5 +1,6 @@
 import { Component, OnInit } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
+import { AdvancePaymentAllocationData } from '../../loan-product-stepper/loan-product-payment-strategy-step/payment-allocation-model';
 
 @Component({
   selector: 'mifosx-general-tab',
@@ -15,6 +16,8 @@ export class GeneralTabComponent implements OnInit {
   paymentFundSourceDisplayedColumns: string[] = ['paymentTypeId', 'fundSourceAccountId'];
   feesPenaltyIncomeDisplayedColumns: string[] = ['chargeId', 'incomeAccountId'];
 
+  advancePaymentAllocationData: AdvancePaymentAllocationData | null = null;
+
   constructor(private route: ActivatedRoute) {
     this.route.data.subscribe((data: { loanProduct: any }) => {
       this.loanProduct = data.loanProduct;

src/app/products/loan-products/view-loan-product/shared/view-advance-paymeny-allocation/view-advance-paymeny-allocation.component.ts

@@ -17,16 +17,25 @@ export class ViewAdvancePaymenyAllocationComponent implements OnInit {
   }
 
   transactionTypeValue(code: string): string {
+    if (this.advancePaymentAllocationData == null) {
+      return code;
+    }
     const transactionType =  this.advancePaymentAllocationData.transactionTypes.find(t => t.code === code);
     return transactionType.value;
   }
 
   allocationRuleValue(code: string): string {
+    if (this.advancePaymentAllocationData == null) {
+      return code;
+    }
     const allocationType =  this.advancePaymentAllocationData.allocationTypes.find(t => t.code === code);
     return allocationType.value;
   }
 
   futureInstallmentRuleValue(code: string): string {
+    if (this.advancePaymentAllocationData == null) {
+      return code;
+    }
     const futureInstallmentAllocationRule =  this.advancePaymentAllocationData.futureInstallmentAllocationRules.find(t => t.code === code);
     return futureInstallmentAllocationRule.value;
   }