Upgrade to node 19 (#1696)

Co-authored-by: Jose Alberto Hernandez <alberto@MacBook-Pro.local>

.github/workflows/build.yml

@@ -21,13 +21,13 @@ jobs:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
       - uses: actions/checkout@v2
 
-      - name: Use Node.js 16
+      - name: Use Node.js 19
         uses: actions/setup-node@v1
         with:
           # no support for lts as of now with github actions.
           # issue link : https://github.com/actions/setup-node/issues/26
-          # lts/gallium node v16.15.1 (npm v8.11.0)
+          # lts/gallium node v19.7.0 (npm v9.5.0)
-          node-version: '16.15.1'
+          node-version: '19.7.0'
       - name: Angular CLI install
         run : npm install -g --silent @angular/cli@13.3.10
 

angular.json

@@ -92,15 +92,24 @@
                   "with": "src/environments/environment.prod.ts"
                 }
               ],
-              "outputHashing": "all"
+              "optimization": true,
+              "sourceMap": true,
+              "namedChunks": true,
+              "outputHashing": "all",
+              "extractLicenses": true,
+              "aot": true,
+              "buildOptimizer": true,
+              "vendorChunk": false
             },
             "development": {
-              "buildOptimizer": false,
+              "optimization": true,
-              "optimization": false,
-              "vendorChunk": true,
-              "extractLicenses": false,
               "sourceMap": true,
-              "namedChunks": true
+              "namedChunks": true,
+              "outputHashing": "all",
+              "extractLicenses": true,
+              "aot": true,
+              "buildOptimizer": true,
+              "vendorChunk": false
             }
           },
           "defaultConfiguration": "production"

src/app/account-transfers/make-account-transfers/make-account-transfers.component.html

@@ -132,7 +132,7 @@
     </mat-card-content>
 
     <mat-card-actions fxLayout="row" fxLayout.xs="column" fxLayoutAlign="center" fxLayoutGap="5px">
-      <button type="button" mat-raised-button [routerLink]="['../../general']">Cancel</button>
+      <button type="button" mat-raised-button [routerLink]="['../..']">Cancel</button>
       <button mat-raised-button color="primary" [disabled]="!makeAccountTransferForm.valid"
         *mifosxHasPermission="'CREATE_ACCOUNTTRANSFER'" (click)="submit()">Submit</button>
     </mat-card-actions>

src/app/loans/loans-routing.module.ts

@@ -287,7 +287,7 @@ const routes: Routes = [
         }
       },
       {
-        path: 'transfer-funds',
+        path: ':loanId/transfer-funds',
         loadChildren: () => import('../account-transfers/account-transfers.module').then(m => m.AccountTransfersModule)
       },
       {

src/app/savings/savings-routing.module.ts

@@ -190,7 +190,7 @@ const routes: Routes = [
         }
       },
       {
-        path: 'transfer-funds',
+        path: ':savingAccountId/transfer-funds',
         loadChildren: () => import('../account-transfers/account-transfers.module').then(m => m.AccountTransfersModule)
       },
       {

src/app/system/manage-jobs/cob-workflow/cob-workflow.component.html

@@ -8,3 +8,7 @@
     Run Catch-Up
   </button>
 </div>
+
+<div class="container space-top">
+  <mifosx-loan-locked></mifosx-loan-locked>
+</div>

src/app/system/manage-jobs/cob-workflow/loan-locked/loan-locked.component.ts

@@ -46,9 +46,6 @@ export class LoanLockedComponent implements OnInit {
     private systemService: SystemService,
     private tasksService: TasksService,
     private dialog: MatDialog) {
-    this.route.data.subscribe((data: { loansData: any }) => {
-      this.loans = data.loansData.content;
-    });
   }
 
   ngOnInit(): void {
@@ -56,6 +53,7 @@ export class LoanLockedComponent implements OnInit {
     this.dataSource.paginator = this.paginator;
     this.selection = new SelectionModel(true, []);
     this.allowRunInlineJob = false;
+    this.getLoansLocked(this.currentPage);
   }
 
   applyFilter(filterValue: string = '') {

src/app/system/system.module.ts

@@ -71,6 +71,7 @@ import { WorkflowJobsComponent } from './manage-jobs/workflow-jobs/workflow-jobs
 import { DragDropModule } from '@angular/cdk/drag-drop';
 import { ManageExternalEventsComponent } from './manage-external-events/manage-external-events.component';
 import { CobWorkflowComponent } from './manage-jobs/cob-workflow/cob-workflow.component';
+import { LoanLockedComponent } from './manage-jobs/cob-workflow/loan-locked/loan-locked.component';
 
 @NgModule({
   imports: [
@@ -141,7 +142,8 @@ import { CobWorkflowComponent } from './manage-jobs/cob-workflow/cob-workflow.co
     WorkflowJobsComponent,
     WorkflowDiagramComponent,
     ManageExternalEventsComponent,
-    CobWorkflowComponent
+    CobWorkflowComponent,
+    LoanLockedComponent
   ],
 })
 export class SystemModule { }

src/app/tasks/checker-inbox-and-tasks/checker-inbox-and-tasks.component.html

@@ -25,10 +25,6 @@
           [active]="rescheduleLoan.isActive" *mifosxHasPermission="'RESCHEDULE_LOAN'">
           Reschedule Loan
         </a>
-        <a mat-tab-link [routerLink]="['./loan-locked']" routerLinkActive #loanLocked="routerLinkActive"
-          [active]="loanLocked.isActive">
-          Loan Locked
-        </a>
       </nav>
 
       <router-outlet></router-outlet>

src/app/tasks/tasks-routing.module.ts

@@ -25,8 +25,6 @@ import { GetLoans } from './common-resolvers/getLoans.resolver';
 import { GetRescheduleLoans } from './common-resolvers/getRescheduleLoans.resolver';
 import { MakerCheckerTemplate } from './common-resolvers/makerCheckerTemplate.resolver';
 import { GetCheckerInboxDetailResolver } from './common-resolvers/getCheckerInboxDetail.resolver';
-import { LoanLockedComponent } from './checker-inbox-and-tasks-tabs/loan-locked/loan-locked.component';
-import { LoanLockedResolver } from './checker-inbox-and-tasks-tabs/loan-locked/loan-locked.resolver';
 
 /** Tasks Routes */
 const routes: Routes = [
@@ -70,14 +68,6 @@ const routes: Routes = [
             loansData: GetLoans
           }
         },
-        {
-          path: 'loan-locked',
-          component: LoanLockedComponent,
-          data: { title: extract('Loan Locked') },
-          resolve: {
-            loansData: LoanLockedResolver
-          }
-        },
         {
           path: 'reschedule-loan',
           component: RescheduleLoanComponent,

src/app/tasks/tasks.module.ts

@@ -14,7 +14,6 @@ import { LoanApprovalComponent } from './checker-inbox-and-tasks-tabs/loan-appro
 import { LoanDisbursalComponent } from './checker-inbox-and-tasks-tabs/loan-disbursal/loan-disbursal.component';
 import { RescheduleLoanComponent } from './checker-inbox-and-tasks-tabs/reschedule-loan/reschedule-loan.component';
 import { ViewCheckerInboxComponent } from './view-checker-inbox/view-checker-inbox.component';
-import { LoanLockedComponent } from './checker-inbox-and-tasks-tabs/loan-locked/loan-locked.component';
 
 /**
  * Tasks Module
@@ -33,8 +32,7 @@ import { LoanLockedComponent } from './checker-inbox-and-tasks-tabs/loan-locked/
     LoanApprovalComponent,
     LoanDisbursalComponent,
     RescheduleLoanComponent,
-    ViewCheckerInboxComponent,
+    ViewCheckerInboxComponent
-    LoanLockedComponent
   ],
   providers: [ ]
 })