Fix Loan products to use global settings in default (#1809)

Co-authored-by: Jose Alberto Hernandez <alberto@blue-daemon.local>

src/app/products/loan-products/create-loan-product/create-loan-product.component.ts

@@ -52,7 +52,7 @@ export class CreateLoanProductComponent implements OnInit {
 
       this.itemsByDefault = loanProducts.setItemsByDefault(data.configurations);
       this.loanProductsTemplate['itemsByDefault'] = this.itemsByDefault;
-      this.loanProductsTemplate = loanProducts.updateLoanProductDefaults(this.loanProductsTemplate);
+      this.loanProductsTemplate = loanProducts.updateLoanProductDefaults(this.loanProductsTemplate, false);
     });
   }
 

src/app/products/loan-products/edit-loan-product/edit-loan-product.component.ts

@@ -52,7 +52,7 @@ export class EditLoanProductComponent implements OnInit {
 
       this.itemsByDefault = loanProducts.setItemsByDefault(data.configurations);
       this.loanProductAndTemplate['itemsByDefault'] = this.itemsByDefault;
-      this.loanProductAndTemplate = loanProducts.updateLoanProductDefaults(this.loanProductAndTemplate);
+      this.loanProductAndTemplate = loanProducts.updateLoanProductDefaults(this.loanProductAndTemplate, true);
     });
   }
 

src/app/products/loan-products/loan-products.ts

@@ -22,12 +22,18 @@ export class LoanProducts {
     return itemsByDefault;
   }
 
-  public updateLoanProductDefaults(loanProductTemplate: any) {
+  public updateLoanProductDefaults(loanProductTemplate: any, isForUpdate: boolean) {
     const itemsByDefault: GlobalConfiguration[] = loanProductTemplate['itemsByDefault'];
     itemsByDefault.forEach((config: GlobalConfiguration) => {
       const propertyName = this.resolvePropertyName(config.name);
       if (propertyName !== '') {
-        loanProductTemplate[propertyName] = config.value;
+        if (isForUpdate) {
+          if (!loanProductTemplate[propertyName] || loanProductTemplate[propertyName] === '') {
+            loanProductTemplate[propertyName] = config.value;
+          }
+        } else {
+          loanProductTemplate[propertyName] = config.value;
+        }
       }
     });
     return loanProductTemplate;