feat(clients): dual-OTP contact-change verification, webcam signature capture, and client history tab
build-run / Run Lint, Build and Deploy (push) Canceled after 0s
Publish Image in Docker Hub / build (push) Canceled after 0s
Playwright E2E Tests / Run Playwright Tests (push) Canceled after 0s
Tests / testRigor (push) Canceled after 0s

Frontend counterpart to the backend dual-OTP contact-change feature:

- New ContactOtpBlockComponent (6-box segmented OTP input) used up to 4x in
  Edit Client (old/new mobile, old/new email — grouped under per-field
  sub-headers) and once each for mobile/email in Create Client, gating
  Save/Save & Next until every required box is verified.
- edit-client.component.ts: detects mobile/email/DOB changes against the
  loaded snapshot using local-date comparison (not `.toISOString()`, which
  false-triggers a day-shift in positive-UTC-offset timezones) and
  trimmed/case-insensitive email comparison (autofill whitespace or re-typed
  casing no longer reads as a change the masked preview can't explain).
- client-kyc-step.component.ts: new `invalidFieldLabels` getter names every
  currently-invalid required KYC field, surfaced via the Save & Next tooltip
  in both create-client and edit-client so a greyed-out button always
  explains what's still missing instead of a generic message.
- CaptureImageDialogComponent generalized for both profile photo and
  signature (photograph-a-paper-signature) capture:
  - Frame aspect now matches the requested getUserMedia resolution
    (4:3 profile / 16:9 signature) with object-fit: cover, eliminating the
    pillarboxing (black bars) a mismatched box previously caused.
  - Suppresses Chromium's auto-injected PiP/cast corner overlay icons.
  - Frame height capped in vh (not just px) so the dialog fits short
    viewports instead of pushing Cancel/Upload below the fold.
- upload-document-dialog.component.ts: generic Documents-tab upload now also
  offers "Capture from Webcam" alongside Browse, reusing the same capture
  dialog.
- New client History tab (reuses the existing Audit Trail data, scoped to
  this client) and dataUrlToFile/dataUrlToBlob util for routing webcam
  captures through the same upload pipelines as a picked file.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
2026-07-26 14:51:04 +05:30
co-authored by Claude Sonnet 5
parent d334dd1669
commit 733d9d22b2
30 changed files with 1803 additions and 43 deletions
@@ -0,0 +1,79 @@
<!--
Copyright since 2025 Mifos Initiative
This Source Code Form is subject to the terms of the Mozilla Public
License, v. 2.0. If a copy of the MPL was not distributed with this
file, You can obtain one at http://mozilla.org/MPL/2.0/.
-->
<div class="history-tab">
<div class="history-tab__header">
<h3>Change History</h3>
<p>Past changes to this client's details and address, pulled from the system Audit Trail.</p>
</div>
<div class="history-tab__table-container">
@if (isLoading) {
<mat-progress-bar mode="indeterminate" class="history-tab__loader"></mat-progress-bar>
}
@if (!isLoading && dataSource.data.length === 0) {
<div class="history-tab__empty">No recorded changes for this client yet.</div>
}
@if (!isLoading && dataSource.data.length > 0) {
<table mat-table [dataSource]="dataSource" class="history-tab__table">
<ng-container matColumnDef="entityName">
<th mat-header-cell *matHeaderCellDef>Entity</th>
<td mat-cell *matCellDef="let row">{{ row.entityName | translateKey: 'auditTrail.entities' }}</td>
</ng-container>
<ng-container matColumnDef="actionName">
<th mat-header-cell *matHeaderCellDef>Action</th>
<td mat-cell *matCellDef="let row">
<span class="history-tab__action-badge">{{ row.actionName | translateKey: 'auditTrail.actions' }}</span>
</td>
</ng-container>
<ng-container matColumnDef="fieldsChanged">
<th mat-header-cell *matHeaderCellDef>Fields Changed</th>
<td mat-cell *matCellDef="let row" class="history-tab__fields">{{ fieldsChanged(row) || '—' }}</td>
</ng-container>
<ng-container matColumnDef="maker">
<th mat-header-cell *matHeaderCellDef>Made By</th>
<td mat-cell *matCellDef="let row">{{ row.maker }}</td>
</ng-container>
<ng-container matColumnDef="madeOnDate">
<th mat-header-cell *matHeaderCellDef>Made On</th>
<td mat-cell *matCellDef="let row" class="history-tab__mono">{{ row.madeOnDate | datetimeFormat }}</td>
</ng-container>
<ng-container matColumnDef="processingResult">
<th mat-header-cell *matHeaderCellDef>Status</th>
<td mat-cell *matCellDef="let row">
<span
class="history-tab__status"
[class.history-tab__status--success]="row.processingResult === 'SUCCESS'"
[class.history-tab__status--failure]="row.processingResult === 'FAILURE'"
[class.history-tab__status--awaiting]="row.processingResult === 'AWAITING_APPROVAL'"
>
{{ row.processingResult }}
</span>
</td>
</ng-container>
<tr mat-header-row *matHeaderRowDef="displayedColumns"></tr>
<tr
mat-row
*matRowDef="let row; columns: displayedColumns"
class="history-tab__row"
[routerLink]="['/system', 'audit-trails', row.id]"
></tr>
</table>
<mat-paginator [pageSize]="10" [pageSizeOptions]="[10, 25, 50]" showFirstLastButtons></mat-paginator>
}
</div>
</div>
@@ -0,0 +1,108 @@
/**
* Copyright since 2025 Mifos Initiative
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
.history-tab {
padding: 16px 0;
}
.history-tab__header {
margin-bottom: 16px;
h3 {
margin: 0 0 4px;
font-size: 18px;
font-weight: 600;
}
p {
margin: 0;
font-size: 13px;
color: rgb(0 0 0 / 60%);
}
}
.history-tab__table-container {
position: relative;
background: #fff;
border-radius: 8px;
box-shadow: 0 1px 4px rgb(0 0 0 / 8%);
overflow-x: auto;
}
.history-tab__loader {
position: absolute;
top: 0;
left: 0;
right: 0;
}
.history-tab__empty {
padding: 32px 16px;
text-align: center;
color: rgb(0 0 0 / 55%);
font-size: 13.5px;
}
.history-tab__table {
width: 100%;
}
.history-tab__row {
cursor: pointer;
&:hover {
background: #f8fafc;
}
}
.history-tab__fields {
max-width: 320px;
white-space: normal;
font-size: 12.5px;
color: #475569;
}
.history-tab__mono {
font-family: 'Roboto Mono', monospace;
font-size: 12.5px;
}
.history-tab__action-badge {
display: inline-block;
padding: 2px 10px;
border-radius: 999px;
background: #eff6ff;
color: #1074b9;
font-size: 11.5px;
font-weight: 600;
}
.history-tab__status {
display: inline-block;
padding: 2px 10px;
border-radius: 999px;
font-size: 11.5px;
font-weight: 700;
background: #f1f5f9;
color: #475569;
&--success {
background: #dcfce7;
color: #15803d;
}
&--failure {
background: #fee2e2;
color: #b91c1c;
}
&--awaiting {
background: #fef3c7;
color: #92400e;
}
}
@@ -0,0 +1,150 @@
/**
* Copyright since 2025 Mifos Initiative
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/.
*/
/** Angular Imports */
import { Component, OnInit, ViewChild, inject } from '@angular/core';
import { ActivatedRoute } from '@angular/router';
import { MatPaginator } from '@angular/material/paginator';
import {
MatTableDataSource,
MatTable,
MatColumnDef,
MatHeaderCellDef,
MatHeaderCell,
MatCellDef,
MatCell,
MatHeaderRowDef,
MatHeaderRow,
MatRowDef,
MatRow
} from '@angular/material/table';
import { MatProgressBar } from '@angular/material/progress-bar';
/** rxjs Imports */
import { forkJoin } from 'rxjs';
/** Custom Services */
import { SystemService } from 'app/system/system.service';
import { DatetimeFormatPipe } from '../../../pipes/datetime-format.pipe';
import { TranslatePipe } from '../../../pipes/translate.pipe';
import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module';
/**
* Client "History" tab — a read-only, client-scoped view over the EXISTING system-wide
* Audit Trail data (no new backend endpoint). Reuses `SystemService.getAuditTrails()`
* exactly as `AuditTrailsComponent` does, pre-filtered to `entityName IN (CLIENT, ADDRESS)`
* + `resourceId = clientId` — two calls (the underlying `filterBy` shape only carries one
* `entityName` value at a time) merged and sorted client-side.
*/
@Component({
selector: 'mifosx-clients-history-tab',
templateUrl: './history-tab.component.html',
styleUrls: ['./history-tab.component.scss'],
imports: [
...STANDALONE_SHARED_IMPORTS,
MatProgressBar,
MatTable,
MatColumnDef,
MatHeaderCellDef,
MatHeaderCell,
MatCellDef,
MatCell,
MatHeaderRowDef,
MatHeaderRow,
MatRowDef,
MatRow,
MatPaginator,
DatetimeFormatPipe,
TranslatePipe
]
})
export class HistoryTabComponent implements OnInit {
private route = inject(ActivatedRoute);
private systemService = inject(SystemService);
/** Client ID (from the parent `:clientId` route param, same pattern as notes-tab). */
clientId: string;
isLoading = false;
displayedColumns: string[] = [
'entityName',
'actionName',
'fieldsChanged',
'maker',
'madeOnDate',
'processingResult'
];
dataSource: MatTableDataSource<any> = new MatTableDataSource<any>([]);
@ViewChild(MatPaginator) paginator: MatPaginator;
constructor() {
this.clientId = this.route.parent.snapshot.params['clientId'];
}
ngOnInit(): void {
this.loadHistory();
}
private auditFilterFor(entityName: string): { type: string; value: string }[] {
return [
{ type: 'entityName', value: entityName },
{ type: 'resourceId', value: this.clientId }
];
}
private loadHistory(): void {
this.isLoading = true;
forkJoin({
client: this.systemService.getAuditTrails(this.auditFilterFor('CLIENT'), '', '', 0, 200),
address: this.systemService.getAuditTrails(this.auditFilterFor('ADDRESS'), '', '', 0, 200)
}).subscribe({
next: ({ client, address }: { client: any; address: any }) => {
const merged = [
...(client?.pageItems || []),
...(address?.pageItems || [])
];
// Most recent first — audit trail ids are monotonically increasing.
merged.sort((a, b) => (b?.id ?? 0) - (a?.id ?? 0));
this.dataSource = new MatTableDataSource(merged);
this.dataSource.paginator = this.paginator;
this.isLoading = false;
},
error: () => {
this.isLoading = false;
}
});
}
/**
* Summarises which fields a row changed, parsed from `commandAsJson` — same source
* `ViewAuditComponent` parses for its command/value table, just condensed to a
* comma-separated field list for this compact history view. Boilerplate command
* params (locale/dateFormat) are excluded as noise.
*/
fieldsChanged(row: any): string {
if (!row?.commandAsJson) {
return '';
}
try {
const parsed = JSON.parse(row.commandAsJson);
if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
const ignore = new Set([
'locale',
'dateFormat'
]);
return Object.keys(parsed)
.filter((key) => !ignore.has(key))
.join(', ');
}
} catch {
// Malformed/absent commandAsJson — leave blank rather than throw.
}
return '';
}
}