fix:not able to create a tranche loan account when "Disallow Expected Disbursements" checkbox is disabled  (#1763)

now we can create loan account when “disallow expected disbursements” is disabled

Fixes: #1752

LGTM tested locally all config working as expected
This commit is contained in:
pc_11
2023-06-01 12:55:29 +05:30
committed by GitHub
parent 00ad7c81ce
commit 75686c7f4c
3 changed files with 10 additions and 7 deletions
@@ -297,7 +297,7 @@
<input matInput required formControlName="maxOutstandingLoanBalance"> <input matInput required formControlName="maxOutstandingLoanBalance">
</mat-form-field> </mat-form-field>
<span fxFlex> <span fxFlex>
<button type="button" mat-icon-button color="primary" (click)="addDisbursementDataEntry(disbursementData)" <button type="button" mat-icon-button color="primary" required (click)="addDisbursementDataEntry(disbursementData)"
[disabled]="isMultiDisbursedCompleted"> [disabled]="isMultiDisbursedCompleted">
<fa-icon icon="plus-circle" size="lg"></fa-icon> <fa-icon icon="plus-circle" size="lg"></fa-icon>
</button> </button>
@@ -127,7 +127,8 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
'fixedEmiAmount': this.loansAccountTermsData.fixedEmiAmount, 'fixedEmiAmount': this.loansAccountTermsData.fixedEmiAmount,
'maxOutstandingLoanBalance': this.loansAccountTermsData.maxOutstandingLoanBalance, 'maxOutstandingLoanBalance': this.loansAccountTermsData.maxOutstandingLoanBalance,
'transactionProcessingStrategyCode': this.loansAccountTermsData.transactionProcessingStrategyCode, 'transactionProcessingStrategyCode': this.loansAccountTermsData.transactionProcessingStrategyCode,
'interestRateDifferential':this.loansAccountTermsData.interestRateDifferential 'interestRateDifferential':this.loansAccountTermsData.interestRateDifferential,
'multiDisburseLoan': this.loansAccountTermsData.multiDisburseLoan
}); });
this.multiDisburseLoan = this.loansAccountTermsData.multiDisburseLoan; this.multiDisburseLoan = this.loansAccountTermsData.multiDisburseLoan;
@@ -210,7 +211,8 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
'fixedEmiAmount': this.loansAccountTermsData.fixedEmiAmount, 'fixedEmiAmount': this.loansAccountTermsData.fixedEmiAmount,
'maxOutstandingLoanBalance': this.loansAccountTermsData.maxOutstandingLoanBalance, 'maxOutstandingLoanBalance': this.loansAccountTermsData.maxOutstandingLoanBalance,
'transactionProcessingStrategyCode': this.loansAccountTermsData.transactionProcessingStrategyCode, 'transactionProcessingStrategyCode': this.loansAccountTermsData.transactionProcessingStrategyCode,
'interestRateDifferential':this.loansAccountTermsData.interestRateDifferential 'interestRateDifferential':this.loansAccountTermsData.interestRateDifferential,
'multiDisburseLoan': this.loansAccountTermsData.multiDisburseLoan
}); });
} }
this.createloansAccountTermsForm(); this.createloansAccountTermsForm();
@@ -272,7 +274,8 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
'isTopup': [''], 'isTopup': [''],
'maxOutstandingLoanBalance': [''], 'maxOutstandingLoanBalance': [''],
'interestRateDifferential':[''], 'interestRateDifferential':[''],
'transactionProcessingStrategyCode': ['', Validators.required] 'transactionProcessingStrategyCode': ['', Validators.required],
'multiDisburseLoan': [false]
}); });
} }
@@ -304,8 +307,8 @@ export class LoansAccountTermsStepComponent implements OnInit, OnChanges {
}), }),
new InputBase({ new InputBase({
controlName: 'principal', controlName: 'principal',
label: 'Principal', label: `Principal(It should be less than equal to the ${currentPrincipalAmount})`,
value: (currentPrincipalAmount - this.totalMultiDisbursed), value: '',
type: 'number', type: 'number',
required: true, required: true,
order: 2 order: 2
+1 -1
View File
@@ -587,7 +587,7 @@ export class LoansService {
delete loansAccountData.isValid; delete loansAccountData.isValid;
loansAccountData.principal = loansAccountData.principalAmount; loansAccountData.principal = loansAccountData.principalAmount;
delete loansAccountData.principalAmount; delete loansAccountData.principalAmount;
delete loansAccountData.multiDisburseLoan; //this was just added so that disbursement data can be send in the backend
return loansAccountData; return loansAccountData;
} }