CBSNexora/cbsnexora
4
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(i18n): add missing translations and apply translate pipes across web-app (#2934)

Browse Source 
fix: address code review issues

fix: translate accessibility attributes and fix translation errors
This commit is contained in:
Shubham Kumar
2025-12-26 14:26:08 -06:00
committed by GitHub
parent b096389478
commit 7e55843cd9
43 changed files with 1299 additions and 411 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/account-transfers/list-standing-instructions/list-standing-instructions.component.html
+3 -3
View File
@@ -16,10 +16,10 @@
@if (!isFromClient) {
<div class="flex-fill">
<mat-form-field class="flex-30">
<input matInput placeholder="ClientName" [formControl]="clientNameControl" />
<input matInput placeholder="{{ 'labels.text.ClientName' | translate }}" [formControl]="clientNameControl" />
</mat-form-field>
<mat-form-field class="flex-30">
<input matInput placeholder="From Client Id" [formControl]="fromClientId" />
<input matInput placeholder="{{ 'labels.text.FromClientId' | translate }}" [formControl]="fromClientId" />
</mat-form-field>
</div>
}
@@ -38,7 +38,7 @@
</mat-form-field>
<mat-form-field class="account-Id-field">
<input matInput placeholder="From Account Id" [formControl]="fromAccountId" />
<input matInput placeholder="{{ 'labels.text.FromAccountId' | translate }}" [formControl]="fromAccountId" />
</mat-form-field>
<button
src/app/account-transfers/make-account-transfers/make-account-transfers.component.html
+30 -12
View File
@@ -57,7 +57,7 @@
[(ngModel)]="phoneAccount"
maxlength="10"
required
placeholder="Enter phone number"
placeholder="{{ 'labels.text.EnterPhoneNumber' | translate }}"
title="Phone number"
/>
<mat-hint align="end">{{ phoneAccount.length || 0 }}/10</mat-hint>
@@ -99,7 +99,7 @@
[matDatepicker]="transferDatePicker"
required
formControlName="transferDate"
placeholder="Select date"
placeholder="{{ 'labels.text.SelectDate' | translate }}"
title="Transaction Date"
/>
<mat-datepicker-toggle matSuffix [for]="transferDatePicker"></mat-datepicker-toggle>
@@ -133,7 +133,7 @@
matInput
formControlName="toClientId"
[matAutocomplete]="clientsAutocomplete"
placeholder="Select or type client name"
placeholder="{{ 'labels.text.SelectOrTypeClientName' | translate }}"
title="Client name"
/>
@if (makeAccountTransferForm.controls.toClientId.hasError('required')) {
@@ -191,7 +191,7 @@
matInput
required
formControlName="transferAmount"
placeholder="Enter amount"
placeholder="{{ 'labels.text.EnterAmount' | translate }}"
title="Transfer amount"
min="0.01"
step="0.01"
@@ -216,7 +216,7 @@
formControlName="transferDescription"
cdkTextareaAutosize
cdkAutosizeMinRows="2"
placeholder="Enter transfer description"
placeholder="{{ 'labels.text.EnterTransferDescription' | translate }}"
title="Transfer description"
></textarea>
@if (makeAccountTransferForm.controls.transferDescription.hasError('required')) {
@@ -243,7 +243,7 @@
[matDatepicker]="transferDatePicker"
required
formControlName="transferDate"
placeholder="Select date"
placeholder="{{ 'labels.text.SelectDate' | translate }}"
title="Transaction Date"
/>
<mat-datepicker-toggle matSuffix [for]="transferDatePicker"></mat-datepicker-toggle>
@@ -257,11 +257,23 @@
</mat-form-field>
<mat-form-field class="form-field">
<mat-label>{{ 'labels.inputs.Bank' | translate }}</mat-label>
<input matInput formControlName="toBank" [readonly]="true" placeholder="Bank" title="Bank" />
<input
matInput
formControlName="toBank"
[readonly]="true"
placeholder="{{ 'labels.inputs.Bank' | translate }}"
title="Bank"
/>
</mat-form-field>
<mat-form-field class="form-field">
<mat-label>{{ 'labels.inputs.Client' | translate }}</mat-label>
<input matInput formControlName="toClientId" [readonly]="true" placeholder="Client" title="Client" />
<input
matInput
formControlName="toClientId"
[readonly]="true"
placeholder="{{ 'labels.inputs.Client' | translate }}"
title="Client"
/>
</mat-form-field>
<mat-form-field class="form-field">
<mat-label>{{ 'labels.inputs.Account Type' | translate }}</mat-label>
@@ -269,13 +281,19 @@
matInput
formControlName="toAccountType"
[readonly]="true"
placeholder="Account Type"
placeholder="{{ 'labels.inputs.Account Type' | translate }}"
title="Account Type"
/>
</mat-form-field>
<mat-form-field class="form-field">
<mat-label>{{ 'labels.inputs.Account' | translate }}</mat-label>
<input matInput formControlName="toAccountId" [readonly]="true" placeholder="Account" title="Account" />
<input
matInput
formControlName="toAccountId"
[readonly]="true"
placeholder="{{ 'labels.inputs.Account' | translate }}"
title="Account"
/>
</mat-form-field>
<mat-form-field class="form-field">
<mat-label>{{ 'labels.inputs.Amount' | translate }}</mat-label>
@@ -284,7 +302,7 @@
matInput
required
formControlName="transferAmount"
placeholder="Enter amount"
placeholder="{{ 'labels.text.EnterAmount' | translate }}"
title="Transfer amount"
min="0.01"
step="0.01"
@@ -314,7 +332,7 @@
formControlName="transferDescription"
cdkTextareaAutosize
cdkAutosizeMinRows="2"
placeholder="Enter transfer description"
placeholder="{{ 'labels.text.EnterTransferDescription' | translate }}"
title="Transfer description"
></textarea>
@if (makeAccountTransferForm.controls.transferDescription.hasError('required')) {