CBSNexora/cbsnexora
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix(i18n): add missing translations and apply translate pipes across web-app (#2934)

Browse Source 
fix: address code review issues

fix: translate accessibility attributes and fix translation errors
This commit is contained in:
Shubham Kumar
2025-12-26 14:26:08 -06:00
committed by GitHub
parent b096389478
commit 7e55843cd9
43 changed files with 1299 additions and 411 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/clients/client-stepper/client-family-members-step/client-family-member-dialog/client-family-member-dialog.component.html
+1 -1
View File
@@ -106,7 +106,7 @@
matInput
[max]="maxDate"
[matDatepicker]="dueDatePicker"
placeholder="Optional"
placeholder="{{ 'labels.text.Optional' | translate }}"
/>
<mat-datepicker-toggle matSuffix [for]="dueDatePicker"></mat-datepicker-toggle>
<mat-datepicker #dueDatePicker></mat-datepicker>
src/app/clients/clients-view/custom-dialogs/edit-notes-dialog/edit-notes-dialog.component.html
+1 -1
View File
@@ -2,7 +2,7 @@
<div>
<form #formRef="ngForm" [formGroup]="noteForm">
<mat-form-field>
<textarea formControlName="note" matInput placeholder="Write a note ...."></textarea>
<textarea formControlName="note" matInput placeholder="{{ 'labels.text.Write a note' | translate }}"></textarea>
</mat-form-field>
<mat-dialog-actions align="end">
<button mat-raised-button mat-dialog-close>{{ 'labels.buttons.Cancel' | translate }}</button>
src/app/clients/clients-view/family-members-tab/add-family-member/add-family-member.component.html
+18 -18
View File
@@ -7,9 +7,9 @@
formControlName="firstName"
required
matInput
aria-label="First Name"
placeholder="First Name"
title="First Name"
[attr.aria-label]="'labels.inputs.First Name' | translate"
placeholder="{{ 'labels.inputs.First Name' | translate }}"
[attr.title]="'labels.inputs.First Name' | translate"
/>
@if (addFamilyMemberForm.controls.firstName.hasError('required')) {
<mat-error>
@@ -24,9 +24,9 @@
<input
formControlName="middleName"
matInput
aria-label="Middle Name"
placeholder="Middle Name"
title="Middle Name"
[attr.aria-label]="'labels.inputs.Middle Name' | translate"
placeholder="{{ 'labels.inputs.Middle Name' | translate }}"
[attr.title]="'labels.inputs.Middle Name' | translate"
/>
</mat-form-field>
@@ -36,9 +36,9 @@
formControlName="lastName"
required
matInput
aria-label="Last Name"
placeholder="Last Name"
title="Last Name"
[attr.aria-label]="'labels.inputs.Last Name' | translate"
placeholder="{{ 'labels.inputs.Last Name' | translate }}"
[attr.title]="'labels.inputs.Last Name' | translate"
/>
@if (addFamilyMemberForm.controls.lastName.hasError('required')) {
<mat-error>
@@ -53,9 +53,9 @@
<input
formControlName="qualification"
matInput
aria-label="Qualification"
placeholder="Qualification"
title="Qualification"
[attr.aria-label]="'labels.inputs.Qualification' | translate"
placeholder="{{ 'labels.inputs.Qualification' | translate }}"
[attr.title]="'labels.inputs.Qualification' | translate"
/>
</mat-form-field>
@@ -67,9 +67,9 @@
matInput
[min]="minAge"
disabled
aria-label="Age"
placeholder="Age"
title="Age"
[attr.aria-label]="'labels.inputs.Age' | translate"
placeholder="{{ 'labels.inputs.Age' | translate }}"
[attr.title]="'labels.inputs.Age' | translate"
/>
</mat-form-field>
@@ -140,9 +140,9 @@
matInput
[max]="maxDate"
[matDatepicker]="dueDatePicker"
placeholder="Optional"
aria-label="Date Of Birth"
title="Date Of Birth"
placeholder="{{ 'labels.text.Optional' | translate }}"
[attr.aria-label]="'labels.inputs.Date Of Birth' | translate"
[attr.title]="'labels.inputs.Date Of Birth' | translate"
/>
<mat-datepicker-toggle matSuffix [for]="dueDatePicker"></mat-datepicker-toggle>
<mat-datepicker #dueDatePicker></mat-datepicker>
src/app/clients/clients-view/family-members-tab/edit-family-member/edit-family-member.component.html
+1 -1
View File
@@ -105,7 +105,7 @@
matInput
[max]="maxDate"
[matDatepicker]="dueDatePicker"
placeholder="Optional"
placeholder="{{ 'labels.text.Optional' | translate }}"
/>
<mat-datepicker-toggle matSuffix [for]="dueDatePicker"></mat-datepicker-toggle>
<mat-datepicker #dueDatePicker></mat-datepicker>
src/app/clients/clients.component.html
+1 -1
View File
@@ -4,7 +4,7 @@
<mat-form-field class="search-box">
<input
matInput
placeholder="Search by client name, external Id, mobile"
placeholder="{{ 'labels.text.SearchByClient' | translate }}"
class="search-box"
(keydown.enter)="search($event.target.value)"
/>
src/app/clients/edit-client/edit-client.component.html
-28
View File
@@ -37,8 +37,6 @@
<input
matInput
formControlName="accountNo"
placeholder="Account No"
title="Account No"
[placeholder]="'labels.inputs.Account No' | translate"
[title]="'labels.inputs.Account No' | translate"
/>
@@ -49,8 +47,6 @@
<input
matInput
formControlName="externalId"
placeholder="External Id"
title="External Id"
[placeholder]="'labels.inputs.External Id' | translate"
[title]="'labels.inputs.External Id' | translate"
/>
@@ -68,8 +64,6 @@
matInput
required
formControlName="fullname"
placeholder="Full Name"
title="Full Name"
[placeholder]="'labels.inputs.' + getDateLabel(legalFormId, ['Name', 'Entity Name']) | translate"
[title]="'labels.inputs.' + getDateLabel(legalFormId, ['Name', 'Entity Name']) | translate"
/>
@@ -89,8 +83,6 @@
matInput
required
formControlName="firstname"
placeholder="First Name"
title="First Name"
[placeholder]="'labels.inputs.First Name' | translate"
[title]="'labels.inputs.First Name' | translate"
/>
@@ -109,8 +101,6 @@
<input
matInput
formControlName="middlename"
placeholder="Middle Name"
title="Middle Name"
[placeholder]="'labels.inputs.Middle Name' | translate"
[title]="'labels.inputs.Middle Name' | translate"
/>
@@ -124,8 +114,6 @@
matInput
required
formControlName="lastname"
placeholder="Last Name"
title="Last Name"
[placeholder]="'labels.inputs.Last Name' | translate"
[title]="'labels.inputs.Last Name' | translate"
/>
@@ -152,8 +140,6 @@
[max]="maxDate"
[matDatepicker]="dateOfBirthDatePicker"
formControlName="dateOfBirth"
placeholder="Date of Birth"
title="Date of Birth"
[placeholder]="
'labels.inputs.' + getDateLabel(legalFormId, ['Date of Birth', 'Incorporation Date']) | translate
"
@@ -224,8 +210,6 @@
<mat-form-field class="flex-48" (click)="incorpValidityTillDateDatePicker.open()">
<mat-label>{{ 'labels.inputs.Incorporation Validity Till Date' | translate }}</mat-label>
<input
placeholder="Incorporation Validity Till Date"
title="Incorporation Validity Till Date"
[placeholder]="'labels.inputs.Incorporation Validity Till Date' | translate"
[title]="'labels.inputs.Incorporation Validity Till Date' | translate"
matInput
@@ -242,8 +226,6 @@
<input
matInput
formControlName="incorpNumber"
placeholder="Incorporation No"
title="Incorporation No"
[placeholder]="'labels.inputs.Incorporation No' | translate"
[title]="'labels.inputs.Incorporation No' | translate"
/>
@@ -255,8 +237,6 @@
formControlName="remarks"
cdkTextareaAutosize
cdkAutosizeMinRows="2"
placeholder="Remarks"
title="Remarks"
[placeholder]="'labels.inputs.Remarks' | translate"
[title]="'labels.inputs.Remarks' | translate"
></textarea>
@@ -272,8 +252,6 @@
matInput
type="text"
formControlName="mobileNo"
placeholder="Mobile No"
title="Mobile No"
[placeholder]="'labels.inputs.Mobile No' | translate"
[title]="'labels.inputs.Mobile No' | translate"
/>
@@ -284,8 +262,6 @@
<input
matInput
formControlName="emailAddress"
placeholder="Email Address"
title="Email Address"
[placeholder]="'labels.inputs.Email Address' | translate"
[title]="'labels.inputs.Email Address' | translate"
/>
@@ -325,8 +301,6 @@
<mat-form-field class="flex-48" (click)="submittedOnDatePicker.open()">
<mat-label>{{ 'labels.inputs.Submitted On' | translate }}</mat-label>
<input
placeholder="Submitted On"
title="Submitted On"
[placeholder]="'labels.inputs.Submitted On' | translate"
[title]="'labels.inputs.Submitted On' | translate"
matInput
@@ -349,8 +323,6 @@
<mat-form-field class="flex-48" (click)="activatedOnDatePicker.open()">
<mat-label>{{ 'labels.inputs.Activated On' | translate }}</mat-label>
<input
placeholder="Activated On"
title="Activated On"
[placeholder]="'labels.inputs.Activated On' | translate"
[title]="'labels.inputs.Activated On' | translate"
matInput