fix(i18n): add missing translations and apply translate pipes across web-app (#2934)

fix: address code review issues

fix: translate accessibility attributes and fix translation errors

src/app/loans/loans-account-stepper/loans-account-preview-step/loans-account-preview-step.component.html

@@ -187,7 +187,9 @@
   <div class="flex-fill">
     <span class="flex-40">{{ 'labels.inputs.Amortization' | translate }}</span>
     <span class="flex-60">{{
-      loansAccount.amortizationType | find: loansAccountProductTemplate.amortizationTypeOptions : 'id' : 'value'
+      loansAccount.amortizationType
+        | find: loansAccountProductTemplate.amortizationTypeOptions : 'id' : 'value'
+        | translateKey: 'catalogs'
     }}</span>
   </div>
 
@@ -196,6 +198,7 @@
     <span class="flex-60">{{
       loansAccount.interestCalculationPeriodType
         | find: loansAccountProductTemplate.interestCalculationPeriodTypeOptions : 'id' : 'value'
+        | translateKey: 'catalogs'
     }}</span>
   </div>
 
@@ -227,6 +230,7 @@
     <span class="flex-60">{{
       loansAccount.transactionProcessingStrategyCode
         | find: loansAccountProductTemplate.transactionProcessingStrategyOptions : 'code' : 'name'
+        | translateKey: 'catalogs'
     }}</span>
   </div>
 
@@ -284,7 +288,7 @@
   @if (loansAccountProductTemplate?.daysInMonthType) {
     <div class="flex-fill">
       <span class="flex-40">{{ 'labels.inputs.Days in month' | translate }}: </span>
-      <span class="flex-60">{{ loansAccountProductTemplate?.daysInMonthType.value }}</span>
+      <span class="flex-60">{{ loansAccountProductTemplate?.daysInMonthType.value | translateKey: 'catalogs' }}</span>
     </div>
   }
 

src/app/loans/loans-account-stepper/loans-account-preview-step/loans-account-preview-step.component.ts

@@ -23,6 +23,7 @@ import { FindPipe } from '../../../pipes/find.pipe';
 import { DateFormatPipe } from '../../../pipes/date-format.pipe';
 import { FormatNumberPipe } from '../../../pipes/format-number.pipe';
 import { YesnoPipe } from '../../../pipes/yesno.pipe';
+import { TranslatePipe } from '../../../pipes/translate.pipe';
 import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module';
 
 /**
@@ -53,7 +54,8 @@ import { STANDALONE_SHARED_IMPORTS } from 'app/standalone-shared.module';
     FindPipe,
     DateFormatPipe,
     FormatNumberPipe,
-    YesnoPipe
+    YesnoPipe,
+    TranslatePipe
   ]
 })
 export class LoansAccountPreviewStepComponent implements OnChanges {

src/app/loans/loans-view/account-details/account-details.component.html

@@ -10,9 +10,8 @@
     <div class="flex-fill layout-row">
       <span class="flex-50">{{ 'labels.inputs.Repayments' | translate }}</span>
       <span class="flex-50"
-        >{{ loanDetails.numberOfRepayments }} every {{ loanDetails.repaymentEvery }}&nbsp;{{
-          loanDetails.repaymentFrequencyType.value | translateKey: 'catalogs'
-        }}
+        >{{ loanDetails.numberOfRepayments }} {{ 'labels.commons.every' | translate }}
+        {{ loanDetails.repaymentEvery }}&nbsp;{{ loanDetails.repaymentFrequencyType.value | translateKey: 'catalogs' }}
         @if (
           loanDetails.repaymentFrequencyType?.id === 2 &&
           loanDetails.repaymentFrequencyNthDayType?.id !== 0 &&

src/app/loans/loans-view/general-tab/general-tab.component.html

@@ -29,7 +29,7 @@
       <table mat-table [dataSource]="dataSource">
         <ng-container matColumnDef="Empty">
           <th mat-header-cell *matHeaderCellDef></th>
-          <td mat-cell *matCellDef="let ele">{{ ele.property }}</td>
+          <td mat-cell *matCellDef="let ele">{{ 'labels.inputs.' + ele.property | translate }}</td>
         </ng-container>
         <ng-container matColumnDef="Original">
           <th mat-header-cell class="r-amount" *matHeaderCellDef>{{ 'labels.inputs.Original' | translate }}</th>