CBSNexora/cbsnexora
4
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

WEB-465 Principal Field Allows Zero and Negative Values in Loan Product Creation Form (#2890)

Browse Source
This commit is contained in:
Soni Jay
2025-12-14 14:19:25 -06:00
committed by GitHub
parent 6ef7306e10
commit 7fad7ee756
2 changed files with 25 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/products/loan-products/loan-product-stepper/loan-product-terms-step/loan-product-terms-step.component.html
+9 -11
View File
@@ -10,31 +10,29 @@
<mat-form-field class="flex-31"> <mat-form-field class="flex-31">
<mat-label>{{ 'labels.inputs.Minimum' | translate }}</mat-label> <mat-label>{{ 'labels.inputs.Minimum' | translate }}</mat-label>
<input type="number" matInput formControlName="minPrincipal" [min]="0" /> <input type="number" matInput formControlName="minPrincipal" [min]="1" step="0.01" />
<mat-error> <mat-error *ngIf="loanProductTermsForm.get('minPrincipal')?.hasError('min')">
{{ 'labels.commons.Minimum Value must be' | translate }} {{ 'labels.commons.Minimum Value must be' | translate }}
<strong>{{ 'labels.commons.greater equal to than 0' | translate }}</strong> <strong>{{ loanProductTermsForm.get('minPrincipal')?.errors?.['min']?.min || 1 }}</strong>
</mat-error> </mat-error>
</mat-form-field> </mat-form-field>
<mat-form-field class="flex-31"> <mat-form-field class="flex-31">
<mat-label>{{ 'labels.inputs.Default' | translate }}</mat-label> <mat-label>{{ 'labels.inputs.Default' | translate }}</mat-label>
<input type="number" matInput formControlName="principal" required /> <input type="number" matInput formControlName="principal" required [min]="1" step="0.01" />
<mat-error> <mat-error *ngIf="loanProductTermsForm.get('principal')?.hasError('min')">
{{ 'labels.catalogs.Default' | translate }} {{ 'labels.inputs.Principal' | translate }} {{ 'labels.catalogs.Default' | translate }} {{ 'labels.inputs.Principal' | translate }}
{{ 'labels.commons.is' | translate }} {{ 'labels.commons.is' | translate }}
<strong>{{ 'labels.commons.required' | translate }}</strong> <strong>{{ loanProductTermsForm.get('principal')?.errors?.['min']?.min || 1 }}</strong>
</mat-error> </mat-error>
</mat-form-field> </mat-form-field>
<mat-form-field class="flex-31"> <mat-form-field class="flex-31">
<mat-label>{{ 'labels.inputs.Maximum' | translate }}</mat-label> <mat-label>{{ 'labels.inputs.Maximum' | translate }}</mat-label>
<input type="number" matInput formControlName="maxPrincipal" [min]="0" /> <input type="number" matInput formControlName="maxPrincipal" [min]="1" step="0.01" />
<mat-error> <mat-error *ngIf="loanProductTermsForm.get('maxPrincipal')?.hasError('min')">
{{ 'labels.commons.Minimum Value must be' | translate }} {{ 'labels.commons.Minimum Value must be' | translate }}
<strong>{{ 'labels.commons.greater equal to than 0' | translate }}</strong> <strong>{{ loanProductTermsForm.get('maxPrincipal')?.errors?.['min']?.min || 1 }}</strong>
{{ 'labels.commons.and must be greater than' | translate }}
<strong>{{ 'labels.commons.Minimum Principal' | translate }}</strong>
</mat-error> </mat-error>
</mat-form-field> </mat-form-field>
src/app/products/loan-products/loan-product-stepper/loan-product-terms-step/loan-product-terms-step.component.ts
+16 -3
View File
@@ -188,12 +188,25 @@ export class LoanProductTermsStepComponent implements OnInit, OnChanges {
createLoanProductTermsForm() { createLoanProductTermsForm() {
this.loanProductTermsForm = this.formBuilder.group({ this.loanProductTermsForm = this.formBuilder.group({
useBorrowerCycle: [false], useBorrowerCycle: [false],
minPrincipal: [''], minPrincipal: [
'',
[
Validators.min(1)
]
],
principal: [ principal: [
'', '',
Validators.required [
Validators.required,
Validators.min(1)
]
],
maxPrincipal: [
'',
[
Validators.min(1)
]
], ],
maxPrincipal: [''],
minNumberOfRepayments: [ minNumberOfRepayments: [
'', '',
[ [